From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69586C3DA4A for ; Thu, 1 Aug 2024 11:30:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=oDvznHhGIrt0fdrUyVXtnOeo+v9VoOik8OXXYz4nupY=; b=1mj+dGZYvLANCPLo4i4SRGFien tjF55+aU10luaLWNf7i/Hw+ZUkut1nuPk+y/QLI5Cu5pHCxpvX5arSqo55Op8UGzAn4Oc0/9bzIIM 6FDRW6oZYSBP+ThfyXV36X2l5jFvo322XgKPwYzL82wDDVfuJYJkyY4s3CJnY8MOLSvHA0XYnM+7N Oh35afBZnOxscsEl2l3VkvQBGhqMlCMxxiWyHu/PVVr1Vcrc+7Py4/g9HY6UYJRmL07eAPoOnZoBZ e+vYpalKTkxdxMQsfc3xhwg//SUZsYOp+1BRo93GrPe0JK3HIOEbCcNzD9godG/QqZTDoc714Fri2 DW4fywtg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZU0U-00000004uek-1Je8; Thu, 01 Aug 2024 11:30:06 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZTzz-00000004uXJ-3KJk for linux-arm-kernel@bombadil.infradead.org; Thu, 01 Aug 2024 11:29:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=oDvznHhGIrt0fdrUyVXtnOeo+v9VoOik8OXXYz4nupY=; b=moKH+tASfi0kvuV+Qe0oKFIhg5 XD3WdqWzCTD1Nsf1UpCrD+htkFGxkecXCOYg5mu8ZroSHiKKPV9LXoJfwE+hNx0IktyKOi+EtMJ2f 0eXJfg2xYcrANgN141FKWNXZxeQGqS4qSmUJHtiIOOpoGqBHPzPdGySSAfAGKkRf6mmxY2A0i1VLF wJfmCPkHo2eiuZxyeHURi07f5/O3uQVOZo1PBxvCmDUKrkr1+qTrJf+wGpSy5RUUzstcENLIY0SjR e29geR0wfbWqTOo+0IMqgBJeQg6TlvbIg1sY4DuRLzu7hS0r3oiSEka5aqViroAyvgXaejgm59TOC +NsXPdrw==; Received: from dfw.source.kernel.org ([139.178.84.217]) by desiato.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZTzw-00000005SHy-1dlq for linux-arm-kernel@lists.infradead.org; Thu, 01 Aug 2024 11:29:34 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 33D6A62428; Thu, 1 Aug 2024 11:29:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CDCEEC32786; Thu, 1 Aug 2024 11:29:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722511768; bh=+v6bnfy/JkUEptzDmMNSw8VfmjHMTBPhSIEfPCVBBKs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hCJmJVc0VLSivIDaUoyBk9TvA4Vpc01tGHzKGyScfwE+66RtG24Glw2++orizWuCb 4aZp/v33kN0T6CfFQ8JF7yijuPAZHZRxFw09Hf8Wb+XH8YT3X9c4Zqj+huRxnOrYlf dLYTRjRZKo3+KfD8R4+yVSYDZ2BWr2PMX8O3wlmmLb89WeZZwdGIJA0uTH9I+tE6gU rX0fz7r9dbteaL12aedUaJPAK869GonIM3wM+wtG1TxjjP5Lh73PwKdt6GSsKxzxYr pnLliQ1l2b/XIys+rjZ/8ovOknftcCuRVZFKVK8r+Z86HA6noKUfcXH75qtOC/2HmB A28icfRAQMs+w== Date: Thu, 1 Aug 2024 12:29:24 +0100 From: Will Deacon To: "Rob Herring (Arm)" , catalin.marinas@arm.com Cc: Mark Rutland , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf: arm_pmuv3: Fix chained event check for cycle counter Message-ID: <20240801112923.GA4476@willie-the-truck> References: <20240710182357.3701635-1-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240710182357.3701635-1-robh@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240801_122932_975639_60F5C809 X-CRM114-Status: GOOD ( 16.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 10, 2024 at 12:23:56PM -0600, Rob Herring (Arm) wrote: > Since commit b7e89b0f5bd7 ("perf: arm_pmu: Remove event index to > counter remapping"), armv8pmu_event_is_chained() is incorrectly > returning that the cycle counter is chained, but the cycle counter has > always been 64-bit. The result is trying to configure counter #30 which > typically doesn't exist. > > As ARMV8_PMU_MAX_GENERAL_COUNTERS is the number of counters (31), the > comparison to the counter index needs to be '<' rather than '<='. > > Fixes: b7e89b0f5bd7 ("perf: arm_pmu: Remove event index to counter remapping") > Signed-off-by: Rob Herring (Arm) > --- > drivers/perf/arm_pmuv3.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/perf/arm_pmuv3.c b/drivers/perf/arm_pmuv3.c > index 3b3a3334cc3f..0e22c68fb804 100644 > --- a/drivers/perf/arm_pmuv3.c > +++ b/drivers/perf/arm_pmuv3.c > @@ -482,7 +482,7 @@ static bool armv8pmu_event_is_chained(struct perf_event *event) > return !armv8pmu_event_has_user_read(event) && > armv8pmu_event_is_64bit(event) && > !armv8pmu_has_long_event(cpu_pmu) && > - (idx <= ARMV8_PMU_MAX_GENERAL_COUNTERS); > + (idx < ARMV8_PMU_MAX_GENERAL_COUNTERS); > } Acked-by: Will Deacon Catalin -- please can you pick this up as a fix? Cheers, Will