From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 39CE1C3DA64 for ; Thu, 1 Aug 2024 16:18:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wQTuU6qR13EFs2NHQ6BL0OXr6g/v/sER4c6CH9DF12Q=; b=DsLh/wmbH9D4VymrWx6Rjy9MK2 Aj9Fl9iA4VzhKJ4AHpIpAWa3WnkoeowM8uX9JKxGuTBbdLRE+cD8IDtPoox0xB3hwdIifxh6W0agP xXYn135qAUViY7DxOOigZap+NMwfKJj/1jukKOgqk9StaBlV3PcdlbskTKeaVCv9sFyBkwm5mRgf4 ACpGFmagyUcOVghlr8IDVFoSsB9QyOuqI9Mro+UPL8MaHeUp2IAiBtYBg4CSmxjBWBLTlNkQe4a5W elI2Ie9bchxF24ZWYLmaTMFAy10MrMH/I02JAgZE7iGrUb8kflxmq8DwRVCnv++eoON3YA0pUFhK3 05T8L+ug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZYV9-000000061RL-0fZm; Thu, 01 Aug 2024 16:18:03 +0000 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZYUe-000000061L5-2iiv for linux-arm-kernel@lists.infradead.org; Thu, 01 Aug 2024 16:17:33 +0000 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-4280bca3960so48054485e9.3 for ; Thu, 01 Aug 2024 09:17:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722529050; x=1723133850; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wQTuU6qR13EFs2NHQ6BL0OXr6g/v/sER4c6CH9DF12Q=; b=fX4PhKmvJGBr7e6Y4R+q4ISmPkJtHbWnrLSZwMXBMGjamUbkszzrRIug7nr1LMQlCD VcckP1AMO4LSq/seSqGNZfHOBDH7YPxXVqE36yRa8flsk84xG0TsgVuEqD7r2F6PK7G8 0x6nsPF9OqTuZ33gSVJO0lrRltt1ZZxdxtG6Ljjpba1o/7Eup2mh2xRaI2HfNKt/6UgL Izif32T95lhKOH4lEqDJy6UYElo9impvsKKqtlCvk//+MTbUiGLJaimBlBP5rSWJ8LZe hznzv2dV6vmuibFba0x53qr08T3DBTU0LcyP59jwkK7ChT31NRWEMHyQvxjFLDlh9ImK qcxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722529050; x=1723133850; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wQTuU6qR13EFs2NHQ6BL0OXr6g/v/sER4c6CH9DF12Q=; b=UG3PmvjYG5/sdo5Ie4AKi4fPCxH/UbnIYkQijjt0LivaDIkJE8vAc4SaWSRU3sn5GZ LT4GEaQmGllddB8XqcP1ci8ZLVMaF9iKk3zEsJ8AlSexxjjQJCHUIbQ+vBqEF8bkJgfq A6brMiiZzh/GHfPe8XJdSJmwmqluprkfimW5LeOJq2HC3nwHqAplB40wV6paAlrm/PuR z6ySwey/qx7ebmjiBTvEAb6G06PkPaP2Ma0+W6UlODaRSHrmF3CAifPUI0Ti9TvoErL7 bYZv/fJR0U8hiNLiS4ADDcFs+N6ZsBozMzc7BjobK6cpXWVJ27thi3wYtmA1+oFFOltw Uuwg== X-Forwarded-Encrypted: i=1; AJvYcCV9FG87+tiBGtIwEolGvwVSZguW9kaKF/jJKud9I019v5GcA7jtryh5dr5qe9f1xTJbL8vAePwXjvRv//qDEMitpF3wXcCmYXFxLyJCID/2GwNYV/Y= X-Gm-Message-State: AOJu0Yz3AeGxpLpwp4GykOJcS0LqTo2MB+m8TCrVw5dqB9071oPrxslt C50V6mQEKLHbloljrpJBznoD56nDZ3k/y+SUFmI6+PoxIc6QFmA6 X-Google-Smtp-Source: AGHT+IGuLHUEFnctKFyPwjPEKmH5d3EB5yKodwzaywc+e/ly12Fwykc2aBaSwkWpDaN1Zd26GPaDsw== X-Received: by 2002:a05:600c:524f:b0:428:14b6:ce32 with SMTP id 5b1f17b1804b1-428e6aefb96mr3406355e9.9.1722529050114; Thu, 01 Aug 2024 09:17:30 -0700 (PDT) Received: from skbuf ([188.25.135.70]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-428e6d6b935sm2036285e9.6.2024.08.01.09.17.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Aug 2024 09:17:29 -0700 (PDT) Date: Thu, 1 Aug 2024 19:17:26 +0300 From: Vladimir Oltean To: Furong Xu <0x1207@gmail.com> Cc: Andrew Lunn , "David S. Miller" , Alexandre Torgue , Jose Abreu , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Joao Pinto , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, xfr@outlook.com, rock.xu@nio.com Subject: Re: [PATCH net-next v1 0/5] net: stmmac: FPE via ethtool + tc Message-ID: <20240801161726.mhyv6af43ync7q56@skbuf> References: <20240801160224.4f54tanxs5dz5hwq@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240801160224.4f54tanxs5dz5hwq@skbuf> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240801_091732_708631_7221B2C3 X-CRM114-Status: GOOD ( 16.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 01, 2024 at 07:02:24PM +0300, Vladimir Oltean wrote: > Hi Furong, > > On Wed, Jul 31, 2024 at 06:43:11PM +0800, Furong Xu wrote: > > Move the Frame Preemption(FPE) over to the new standard API which uses > > ethtool-mm/tc-mqprio/tc-taprio. > > Thanks for working on this! I will review it soon. > > On the DWMAC 5.10a that you've tested, were other patches also necessary? > What is the status of the kselftest? Does it pass? Can you post its > output as part of the cover letter? Can you additionally test FPE across a suspend/resume cycle, in 2 cases: - FPE was enabled before suspend, make sure it runs again automatically after resume, and that there are no deadlock issues (to be confirmed with CONFIG_PROVE_LOCKING) - FPE was disabled before suspend, make sure it can be enabled successfully after resume