* [PATCH 1/2] arm64: dts: ti: k3-j721e-sk: Fix reversed C6x carveout locations
@ 2024-08-01 18:12 Andrew Davis
2024-08-01 18:12 ` [PATCH 2/2] arm64: dts: ti: k3-j721e-beagleboneai64: " Andrew Davis
2024-08-28 18:37 ` [PATCH 1/2] arm64: dts: ti: k3-j721e-sk: " Nishanth Menon
0 siblings, 2 replies; 3+ messages in thread
From: Andrew Davis @ 2024-08-01 18:12 UTC (permalink / raw)
To: Nishanth Menon, Vignesh Raghavendra, Tero Kristo, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-kernel, devicetree, linux-kernel, Andrew Davis
The DMA carveout for the C6x core 0 is at 0xa6000000 and core 1 is at
0xa7000000. These are reversed in DT. While both C6x can access either
region, so this is not normally a problem, but if we start restricting
the memory each core can access (such as with firewalls) the cores
accessing the regions for the wrong core will not work. Fix this here.
Fixes: f46d16cf5b43 ("arm64: dts: ti: k3-j721e-sk: Add DDR carveout memory nodes")
Signed-off-by: Andrew Davis <afd@ti.com>
---
arch/arm64/boot/dts/ti/k3-j721e-sk.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
index 89fbfb21e5d3b..e709edeb95cf7 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
+++ b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
@@ -120,7 +120,7 @@ main_r5fss1_core1_memory_region: r5f-memory@a5100000 {
no-map;
};
- c66_1_dma_memory_region: c66-dma-memory@a6000000 {
+ c66_0_dma_memory_region: c66-dma-memory@a6000000 {
compatible = "shared-dma-pool";
reg = <0x00 0xa6000000 0x00 0x100000>;
no-map;
@@ -132,7 +132,7 @@ c66_0_memory_region: c66-memory@a6100000 {
no-map;
};
- c66_0_dma_memory_region: c66-dma-memory@a7000000 {
+ c66_1_dma_memory_region: c66-dma-memory@a7000000 {
compatible = "shared-dma-pool";
reg = <0x00 0xa7000000 0x00 0x100000>;
no-map;
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] arm64: dts: ti: k3-j721e-beagleboneai64: Fix reversed C6x carveout locations
2024-08-01 18:12 [PATCH 1/2] arm64: dts: ti: k3-j721e-sk: Fix reversed C6x carveout locations Andrew Davis
@ 2024-08-01 18:12 ` Andrew Davis
2024-08-28 18:37 ` [PATCH 1/2] arm64: dts: ti: k3-j721e-sk: " Nishanth Menon
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Davis @ 2024-08-01 18:12 UTC (permalink / raw)
To: Nishanth Menon, Vignesh Raghavendra, Tero Kristo, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-kernel, devicetree, linux-kernel, Andrew Davis
The DMA carveout for the C6x core 0 is at 0xa6000000 and core 1 is at
0xa7000000. These are reversed in DT. While both C6x can access either
region, so this is not normally a problem, but if we start restricting
the memory each core can access (such as with firewalls) the cores
accessing the regions for the wrong core will not work. Fix this here.
Fixes: fae14a1cb8dd ("arm64: dts: ti: Add k3-j721e-beagleboneai64")
Signed-off-by: Andrew Davis <afd@ti.com>
---
arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
index a2925555fe818..fb899c99753ec 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
+++ b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
@@ -123,7 +123,7 @@ main_r5fss1_core1_memory_region: r5f-memory@a5100000 {
no-map;
};
- c66_1_dma_memory_region: c66-dma-memory@a6000000 {
+ c66_0_dma_memory_region: c66-dma-memory@a6000000 {
compatible = "shared-dma-pool";
reg = <0x00 0xa6000000 0x00 0x100000>;
no-map;
@@ -135,7 +135,7 @@ c66_0_memory_region: c66-memory@a6100000 {
no-map;
};
- c66_0_dma_memory_region: c66-dma-memory@a7000000 {
+ c66_1_dma_memory_region: c66-dma-memory@a7000000 {
compatible = "shared-dma-pool";
reg = <0x00 0xa7000000 0x00 0x100000>;
no-map;
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] arm64: dts: ti: k3-j721e-sk: Fix reversed C6x carveout locations
2024-08-01 18:12 [PATCH 1/2] arm64: dts: ti: k3-j721e-sk: Fix reversed C6x carveout locations Andrew Davis
2024-08-01 18:12 ` [PATCH 2/2] arm64: dts: ti: k3-j721e-beagleboneai64: " Andrew Davis
@ 2024-08-28 18:37 ` Nishanth Menon
1 sibling, 0 replies; 3+ messages in thread
From: Nishanth Menon @ 2024-08-28 18:37 UTC (permalink / raw)
To: Vignesh Raghavendra, Tero Kristo, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Andrew Davis
Cc: Nishanth Menon, linux-arm-kernel, devicetree, linux-kernel
Hi Andrew Davis,
On Thu, 01 Aug 2024 13:12:31 -0500, Andrew Davis wrote:
> The DMA carveout for the C6x core 0 is at 0xa6000000 and core 1 is at
> 0xa7000000. These are reversed in DT. While both C6x can access either
> region, so this is not normally a problem, but if we start restricting
> the memory each core can access (such as with firewalls) the cores
> accessing the regions for the wrong core will not work. Fix this here.
>
>
> [...]
I have applied the following to branch ti-k3-dts-next on [1].
Thank you!
[1/2] arm64: dts: ti: k3-j721e-sk: Fix reversed C6x carveout locations
commit: 9f3814a7c06b7c7296cf8c1622078ad71820454b
[2/2] arm64: dts: ti: k3-j721e-beagleboneai64: Fix reversed C6x carveout locations
commit: 1a314099b7559690fe23cdf3300dfff6e830ecb1
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-08-28 18:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-01 18:12 [PATCH 1/2] arm64: dts: ti: k3-j721e-sk: Fix reversed C6x carveout locations Andrew Davis
2024-08-01 18:12 ` [PATCH 2/2] arm64: dts: ti: k3-j721e-beagleboneai64: " Andrew Davis
2024-08-28 18:37 ` [PATCH 1/2] arm64: dts: ti: k3-j721e-sk: " Nishanth Menon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).