From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC76FC3DA64 for ; Thu, 1 Aug 2024 23:30:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=S3baeMLXbo97d1fQpSkYNhS6zDdUNnQMvWphkjrQSd0=; b=GwsKsXGNaA45tlAe1YDCaag8N1 ryt6P+xNi9m55nkg2CvATTYPpEeO51MjPw0zHb0ltzBGdOCq3QocBwcRu2soMJQm8Ot64v/pzf94r yWozDLhCikT7ch5kAXCUXb9TOaBdLQ6i0WQhCPI68LO1Whjj3Ae7yMGCoGV4Fy49lRyYC+EkWuxyq So14xnkrJF+g3rnUgEY7Bm4Jaw5QWUEqTe99r2+quvDtO+xcVg4piiPhjay4es4DvyOefsp1jnOiY /D2BsPyGU71uLFBbiG0igMykiE1whBP5KvE28oltBLqprp0pPx05I/23IFicG2DemhY0ifub/XGZs g+A0e58g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZfFP-000000072h8-05VS; Thu, 01 Aug 2024 23:30:15 +0000 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZfEu-000000072Y3-05gY for linux-arm-kernel@lists.infradead.org; Thu, 01 Aug 2024 23:29:45 +0000 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-428085a3ad1so50750655e9.1 for ; Thu, 01 Aug 2024 16:29:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722554981; x=1723159781; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=S3baeMLXbo97d1fQpSkYNhS6zDdUNnQMvWphkjrQSd0=; b=O3enMrjFpeSZ6gtXVCabnoAgXF7hkNCSu0aQA4kXSQtCqOrznQKMOk1L+lI0Z1Fcfh cajbNcAEtv+Arp/i/Y4Xkyob/ZCGmgkca3euC6OwYfvlgcb1khGYYbR8Fmic3QFQ3deB I4pSr5AIWesAvOj8c14hbBVYylXQ202XIRoFOF2FOqi97/Q/leKPETq4EWXevp7GZYNg PWbZXAziEX1WpUMN+nam0TcoS/OX17Xq1jAzcinCnRLcbmvFHorHeseQFSzR73K5sVqh oz/kD3sY0bjLqHLO4i2ZxxDOT/R043pGj5kvmdsKz324wM6hQAg/eVPPZlPyt1vmALps s5Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722554981; x=1723159781; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=S3baeMLXbo97d1fQpSkYNhS6zDdUNnQMvWphkjrQSd0=; b=ZL8w1OnZIHRFx0EyWpGfhbXV3nj5CVHLCeS301d6gN2o8/MKCAlnNpzKbkkl8/1syG 23buYxYASQ/ZQ6NTMQoUTEB9t4NMe9vZc3Qj1hCc7sXGdaFP6+BO53LhhxlWlnoXSOBS N5mZ+cdbCzzgilj4Dy5Qn/VUtNFMYv8Uet984q1g2si5+9U90uzKlH67bFPUNkcdhwpP zei/Wmv2BAxwD1qsu72wDC7jNDznlkoyvrMdEi8rlSD/QgoZg1J4yD5Gji0HHZiVQ3Z+ FbmbNawnLFGxbY2iln2QcVej0HM8Z4SPMMNeg8ULIL2qYa2wvh/xXfzneVQ2RPV6ASIx UJhA== X-Forwarded-Encrypted: i=1; AJvYcCUrXfgxDxFxO8zSbJ4E966itLaEdLsvUHaf/klGPYrBP63/YgallnVWmBz0S5XR8MVISH9CmoAxxsAu0rwLqtcFrpM4PzUxibkbUCZG5CEXJH4dY/U= X-Gm-Message-State: AOJu0YwrPZjEB5VAbXCmA/8csXQ5xZirhyRFcbI/DR+n8sJQIz4Zyxh7 3KtxvR//M0lH1f5pR12qsA67cfZ8+ISrrsaH4PPOp7e7qa5SmzJC X-Google-Smtp-Source: AGHT+IEXPX9rm3NSZIOdjCpUZ485555yJ5pLnsoYLHKaq0ewcpvvtEm0zfRMxyNx/9QoeYLEy/Qyng== X-Received: by 2002:a05:600c:3587:b0:426:593c:935f with SMTP id 5b1f17b1804b1-428e6ae27f7mr9961945e9.1.1722554981158; Thu, 01 Aug 2024 16:29:41 -0700 (PDT) Received: from skbuf ([188.25.135.70]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-428e6e9cd4esm11200035e9.44.2024.08.01.16.29.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Aug 2024 16:29:40 -0700 (PDT) Date: Fri, 2 Aug 2024 02:29:37 +0300 From: Vladimir Oltean To: Furong Xu <0x1207@gmail.com> Cc: Andrew Lunn , "David S. Miller" , Alexandre Torgue , Jose Abreu , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Joao Pinto , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, xfr@outlook.com, rock.xu@nio.com Subject: Re: [PATCH net-next v1 3/5] net: stmmac: support fp parameter of tc-taprio Message-ID: <20240801232937.rmkv3er5cc2lykwf@skbuf> References: <4603a4f68616ce41aca97bac2f55e5d51c865f53.1722421644.git.0x1207@gmail.com> <4603a4f68616ce41aca97bac2f55e5d51c865f53.1722421644.git.0x1207@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4603a4f68616ce41aca97bac2f55e5d51c865f53.1722421644.git.0x1207@gmail.com> <4603a4f68616ce41aca97bac2f55e5d51c865f53.1722421644.git.0x1207@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240801_162944_089493_12406336 X-CRM114-Status: GOOD ( 13.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 31, 2024 at 06:43:14PM +0800, Furong Xu wrote: > tc-taprio can select whether traffic classes are express or preemptible. > > After some traffic tests, MAC merge layer statistics are all good. > > Local device: > ethtool --include-statistics --json --show-mm eth1 > [ { > "ifname": "eth1", > "pmac-enabled": true, > "tx-enabled": true, > "tx-active": true, > "tx-min-frag-size": 60, > "rx-min-frag-size": 60, > "verify-enabled": true, > "verify-time": 100, > "max-verify-time": 128, > "verify-status": "SUCCEEDED", > "statistics": { > "MACMergeFrameAssErrorCount": 0, > "MACMergeFrameSmdErrorCount": 0, > "MACMergeFrameAssOkCount": 0, > "MACMergeFragCountRx": 0, > "MACMergeFragCountTx": 1398, > "MACMergeHoldCount": 15783 In order for readers to really understand this output (including me), could you also post the associated tc-taprio command, please? You deleted the code that treated the Set-And-Hold-MAC GCL command - and according to 802.1Q, that is the only source of Hold requests. I _think_ that as a side effect of your reimplementation, every time the gate for TC 0 opens, the HoldCount bumps by one. Would that be a correct description? The more unfortunate part is that I haven't yet come across a NIC hardware design that would behave completely as you'd expect w.r.t. Hold requests. In the case of DWMAC, I would expect that with a taprio schedule that lacks any Set-And-Hold-MAC command, the HoldCount would stay at zero. I'm not sure, given the way they piggy back onto gate 0 for Hold/Release, that this is possible :( At least HoldCount stays constant with a tc-mqprio offload, right? > } > } ]