From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4E858C3DA4A for ; Thu, 1 Aug 2024 23:44:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=Ep8w5nQ9DtOOSabBpVA4soefFtK7qzFwR0Tq0RHCwEQ=; b=bl7YDJe0LpF+0E wv4AbzKNb2t/JcDg5JLoq7Lc2/o4VG/3T7Jo0F2aI5ux8t4DrwAI81SYNi52d9N9dkbKOxcnsPbct whLwjbyjUmbSETVOR4G0dv3/EAL93XiF1c4x8AFxA02T5mz6B4cpG6glLI7bbHZ9H9A6WcBQMiHGa 8Hb+e9b3ykz5iJ3/v0rxWlhvEKQcNS+SI2xTUFnE04o/QtT11ZLGdNQKlE75Bh1CxBK+j4Z14LKnt jeINwguJMhNcDSyIY6jUqer850gmSLso7IF7acImCUo6QGUppiZL22CHeOzkFoqOmfJBMtcx3uGku Z4f774HMsdGyrdXTIDcA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZfTF-0000000749b-2fvm; Thu, 01 Aug 2024 23:44:33 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZfSk-00000007434-0JYt for linux-arm-kernel@lists.infradead.org; Thu, 01 Aug 2024 23:44:03 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 7BF16CE18D7; Thu, 1 Aug 2024 23:43:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 70FF0C32786; Thu, 1 Aug 2024 23:43:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722555838; bh=SzHZxUFqNTMwJ8KvcmNhUWoSQkRJhCngR3KcpXsTVtQ=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=tNJEQ/VsvtHIHxdmKdpBRb3helOv8NpY3l32E6cWqkxuxoB1VS5vRgmOkFtn1EJ9q ZIxXUm0oqmHNdKDhk/aBQYyaxF/0UHh8fmOIXMgOaB6RshS65woz3yIE9M0NKrXU96 6mc2kNXLbTzm2sqlpZl5kg0rwOBRUoDBzJ0SdGlGmkvJZOlpVK0F0D4E7JgGen3Da7 o9T6xuoSHK9ApLJRsgxJKI40kXlZ64c+mDIv/Pc1+YSuoN/nkkWBqe2CZqfZHkLrNG IuLKDhGAEBO8D2ITYpwaxrfgTkquK55iqj+YGfD3fEcmuXjHhb3nzBvxB5bBXDiilz o9wKKtT9lUEEA== Date: Thu, 1 Aug 2024 18:43:56 -0500 From: Bjorn Helgaas To: steven Cc: linux-pci@vger.kernel.org, Will Deacon , Robin Murphy , Joerg Roedel , linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev Subject: Re: does dtb not support pci acs enable? Message-ID: <20240801234356.GA128584@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <429b2adf.a5a3.190cb82e4ae.Coremail.steven_ygui@163.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240801_164402_310799_1282109B X-CRM114-Status: GOOD ( 16.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org [+cc ARM, IOMMU folks; I don't know the answer, but maybe they do] On Fri, Jul 19, 2024 at 11:01:11PM +0800, steven wrote: > Hello, > > I am a new person in PCI, I am trying to do something for iommu > group on arm64 platform, I found if I boot the linux (5.10 kernel) > kernel using UEFI + ACPI, it will work correctly. But if I boot it > using UEFI + DTB, the iommu group not work, only one group present. > > I read the code, found that pci_acs_enable is set to 1 during > acpi_init, but I can not find any code for dtb booting, so it will > return "disable_acs_redir " during call pci_enable_acs. > > static void pci_enable_acs(struct pci_dev *dev) > { > if (!pci_acs_enable) > goto disable_acs_redir; > > if (!pci_dev_specific_enable_acs(dev)) > goto disable_acs_redir; > > pci_std_enable_acs(dev); > > > > > SO, is it not support in dtb? >