From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 75AE8C3DA64 for ; Fri, 2 Aug 2024 00:01:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=c2AimzwhN5g6StqnFl5MTFB+2mNDJGIUWEPHvbQy0OA=; b=VyuOGYEoxzg+Qq mKjmHVofcGT7hSrmLCk/djEjcypcOvBwNNb23y+7pj90kEHzUVfIHpn6eJzoVISMKTK4TpSRag1yp gQ8odmJE7Sj6+cqLVIZxuCK9eJ1ok/FyH5M7whL8mZ8yJv574dgOlBzqeyUk/P8nYt/1ocIdp6llW ivVrvm8NZmYT4Dy74x4kZjWwXtcMOogpjd1dojIn4uFXFzywFfJBfSk1BSdEoIIbSuhZsqz9OHBWY xytKyIQ6ALAsk2jSROGqbadQxwD3wcUULsBFePR0Y/nZfryxD/XO4axjRY2Lkif9XW5i+YNPb3VlM 3bgebd3DprB4PxfO6yEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZfjU-0000000764I-365P; Fri, 02 Aug 2024 00:01:20 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZfiy-000000075y9-0Skc for linux-arm-kernel@lists.infradead.org; Fri, 02 Aug 2024 00:00:49 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id CD411CE188F; Fri, 2 Aug 2024 00:00:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F2B54C32786; Fri, 2 Aug 2024 00:00:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722556845; bh=s9DRmZAOjs8AFVIVEvu7ZHkhOe+Yhnnol1+u2YrsI4w=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=oDTBVVFHbNgvAsqzccEjJwB3Gxz1M7zwtaO75XU4AJ3GbWZT8F6Qs47EQkH4Ea3SS X1D1s1EsQTP2UIC4JI9Bd4HJ61jTjUDAC82yYwzhtFCLCjqUcyhJj4bpCeFJREhFXq 7mWDjpcPmD38iJ/4Dcv5WpiApvrGIlOaw2DPgSekOLLEjAUoaUhpq3I78JGhBiyUfF 4WBbM6hcgXxi7Z6WIynbpghAcdU6DEc8nBhygyqvVLmCcu+ucEN6bgSLKfJ1xNHerI lD3cB913uRGQbB0UTZZ1udq8kawz9D2pMEgNROnCGK+RrovM23UuNIwtPJtP6Axlft C1wjYApIs7ktA== Date: Thu, 1 Aug 2024 19:00:42 -0500 From: Bjorn Helgaas To: steven Cc: linux-pci@vger.kernel.org, Will Deacon , Robin Murphy , Joerg Roedel , linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, Vidya Sagar , Pavan Kondeti Subject: Re: does dtb not support pci acs enable? Message-ID: <20240802000042.GA129381@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240801234356.GA128584@bhelgaas> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240801_170048_343301_5B9CE725 X-CRM114-Status: GOOD ( 18.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 01, 2024 at 06:43:59PM -0500, Bjorn Helgaas wrote: > [+cc ARM, IOMMU folks; I don't know the answer, but maybe they do] [+cc Vidya, Pavan, also see this recent thread: https://lore.kernel.org/r/PH8PR12MB667446D4A4CAD6E0A2F488B5B83F2@PH8PR12MB6674.namprd12.prod.outlook.com] > On Fri, Jul 19, 2024 at 11:01:11PM +0800, steven wrote: > > Hello, > > > > I am a new person in PCI, I am trying to do something for iommu > > group on arm64 platform, I found if I boot the linux (5.10 kernel) > > kernel using UEFI + ACPI, it will work correctly. But if I boot it > > using UEFI + DTB, the iommu group not work, only one group present. > > > > I read the code, found that pci_acs_enable is set to 1 during > > acpi_init, but I can not find any code for dtb booting, so it will > > return "disable_acs_redir " during call pci_enable_acs. > > > > static void pci_enable_acs(struct pci_dev *dev) > > { > > if (!pci_acs_enable) > > goto disable_acs_redir; > > > > if (!pci_dev_specific_enable_acs(dev)) > > goto disable_acs_redir; > > > > pci_std_enable_acs(dev); > > > > > > > > > > SO, is it not support in dtb? > >