Re: [PATCH v2 2/9] dt-bindings: reset: ast2700: Add ASPEED AST27xx Reset schema

Krzysztof Kozlowski
2024-08-02T09:16:39Z

On 02/08/2024 11:05, Kevin Chen wrote:
> Add Reset schema for AST2700.
>
> Signed-off-by: Kevin Chen <kevin_chen@aspeedtech.com>

So you just ignored all the comments?

No, respond to each of them so we will all know that you understood them.

You already got this comment:
A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

and not much improved. Drop "schema".

Anyway, rest was ignored:


This is a friendly reminder during the review process.

It seems my or other reviewer's previous comments were not fully
addressed. Maybe the feedback got lost between the quotes, maybe you
just forgot to apply it. Please go back to the previous discussion and
either implement all requested changes or keep discussing them.

Thank you.


Best regards,
Krzysztof