From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 24539C3DA7F for ; Fri, 2 Aug 2024 22:49:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+wFsS2aSeOwQTD/jru63bpEvdFhnm3uwt5yHk/HMyYQ=; b=WRVs2jR/xa1hgtOoOYx81UPzHN e1kakzXns4CVPeZGrRI9Dfw5kM6ZHEu67Jz55FqZW/bDgNdWNwIYk9osWqOkCu36oJ9hok3gEUZx+ BoaBGtmgrGNjqwhOYHBCUVoVnrcN05QcAwjRNbiwIbPuQjawUCoMKZgLY6/k8eQi4b2gFy8yj5Wnr 53nc8B75R77PsQ7aWwrug+OQHpLlrIkPO3wH/wkHSlHrGdA4S+792jeXmGcnYq3B4at349uW621gB w4sgUXnGJ7zYF3EjbxL3Tcb5cpxFF2CB/017GnHqb/9+P0wYkcZ/Mw1EkisTsc1K++ywxDPHyjsY/ p5/KoAPA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sa159-0000000AHKh-2M4O; Fri, 02 Aug 2024 22:49:07 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sa14d-0000000AHEY-3BgM for linux-arm-kernel@lists.infradead.org; Fri, 02 Aug 2024 22:48:37 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 472DCCE1AC7; Fri, 2 Aug 2024 22:48:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DBFB9C32782; Fri, 2 Aug 2024 22:48:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722638912; bh=u1OvSoK1rFbwNdxFMjcrpR4gd5lDO5xx65Jvjp77uVU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=qmhwDZJGgTnu1+dpNZRrJeHfPTNenRtIC8SNAzseHLplj1qdOKt0FQZPQGlT15c8V 8pj46mhNxENKcPsgA2mAz+0amh7io/z3VkHcuOMgN5xsaOeBWnYR3cgRswuh1IxzOK twMOW7zE2Bu1GrvvPya+EDlXdGALAdr23yxnCeB8yd/L085d9++zzqzU2gOd9rViso gWXEnKjXWao4MW1TpXUYsQzllc7Utkk30HZDwEHxg1rdP1VZ2ssK3b7scVBtTPHy2o zbELD7LwlL5KYu4zqdADVyBwlFIwYWdL5CQfE782dbdpLlfopUz0xfan84SMNvOlcr axu/1/O1tosjg== Date: Fri, 2 Aug 2024 15:48:30 -0700 From: Jakub Kicinski To: "Russell King (Oracle)" Cc: Serge Semin , Alexandre Torgue , Alexei Starovoitov , Andrew Halaney , bpf@vger.kernel.org, Daniel Borkmann , "David S. Miller" , Eric Dumazet , Jesper Dangaard Brouer , John Fastabend , Jose Abreu , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Coquelin , netdev@vger.kernel.org, Paolo Abeni , Vinod Koul Subject: Re: [PATCH RFC v3 0/14] net: stmmac: convert stmmac "pcs" to phylink Message-ID: <20240802154830.7b147f75@kernel.org> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240802_154836_007475_A81B4268 X-CRM114-Status: UNSURE ( 8.02 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 2 Aug 2024 11:45:21 +0100 Russell King (Oracle) wrote: > Subject: [PATCH RFC v3 0/14] net: stmmac: convert stmmac "pcs" to phylink we have a build error here inside the tasty layered cake that is the op handling in this driver (from patch 2 to 13, inclusive): In file included from drivers/net/ethernet/stmicro/stmmac/common.h:26, from drivers/net/ethernet/stmicro/stmmac/stmmac.h:20, from drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c:= 19: drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c: In function =E2=80=98= stmmac_ethtool_set_link_ksettings=E2=80=99: drivers/net/ethernet/stmicro/stmmac/hwif.h:15:17: error: too many arguments= to function =E2=80=98priv->hw->mac->pcs_ctrl_ane=E2=80=99 15 | (__priv)->hw->__module->__cname((__arg0), ##__args)= ; \ | ^ drivers/net/ethernet/stmicro/stmmac/hwif.h:485:9: note: in expansion of mac= ro =E2=80=98stmmac_do_void_callback=E2=80=99 485 | stmmac_do_void_callback(__priv, mac, pcs_ctrl_ane, __priv, = __args) | ^~~~~~~~~~~~~~~~~~~~~~~ drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c:419:17: note: in expan= sion of macro =E2=80=98stmmac_pcs_ctrl_ane=E2=80=99 419 | stmmac_pcs_ctrl_ane(priv, priv->ioaddr, 1, priv->hw= ->ps, 0); | ^~~~~~~~~~~~~~~~~~~