From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 96067C3DA4A for ; Mon, 5 Aug 2024 14:31:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kVRCZSWzWvbH7we1TJWc5HuPMfOk7AncuWFTgAXLQ/M=; b=1BrH3d8+DWHUjNGB30X2IVg9EZ jTSrYHOJII7g7uzgh7Ni+O0hTRNrX1WtRncGuQdUZkoWWXJTFZUT8B70KsyTJ7QuIRFw1nH0iB9pk DrEsjwhRjYibR8P84SkwjzkVwGwg9DAdk5dfMPhFDjPDCMZP6LbhNKJ6x/8ZA7KcT9pfEkwyneRn1 HHBbt8LamECsII1kuR3mef2pEXi3puVWj8fco5dDfsFPZAh66pT41ArgaowyrQxDu7HSzHd5E9lgj xddfk02P56jEu2+TH36ER8xJIikGeY38O2+A4puC04UAigM6DDEsV4d3oStgz6Qj6eC9apBZSeu1x kpP6A7hA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1saykQ-0000000G9dq-0xVl; Mon, 05 Aug 2024 14:31:42 +0000 Received: from mgamail.intel.com ([192.198.163.7]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sayjo-0000000G9QU-30rj; Mon, 05 Aug 2024 14:31:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1722868265; x=1754404265; h=date:from:to:cc:subject:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=A+ejUO0ucuD8rkWcqVcgovmJzievlnCHGnch/v9cG6Q=; b=d65jg83OMjkSpvNc1K/Q1OX0+NH60kYHWY9NCFhIr5OvDOAwXPAr1LtD vZtkIuOMVueKrhNZ34jylcpllJWBZO5ZJFgPm83nps5mMfxItimF4LsQQ yqa85tGUoLMjfGUqOSzmRCUs6bH5l4j3f+DBNfs7QG3OixysFDR8fgvyF t7o3ZOBSpLzypdsEPvwuF/z2qLiWxEpbBmCSDNn7fYltWwG1k5nR8L58D KmfjR+S2W1svJwWOkFx3fzypWVDD0dsXTddgP1Z/mCZX+Pa2DaoECbw62 HGH+r8tH/criAiVuEphXV1gG+u7r6Uis8Hb0Tb0B3fdNrPdjkbDbNP+qx g==; X-CSE-ConnectionGUID: R0jWDCGQTLSBAWVUokHRew== X-CSE-MsgGUID: f8crJoMGQcyCjeNRfb14uA== X-IronPort-AV: E=McAfee;i="6700,10204,11155"; a="46236825" X-IronPort-AV: E=Sophos;i="6.09,264,1716274800"; d="scan'208";a="46236825" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Aug 2024 07:30:51 -0700 X-CSE-ConnectionGUID: 6keIFrHNSxCUdsGhOh0BZw== X-CSE-MsgGUID: V3hkeNUJSjaoQEVDF9ySdg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,264,1716274800"; d="scan'208";a="60546846" Received: from unknown (HELO localhost) ([10.2.132.131]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Aug 2024 07:30:49 -0700 Date: Mon, 5 Aug 2024 07:30:47 -0700 From: Nirmal Patel To: Marek Vasut Cc: linux-pci@vger.kernel.org, Krzysztof =?UTF-8?Q?Wilczy=C5=84ski?= , Pali =?UTF-8?Q?Roh=C3=A1r?= , Uwe =?UTF-8?Q?Kleine-K=C3=B6nig?= , Aleksandr Mishin , Anna-Maria Behnsen , Anup Patel , Bjorn Helgaas , Broadcom internal kernel review list , Daire McNamara , Damien Le Moal , Florian Fainelli , Hou Zhiqiang , Jianjun Wang , Jim Quinlan , Jingoo Han , Jisheng Zhang , Jon Hunter , Jonathan Derrick , Joyce Ooi , Karthikeyan Mitran , Kishon Vijay Abraham I , Koichiro Den , Lorenzo Pieralisi , Manivannan Sadhasivam , Marc Zyngier , Michal Simek , Nicolas Saenz Julienne , Niklas Cassel , Nipun Gupta , Rob Herring , Ryder Lee , Shivamurthy Shastri , Siddharth Vadapalli , Thierry Reding , Thomas Gleixner , Thomas Petazzoni , Yoshihiro Shimoda , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH v4 12/15] PCI: vmd: Silence set affinity failed warning Message-ID: <20240805073047.0000286a@linux.intel.com> In-Reply-To: <20240723132958.41320-13-marek.vasut+renesas@mailbox.org> References: <20240723132958.41320-1-marek.vasut+renesas@mailbox.org> <20240723132958.41320-13-marek.vasut+renesas@mailbox.org> X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240805_073104_795929_8CF39ADF X-CRM114-Status: GOOD ( 17.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 23 Jul 2024 15:27:12 +0200 Marek Vasut wrote: > Use newly introduced MSI_FLAG_NO_AFFINITY, which keeps > .irq_set_affinity unset and allows migrate_one_irq() code in > cpuhotplug.c to exit right away, without printing "IRQ...: set > affinity failed(-22)" warning. >=20 > Remove .irq_set_affinity implementation which only return -EINVAL > from this controller driver. >=20 > Signed-off-by: Marek Vasut > --- > Cc: "Krzysztof Wilczy=C5=84ski" > Cc: "Pali Roh=C3=A1r" > Cc: "Uwe Kleine-K=C3=B6nig" > Cc: Aleksandr Mishin > Cc: Anna-Maria Behnsen > Cc: Anup Patel > Cc: Bjorn Helgaas > Cc: Broadcom internal kernel review list > Cc: Daire McNamara > Cc: Damien Le Moal > Cc: Florian Fainelli > Cc: Hou Zhiqiang > Cc: Jianjun Wang > Cc: Jim Quinlan > Cc: Jingoo Han > Cc: Jisheng Zhang > Cc: Jon Hunter > Cc: Jonathan Derrick > Cc: Jonathan Hunter > Cc: Joyce Ooi > Cc: Karthikeyan Mitran > Cc: Kishon Vijay Abraham I > Cc: Koichiro Den > Cc: Lorenzo Pieralisi > Cc: Manivannan Sadhasivam > Cc: Marc Zyngier > Cc: Michal Simek > Cc: Nicolas Saenz Julienne > Cc: Niklas Cassel > Cc: Nipun Gupta > Cc: Nirmal Patel > Cc: Rob Herring > Cc: Ryder Lee > Cc: Shivamurthy Shastri > Cc: Siddharth Vadapalli > Cc: Thierry Reding > Cc: Thomas Gleixner > Cc: Thomas Petazzoni > Cc: Yoshihiro Shimoda > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-mediatek@lists.infradead.org > Cc: linux-pci@vger.kernel.org > Cc: linux-renesas-soc@vger.kernel.org > Cc: linux-rpi-kernel@lists.infradead.org > Cc: linux-tegra@vger.kernel.org > --- > V4: - New patch > --- > drivers/pci/controller/vmd.c | 13 +------------ > 1 file changed, 1 insertion(+), 12 deletions(-) >=20 > diff --git a/drivers/pci/controller/vmd.c > b/drivers/pci/controller/vmd.c index a726de0af011f..bc849b0d9e8dc > 100644 --- a/drivers/pci/controller/vmd.c > +++ b/drivers/pci/controller/vmd.c > @@ -204,22 +204,11 @@ static void vmd_irq_disable(struct irq_data > *data) raw_spin_unlock_irqrestore(&list_lock, flags); > } > =20 > -/* > - * XXX: Stubbed until we develop acceptable way to not create > conflicts with > - * other devices sharing the same vector. > - */ > -static int vmd_irq_set_affinity(struct irq_data *data, > - const struct cpumask *dest, bool > force) -{ > - return -EINVAL; > -} > - > static struct irq_chip vmd_msi_controller =3D { > .name =3D "VMD-MSI", > .irq_enable =3D vmd_irq_enable, > .irq_disable =3D vmd_irq_disable, > .irq_compose_msi_msg =3D vmd_compose_msi_msg, > - .irq_set_affinity =3D vmd_irq_set_affinity, > }; > =20 > static irq_hw_number_t vmd_get_hwirq(struct msi_domain_info *info, > @@ -326,7 +315,7 @@ static struct msi_domain_ops vmd_msi_domain_ops =3D > {=20 > static struct msi_domain_info vmd_msi_domain_info =3D { > .flags =3D MSI_FLAG_USE_DEF_DOM_OPS | > MSI_FLAG_USE_DEF_CHIP_OPS | > - MSI_FLAG_PCI_MSIX, > + MSI_FLAG_NO_AFFINITY | MSI_FLAG_PCI_MSIX, > .ops =3D &vmd_msi_domain_ops, > .chip =3D &vmd_msi_controller, > }; Reviewed-by: Nirmal Patel Thanks.