From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F415C3DA4A for ; Mon, 5 Aug 2024 06:44:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=s6fMI2V+iIFbdGWfpib0kcCfB4Ujnw6ekS2SGu24ZM8=; b=3YnmaHpbXOJv4i2A8OouGbicUW ciQsyHwzvIgTNMobe1fues/Qze345+SyuR/G5ElKOHuUsNm4ZsQ3mkWTbbFD0QJkvPiP3VDq7ZY8F Cb0VWpc3fN/0JrKR/hRBm+2M5c6+j/Pg3TxbRjJQ4sA10pxH5KEF3EBzHrpIXusm9u6Yq9YaZIm0C O291IAooarNUD4r52hacxNVrClsHaJ4YPrvI73wC/cnLwb7YGVCmPBiA1EWFaS6wIIJzqOYTyrK9F QTMv04tvztiYe17epPpInEfi13aimoY1k2YjfSq4jdJdLPxX8WQajRqjjy21lp1bAkAR7zZYOsFL/ nEBtOe2A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sarS3-0000000EqCQ-1vWQ; Mon, 05 Aug 2024 06:44:15 +0000 Received: from relay5-d.mail.gandi.net ([217.70.183.197]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sarRW-0000000Eq22-3Xs5 for linux-arm-kernel@lists.infradead.org; Mon, 05 Aug 2024 06:43:45 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id BFDDC1C0002; Mon, 5 Aug 2024 06:43:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1722840218; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s6fMI2V+iIFbdGWfpib0kcCfB4Ujnw6ekS2SGu24ZM8=; b=IXLmoly7c+mkZ12TUUfRtD0urpAI6pYYj6CpO3u/i0qOFDFoRxuqZ0HC1OjG7eH85J9rTo x0d0IAx+cNPoQhJ6Xr60DHpi6DNheT0MYKzydw30FNz1JF1C4ukhseAtn+cnJpIT+pTqwu e/tvCO6s8fohLAxRwb4JaCP83KjGXCI5tAGwN/aYP8Ur+1Rcu73wDaX1I2xRI73LOiYlwP 1snstTXoGK6K9zVE9UmDw8UELLwGpUmAlwh+qx58+ovo6AVfq20bqeRoPWyuwfg0ExluoI DD7qWBxzZgHtKOtnvZU3/ASkSEvjgFG1aEhBxaqNgAKRtb4STCjEwkHpS85sKg== Date: Mon, 5 Aug 2024 08:43:36 +0200 From: Herve Codina To: Rob Herring Cc: Christophe Leroy , Krzysztof Kozlowski , Conor Dooley , Qiang Zhao , Li Yang , Mark Brown , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Petazzoni Subject: Re: [PATCH v1 23/36] dt-bindings: soc: fsl: cpm_qe: Add QUICC Engine (QE) QMC controller Message-ID: <20240805084336.4e711102@bootlin.com> In-Reply-To: <20240730193635.GA2017245-robh@kernel.org> References: <20240729142107.104574-1-herve.codina@bootlin.com> <20240729142107.104574-24-herve.codina@bootlin.com> <20240730193635.GA2017245-robh@kernel.org> Organization: Bootlin X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: herve.codina@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240804_234343_510709_AFE029F0 X-CRM114-Status: GOOD ( 14.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rob, On Tue, 30 Jul 2024 13:36:35 -0600 Rob Herring wrote: ... > > + > > +patternProperties: > > + '^channel@([0-9]|[1-5][0-9]|6[0-3])$': > > Unit-addresses are typically in hex. I thought it was more related to the reg value. In our case, the reg value is just the channel number from 0 to 63. Should I change to a hex format? ... > > + > > + compatible: > > compatible goes first in the list. Yes, I will move it to the first position in the next iteration. > > > + items: > > + - enum: > > + - fsl,mpc8321-ucc-qmc-hdlc > > + - const: fsl,qe-ucc-qmc-hdlc > > + - const: fsl,qmc-hdlc > > Really need 3 compatibles? > The QMC is handled by the QUICC Engine (QE) companion. The QE can be available in several SOCs. The first one is the exact device (SOC MPC8321 + UCC QMC) The second one references the QUICC Engine family instead of the SOC. The last one is the fallback one just referencing the QMC. This one matches all QMCs whatever the SOC and the companion. On QMC handled by the CPM1 companion, we have these tree compatibles: - fsl,mpc885-scc-qmc-hdlc or fsl,mpc866-scc-qmc-hdlc - fsl,cpm1-scc-qmc-hdlc - fsl,qmc-hdlc IMHO, I think it makes sense to have the 3 compatibles. Best regards, Hervé