From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 06B4BC3DA7F for ; Mon, 5 Aug 2024 17:01:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bq5X84vgmQEKbzVl+R+1J6TleNY9HKX0Atv93TXaMhw=; b=CkpwOmIFe+SKIgpUHoMb05Xkjl IsWetLHnrAlVGSCpJDFyEOEn5QZ2ecSaYYVu7CVIiaPEyNpzsvcwp8q6dlWhUgACEzbhVFUQFPVgE o1Ah/u+9VFhnnQVHNBWjJpYewYIguyC3Uv0bGZy9l6L0a1mIgTpGU8Xiw0jW70we15WIrUaCxyBw0 JUsN94nPR5U9gEqS98oi+ZMRD2Fs7xxS/PnTWQE70aag2WxAl2znFSXPzy9hOWEVlY5wVMG4Y8EHr 605Ov0c6dhRWctOTSc5y/2zYPuFhgkhHB7PAhZGKfkR+nTaGnEzcGVYXIyEk4SOSxHL/cbQwd3n89 QmMsRMdQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sb14c-0000000Gbi1-1Hn6; Mon, 05 Aug 2024 17:00:42 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sb145-0000000GbbF-2jgI for linux-arm-kernel@lists.infradead.org; Mon, 05 Aug 2024 17:00:11 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 7DE4CCE0A15; Mon, 5 Aug 2024 17:00:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EDA9EC32782; Mon, 5 Aug 2024 17:00:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722877206; bh=rMg8tq8sXoox5/aZPFwub+kNjISHhCSdM1/upF/TURs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=C/0pGzr/WpVGNgjl3o864EDH0YfyswghtP2JFPG/YAbOf2KUVfUyq7PGLM/NR6kOR 87rpEvhMkovWxOOpoS26eZqCZkm32Hv/DNS/TGIDn0xQt+qVkV4Uv/pcKIRArODVGw XSZPJNefb/wzMP3nw6QOpaiSAt507npkIVj2jkaLp6W1HV++Ii2MPaQs2NtqPeILrA RJraREhJYnLWUApH7eLCjdjzggTVQb+kdONsXoXsbZ/VUHiC2QndgokX87ziDWrjoP pS0jGPK9IquwvcbIw+ZEt6KCx+dJnz61lAMX/kW0wfJPUZ1uAlRTBzsGUkcsX5xZZ+ vIWJ3+BCyzOug== Date: Mon, 5 Aug 2024 18:00:02 +0100 From: Simon Horman To: "Jan Petrous (OSS)" Cc: Maxime Coquelin , Alexandre Torgue , dl-S32 , "linux-kernel@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" , Claudiu Manoil , "netdev@vger.kernel.org" Subject: Re: [PATCH 4/6] net: stmmac: dwmac-s32cc: add basic NXP S32G/S32R glue Message-ID: <20240805170002.GM2636630@kernel.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240805_100009_907569_CD5142C1 X-CRM114-Status: GOOD ( 14.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Aug 04, 2024 at 08:50:10PM +0000, Jan Petrous (OSS) wrote: > NXP S32G2xx/S32G3xx and S32R45 are automotive grade SoCs > that integrate one or two Synopsys DWMAC 5.10/5.20 IPs. > > The basic driver supports only RGMII interface. > > Signed-off-by: Jan Petrous (OSS) ... > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-s32cc.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-s32cc.c ... > +static int s32cc_gmac_init(struct platform_device *pdev, void *priv) > +{ > + struct s32cc_priv_data *gmac = priv; > + int ret; > + > + ret = clk_set_rate(gmac->tx_clk, GMAC_TX_RATE_125M); > + if (!ret) > + ret = clk_prepare_enable(gmac->tx_clk); > + > + if (ret) { > + dev_err(&pdev->dev, "Can't set tx clock\n"); > + return ret; > + } > + > + ret = clk_prepare_enable(gmac->rx_clk); > + if (ret) > + dev_dbg(&pdev->dev, "Can't set rx, clock source is disabled.\n"); > + else > + gmac->rx_clk_enabled = true; > + > + ret = s32cc_gmac_write_phy_intf_select(gmac); > + if (ret) { > + dev_err(&pdev->dev, "Can't set PHY interface mode\n"); Should operations on tx_clk and rx_clk be unwound here? Flagged by Smatch. > + return ret; > + } > + > + return 0; > +} ... > +static int s32cc_dwmac_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + struct plat_stmmacenet_data *plat; > + struct s32cc_priv_data *gmac; > + struct stmmac_resources res; > + int ret; Please consider arranging local variables in Networking code in reverse xmas tree order - longest line to shortest. Flagged by: https://github.com/ecree-solarflare/xmastree > + > + gmac = devm_kzalloc(&pdev->dev, sizeof(*gmac), GFP_KERNEL); > + if (!gmac) > + return PTR_ERR(gmac); This will return 0, perhaps return -ENOMEM ? Flagged by Smatch. ...