From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A8A9AC3DA7F for ; Mon, 5 Aug 2024 19:18:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MUba4erGFgu0wpnMR6tjDN8PIbSEgDITyzb3PDwSkds=; b=UrKPcoo7PUJjXpvXZfQ2x3I0hI L42jWV+ocooCZokMLu9vA7i50NKwDQgRPs4a6XC3nNrmKdIgNHCxESs2SNiMWc1GYC+4WaxAIK441 bwRdvNR06jd+0J8uTITF8IXiQdm/sAldAxnBHr60gD4aobjiXWxu/wTaAxbQ4WQMN4Eoz7fKYAMli cubpga3GhLrkU0+dLq+GonJjAYPDDnQgp6HvqQwO3i/s9qRquuTk+dGzbVl8Pm8zXpl6va9relcsp Mtr9z3cBNaz8W20HSxsaje1hxlDzC43AE5vsjBLJte5JVwP8b8QTCbxho5B3LnIhVHLs++Vmbc2Y/ ZOZOa4+Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sb3DS-0000000Gyuu-1lF0; Mon, 05 Aug 2024 19:17:58 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sb3Cw-0000000Gyma-1NE6; Mon, 05 Aug 2024 19:17:27 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 5EEAC60C4F; Mon, 5 Aug 2024 19:17:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA4DAC32782; Mon, 5 Aug 2024 19:17:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722885445; bh=yIzYBRhu3FkCRao5W4ixWWwmAsOLTrfWSG9/9Ucrdsg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=u1XOg7lq5Gb+Iyutvrb8Ggq1n89ppsPewkZrwb13K7CWOXV1ARdNO+yQznlR51CJv x9DjQkQdymtnwglT35Zr3AzKShlloIi9pbSBHhQ2EU+RLp0dmJCQ66l9NgegZpPZbx S6QVW7Q46UxRi9amYrn3ZRfZGrXJhA1TeNTeXK3MCaIm6KiOVSgtIPPViJ783BI2A8 ue5GOs/Uyl1OXFptfdXDApl1bygdQuBO2dH64KCQBaI+qRFJnTycQlHXQnh88c93Uq VD2po/oxeg5ZwuWR8jHjjzIzBSo6y1R5jMi6xF2A3CYcnDHnP1IVDk97wQl53JhHjK 36UJfSxOdj/Og== Date: Mon, 5 Aug 2024 13:17:23 -0600 From: Rob Herring To: Heiko Stuebner Cc: lee@kernel.org, jdelvare@suse.com, linux@roeck-us.net, dmitry.torokhov@gmail.com, pavel@ucw.cz, krzk+dt@kernel.org, conor+dt@kernel.org, ukleinek@debian.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-hwmon@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, Krzysztof Kozlowski Subject: Re: [PATCH v3 1/7] dt-bindings: mfd: add binding for qnap,ts433-mcu devices Message-ID: <20240805191723.GA2636745-robh@kernel.org> References: <20240731212430.2677900-1-heiko@sntech.de> <20240731212430.2677900-2-heiko@sntech.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240731212430.2677900-2-heiko@sntech.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240805_121726_457376_9214D622 X-CRM114-Status: GOOD ( 17.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 31, 2024 at 11:24:24PM +0200, Heiko Stuebner wrote: > These MCUs can be found in network attached storage devices made by QNAP. > They are connected to a serial port of the host device and provide > functionality like LEDs, power-control and temperature monitoring. > > Reviewed-by: Krzysztof Kozlowski > Signed-off-by: Heiko Stuebner > --- > .../bindings/mfd/qnap,ts433-mcu.yaml | 43 +++++++++++++++++++ > 1 file changed, 43 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/qnap,ts433-mcu.yaml > > diff --git a/Documentation/devicetree/bindings/mfd/qnap,ts433-mcu.yaml b/Documentation/devicetree/bindings/mfd/qnap,ts433-mcu.yaml > new file mode 100644 > index 0000000000000..5ae19d8faedbd > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/qnap,ts433-mcu.yaml > @@ -0,0 +1,43 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/qnap,ts433-mcu.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: QNAP NAS on-board Microcontroller > + > +maintainers: > + - Heiko Stuebner > + > +description: > + QNAP embeds a microcontroller on their NAS devices adding system feature > + as PWM Fan control, additional LEDs, power button status and more. Doesn't really look like the binding is complete. > + > +properties: > + compatible: > + enum: > + - qnap,ts433-mcu > + > + "#cooling-cells": > + const: 2 > + > + cooling-levels: > + description: PWM duty cycle values corresponding to thermal cooling states. > + $ref: /schemas/types.yaml#/definitions/uint32-array > + items: > + maximum: 255 These are fan properties and should be in a "fan" node referencing hwmon/fan-common.yaml. Rob