From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00C6FC3DA64 for ; Tue, 6 Aug 2024 04:56:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=85q65meJHydsbw2SpNer02iCevJGYGCAkmgA8yKAoQk=; b=11ncqXO7DqPo7Cn6bxURuqY+W+ fbEvUNHnpq48vMLLz5Yu/U1Y7uMBp+Q9wwE5a7iIQtPmcTdqNUMji8x27i6TSBsK6mwOwrXIocNnm E28kCTIECQjPL99iPRrFAQCsa9cAAs+pVagtKji6+LpMy7QcAZXB5g4Jf6oYhUra4u/ZH88jRxqe7 SJl77fKcgOy9ScXu9Cgoob4joGUOnd74BCTmPWQpBnINAxEPc2ZE9THfZUhKptAa3uJVBkYRAAxcW vbUqaipayCxHxHkBYWPdo2fl1UOmdSvb3ZyF39ps1ziZ6nVUoOC81XET0EWF69LRwkjDvmm3TT4+e LunJ7etg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbCF2-00000000WAI-28zu; Tue, 06 Aug 2024 04:56:12 +0000 Received: from mail-pg1-x52b.google.com ([2607:f8b0:4864:20::52b]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbCEW-00000000W2X-0SVb for linux-arm-kernel@lists.infradead.org; Tue, 06 Aug 2024 04:55:41 +0000 Received: by mail-pg1-x52b.google.com with SMTP id 41be03b00d2f7-7aa7703cf08so292760a12.2 for ; Mon, 05 Aug 2024 21:55:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722920138; x=1723524938; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=85q65meJHydsbw2SpNer02iCevJGYGCAkmgA8yKAoQk=; b=FwsdEHs5urGDHTyowHbPWQEUr9u22OiabD32Tmezl/RJ5mr0ph39gUq62jjNHvZQgH EjykeB666+67mOfFZvqHR3C1YcBdJYMpW/xI4W143SRuQZMsbS+EG05GlQWn4UjuUxwB Mfja5ng8AswkC8EFAsVxcdIpiGYTd4ZEPccflmO0ZWfUDIrkX0FYT3J7vUz85yW5j9Gt KrnNkNOlLvEpNqKQ+Wm6DxNhCTDKtLEHTXUDHa9cOV8qnlM56BvVx8Qdk7BengVqFsV0 Y/J3+f/6Lwe0bx97c0nlM//zt05u77W1ARHWlYt1rFKFxGA6U+kFwAa1WohlUmdMo//6 TCNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722920138; x=1723524938; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=85q65meJHydsbw2SpNer02iCevJGYGCAkmgA8yKAoQk=; b=WVCi8xr7F/BWE1IIAM1FJNjqD6WbR8w441OTBXmn+PR1pj18vVm1MqIYcNhqlOYrlo txJvxgWY4CqDHvZnDBa7rTLyX8Ax1/bCopbT//+cTbefDgegpdhjuwKTHdW9sN8rH6Or D/lgrJQZitHBdF5AxJ/KAoLvgzLjbNf61EzynqCr3LpA0HsYSiXgUygKn8XSaIwVbfHt gaxOcsqa1cJ8+PNeIkERqyC7urOJJrKwj0mynJzttfs3hlmFqb9zD6W/E0B3fReyZmGR gdIVgd+0fACgKCIwOV4hWc+gt5dMvEK2B4cGS+DdxhmyF8gJa8YCozYgS1D++O9yHPFB JDAQ== X-Forwarded-Encrypted: i=1; AJvYcCWsbXbxz6dMJ1KxlV22wXbOk1+6wafsBvGfy/tYoHkQciE3exMCY/2+oNtWYu5MWE6uU3Jmxnb/DTsWSyFAIvqO@lists.infradead.org X-Gm-Message-State: AOJu0YyY4uKqPTZPqbqlJP2JgZmHAxUfqGN5pgjHS7GEwXkfGMoFUHlB L9W+5TdaOarOzoEawxbzf39cl10yMyYjKblb6brjUP6PpWsS3uZ1 X-Google-Smtp-Source: AGHT+IG9oatnH1xHVkWpI886BnKzAhj9hlfqXwSP17RhqetcsZVbRZp41LdrRYdy6alY4pR/K0sltQ== X-Received: by 2002:a17:90b:1094:b0:2cf:f3c5:871b with SMTP id 98e67ed59e1d1-2cff93d40f1mr16111394a91.6.1722920137930; Mon, 05 Aug 2024 21:55:37 -0700 (PDT) Received: from localhost ([129.146.253.192]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2cffb36bd3dsm8080980a91.36.2024.08.05.21.55.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Aug 2024 21:55:37 -0700 (PDT) Date: Tue, 6 Aug 2024 12:55:24 +0800 From: Furong Xu <0x1207@gmail.com> To: Serge Semin Cc: Vladimir Oltean , Andrew Lunn , "David S. Miller" , Alexandre Torgue , Jose Abreu , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Joao Pinto , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, xfr@outlook.com, rock.xu@nio.com Subject: Re: [PATCH net-next v1 0/5] net: stmmac: FPE via ethtool + tc Message-ID: <20240806125524.00005f51@gmail.com> In-Reply-To: References: X-Mailer: Claws Mail 4.1.1 (GTK 3.24.34; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240805_215540_189864_A2108019 X-CRM114-Status: GOOD ( 20.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Serge On Mon, 5 Aug 2024 20:11:10 +0300, Serge Semin wrote: > Hi Furong > > Thank you very much for the series. I am not that much aware of the > FPE and ethtool MAC Merge guts. But I had a thoughtful glance to the > FPE-handshaking algo and got to a realization that all the FPE-related > data defined in the include/linux/stmmac.h weren't actually > platform-data. All of that are the run-time settings utilized during > the handshaking algo execution. > > So could you please move the fpe_cfg field to the stmmac_priv data and > move the FPE-related declarations from the include/linux/stmmac.h > header file to the drivers/net/ethernet/stmicro/stmmac/stmmac.h file? > It's better to be done in a pre-requisite (preparation) patch of your > series. This will be included in V2 of this patchset. > > Another useful cleanup would be moving the entire FPE-implementation > from stmmac_main.c to a separate module. Thus the main > driver code would be simplified a bit. I guess it could be moved to > the stmmac_tc.c file since FPE is the TC-related feature. Right? Thanks for your advice. A few weeks ago, I sent a patchset to refactor FPE implementation: https://lore.kernel.org/all/cover.1720512888.git.0x1207@gmail.com/ Vladimir suggested me to move the FPE over to the new standard API, then this patchset comes. I am working on V2 of this patchset, once this patchset get merged, a new FPE implementation will be sent to review.