From: Francesco Dolcini <francesco@dolcini.it>
To: "Francesco Dolcini" <francesco@dolcini.it>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>
Cc: Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
Tero Kristo <kristo@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Siddharth Vadapalli <s-vadapalli@ti.com>,
Francesco Dolcini <francesco.dolcini@toradex.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v1 0/2] PCI: ti: k3: Fix TI J721E PERST# polarity
Date: Tue, 6 Aug 2024 16:35:19 +0200 [thread overview]
Message-ID: <20240806143519.GA176293@francesco-nb> (raw)
In-Reply-To: <20240703100036.17896-1-francesco@dolcini.it>
Hello Bjorn, Krzysztof W., Lorenzo
On Wed, Jul 03, 2024 at 12:00:34PM +0200, Francesco Dolcini wrote:
> From: Francesco Dolcini <francesco.dolcini@toradex.com>
>
> Fix PCIe PERST# signal polarity in TI J721E used on TI K3 machines.
>
> PCIe PERST# needs to be de-asserted for PCIe to work, however, the driver is
> doing the opposite and the device tree files are defining the signal with the
> wrong polarity to cope with that. Fix both the driver and the affected DT
> files.
I just had a chat in IRC about this series with Nishanth. He agrees that
this should be merged, even considering that this implies breaking the
compatibility with old device tree blobs.
However we should be sure that both patches get merged in a coordinated
way, to avoid breaking stuff within the same kernel release.
What would be your advise to move forward? Are you ok with the change?
Should I split this series in 2 separated patch?
Francesco
prev parent reply other threads:[~2024-08-06 14:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 10:00 [PATCH v1 0/2] PCI: ti: k3: Fix TI J721E PERST# polarity Francesco Dolcini
2024-07-03 10:00 ` [PATCH v1 1/2] arm64: dts: ti: Mark PCIe PERST# polarity active low in DT Francesco Dolcini
2024-07-03 10:00 ` [PATCH v1 2/2] PCI: j721e: Fix PERST# polarity Francesco Dolcini
2024-07-06 6:44 ` [PATCH v1 0/2] PCI: ti: k3: Fix TI J721E " Siddharth Vadapalli
2024-07-11 14:21 ` Niklas Cassel
2024-07-11 15:25 ` Francesco Dolcini
2024-07-12 10:34 ` Niklas Cassel
2024-07-12 10:40 ` Niklas Cassel
2024-08-06 14:35 ` Francesco Dolcini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240806143519.GA176293@francesco-nb \
--to=francesco@dolcini.it \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=francesco.dolcini@toradex.com \
--cc=kristo@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=nm@ti.com \
--cc=robh@kernel.org \
--cc=s-vadapalli@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).