From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44561C52D70 for ; Tue, 6 Aug 2024 15:40:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:CC:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=493QlqllTK4asevKGpWT91qeIbSWuou5nw9FbudkgSM=; b=bv5Mzt+IFCmJykdhmSEwZsoLcc n3aWD/XfCDn4FqsWJJuvaHYlRMoMjmooSpQEADchdiMatDuxIGJKetW4lG3m4zQrCf4hxXUtJDYov OZZfLrwd/fTslcEIgGWgg5TX4J4uGejSLgPBX/2veRJvkxF1xPTVPHUKb6YD9JRGXm6qEh2P8mNLh 4/ckEK+qjl0CEjrto5jzbwjHo0eHB4/uWiQ3NZNWxNA3Q88xrRwEHkEPSfDEQHW9ATpjZLFC04Yc2 tRa//Qj0V4Us7j6PYw+XJIUVD7Frxj424ZKMU2O+csbx/DIX0JlDHMr2DMHOOkFCuF773wfpiUQQ7 nZwkb2aA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbMHx-00000002Cs0-0H8a; Tue, 06 Aug 2024 15:39:53 +0000 Received: from lelv0142.ext.ti.com ([198.47.23.249]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbMHP-00000002Cnt-1E9a for linux-arm-kernel@lists.infradead.org; Tue, 06 Aug 2024 15:39:20 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 476FdD71097666; Tue, 6 Aug 2024 10:39:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1722958753; bh=493QlqllTK4asevKGpWT91qeIbSWuou5nw9FbudkgSM=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=lIa5yPq7+Ec9r6K0UYBbNfsHlRgoCL4+YYOrrvMgsb+d67NZL0pgZUodbwM44GQWu qWuHKOULFMF1DS+UI5kc1GF9svXZE2QCeNFCSaODDxr0Zfg2MEKMRZpRBjCrcoC/Fh AFhMfOlqgCznbSk4jPCuo1OumRpklvcAGPVx52hA= Received: from DFLE105.ent.ti.com (dfle105.ent.ti.com [10.64.6.26]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 476FdDS7046593 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 6 Aug 2024 10:39:13 -0500 Received: from DFLE110.ent.ti.com (10.64.6.31) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Tue, 6 Aug 2024 10:39:13 -0500 Received: from lelvsmtp6.itg.ti.com (10.180.75.249) by DFLE110.ent.ti.com (10.64.6.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Tue, 6 Aug 2024 10:39:12 -0500 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232]) by lelvsmtp6.itg.ti.com (8.15.2/8.15.2) with ESMTP id 476FdCqt035437; Tue, 6 Aug 2024 10:39:12 -0500 Date: Tue, 6 Aug 2024 10:39:12 -0500 From: Nishanth Menon To: Markus Schneider-Pargmann CC: Tero Kristo , Santosh Shilimkar , Vibhore Vardhan , Kevin Hilman , "Dhruva Gole" , , , Dave Gerlach , Georgi Vlaev , Akashdeep Kaur Subject: Re: [PATCH v8 1/3] firmware: ti_sci: Introduce Power Management Ops Message-ID: <20240806153912.sqsirnic5eb7witi@unsealed> References: <20240801195422.2296347-1-msp@baylibre.com> <20240801195422.2296347-2-msp@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240801195422.2296347-2-msp@baylibre.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240806_083919_394218_7A27A512 X-CRM114-Status: UNSURE ( 7.58 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21:54-20240801, Markus Schneider-Pargmann wrote: > From: Dave Gerlach [...] > + pmops->lpm_wake_reason = ti_sci_msg_cmd_lpm_wake_reason; did you miss populating the rest of the pm ops? See https://lore.kernel.org/all/202408031302.28NpPykP-lkp@intel.com/ It might be better to introduce the APIs one at a time? -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D