From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1065C52D70 for ; Tue, 6 Aug 2024 15:42:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:CC:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=x8SgTFtSMWNW8cge/SCwclavovE9l5hGsdVvQ3ubDuI=; b=sEh/zV5C7Lcbup1/9cO5wrmVUm DhLkIuc+N7nApOkJFYvZvGEa83giLL6hEIVD65E6o2jWtL9uAVVR5jipEMXm2xfANZ3L42a2abN3y zmp/Y6+on96GjQ1vEPDB3hVfzVZ7YaQiwodOSG/kVNxwyharmk/7Xk7qZpuJ0mSQMRGB910sOymaU EqilqHNaN2W7fzyFaxCgJt60mMBGVp/HnR+OZ5+1+MNZQSNaUO35k7v6cmu7v5/9VHPLjo3FRRZRo E1Dadd1B+oivWPkWaFmNCqmqeX/7+Ngsrg8L2hr7dhGuPQeKVTHT8NXx+C1mc3crGqxVNudnJyC60 cnjBgyaw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbMKc-00000002DX4-2K6Y; Tue, 06 Aug 2024 15:42:38 +0000 Received: from lelv0142.ext.ti.com ([198.47.23.249]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbMK5-00000002DS1-2fa1 for linux-arm-kernel@lists.infradead.org; Tue, 06 Aug 2024 15:42:06 +0000 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 476Fg1N9098251; Tue, 6 Aug 2024 10:42:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1722958921; bh=x8SgTFtSMWNW8cge/SCwclavovE9l5hGsdVvQ3ubDuI=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=P3rO48UPg/mfT4NbEOuoYoeSyovDa4N2KarCErIbEEEiQQzE+a4PfjkKuJxEPZ9Ij aS8FZ6jaBdMhXRL6ClEZyA7t8io4z5vSHh3soxoFZM9m4+5HUU392gOeJ5se4NbL1n Dy0An84yLWI7fo0oxOmQW96FE/wclIgG5rLgM6iI= Received: from DLEE101.ent.ti.com (dlee101.ent.ti.com [157.170.170.31]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 476Fg1oa026047 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 6 Aug 2024 10:42:01 -0500 Received: from DLEE114.ent.ti.com (157.170.170.25) by DLEE101.ent.ti.com (157.170.170.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Tue, 6 Aug 2024 10:42:01 -0500 Received: from lelvsmtp5.itg.ti.com (10.180.75.250) by DLEE114.ent.ti.com (157.170.170.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Tue, 6 Aug 2024 10:42:01 -0500 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232]) by lelvsmtp5.itg.ti.com (8.15.2/8.15.2) with ESMTP id 476Fg1gw041653; Tue, 6 Aug 2024 10:42:01 -0500 Date: Tue, 6 Aug 2024 10:42:01 -0500 From: Nishanth Menon To: Markus Schneider-Pargmann CC: Tero Kristo , Santosh Shilimkar , Vibhore Vardhan , Kevin Hilman , "Dhruva Gole" , , , Georgi Vlaev Subject: Re: [PATCH v8 2/3] firmware: ti_sci: Add support for querying the firmware caps Message-ID: <20240806154201.tfqq27csd6zvtbrw@browsing> References: <20240801195422.2296347-1-msp@baylibre.com> <20240801195422.2296347-3-msp@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240801195422.2296347-3-msp@baylibre.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240806_084205_749704_6841551F X-CRM114-Status: GOOD ( 11.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21:54-20240801, Markus Schneider-Pargmann wrote: [...] > static int ti_sci_cmd_core_reboot(const struct ti_sci_handle *handle) > { > struct ti_sci_info *info; > @@ -3113,6 +3172,12 @@ static void ti_sci_setup_ops(struct ti_sci_info *info) > > pmops->lpm_wake_reason = ti_sci_msg_cmd_lpm_wake_reason; > > + if (info->fw_caps & MSG_FLAG_CAPS_LPM_DM_MANAGED) { > + pr_debug("detected DM managed LPM in fw_caps\n"); > + ops->pm_ops.set_device_constraint = ti_sci_cmd_set_device_constraint; > + ops->pm_ops.set_latency_constraint = ti_sci_cmd_set_latency_constraint; pmops-> ? Also lpm_wake_reason makes sense only if the flag is set, so this should probably be the first patch in your series? > + } Side-note: please drop bouncing emails from your patch CC list. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D