From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4B047C52D71 for ; Tue, 6 Aug 2024 17:30:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BrUREW62SE224x2dG96ldKYfYzUSbsOTl6Pu3q5x9lk=; b=j3Gga4lSCpJL4Zncx0KX7pYPFY g5yYHqNRPQXs4z+W0bvDM6XfYzmgNQQtqoF3dPFdVv8gS5JDI6ztYzmHQqoFTR3fCOENVW4WOHI37 ltwuPucnUA27lKqwOTC6Q7zKBFldR8uZyLwf3HhYET5YzV5Pixw4c8+U4i3AfyzzxwC8I0/c9FFGG 4qArWDh+osIzlJ/7hpprZnljjPUStI7a1poxxkQ6o+ob0tHD+UDsBv3yXW+B1BZGRjdxglDWJDoeU SsgWQ85mf/ubAGTg0ZreV8MuwmCSmkfljDFLPBAJ6aPGYppROu/+YJp/Jqu6OGZCXAPVwxE2hRuEU +xHRgjNA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbO0O-00000002VNl-1dO3; Tue, 06 Aug 2024 17:29:52 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbNzr-00000002VFT-30MU for linux-arm-kernel@lists.infradead.org; Tue, 06 Aug 2024 17:29:21 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id B50216108C; Tue, 6 Aug 2024 17:29:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 34B64C32786; Tue, 6 Aug 2024 17:29:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722965358; bh=DofvQUUcQFIETiczpIF5gJHLeGYi8mKOd63Og3SACc8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iRDu42hksbv/tG52EbZeMZeva3thQioloHG/Z1Qw7xVZQAhDp5Gs804PeAQMBdnix dCfqnFN3B+/GtHuSKoSYLT/8dG39eSny57VmPTy9yX7MbLs+ZTGUGvlZ/nwbE564hF qbQtNaKe48/NFBNt9sr36hoUb0Obp/pp1RIf8WzwJwOD5cgoNFXsArMLlvQae7RPYj YEnIHr9wZkunFUSEEJ27eNd7b1X86fDetDMG3i25ilou8Ci6bcKzoIOD8Melhs4aTC 3XLKpPcauLjyp3+o6lczmtb7VzuBg1SbQ0eZz6sgJEQqr0+qJb9riNlSRvHZD7XdLc O2XA1cXEI3ZWQ== Date: Tue, 6 Aug 2024 11:29:17 -0600 From: Rob Herring To: Andrew Jeffery Cc: Thomas Gleixner , Krzysztof Kozlowski , Conor Dooley , Joel Stanley , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org Subject: Re: [PATCH 2/2] dt-bindings: misc: aspeed,ast2400-cvic: Convert to DT schema Message-ID: <20240806172917.GA1836473-robh@kernel.org> References: <20240802-dt-warnings-irq-aspeed-dt-schema-v1-0-8cd4266d2094@codeconstruct.com.au> <20240802-dt-warnings-irq-aspeed-dt-schema-v1-2-8cd4266d2094@codeconstruct.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240802-dt-warnings-irq-aspeed-dt-schema-v1-2-8cd4266d2094@codeconstruct.com.au> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240806_102919_864198_4A891B78 X-CRM114-Status: GOOD ( 23.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 02, 2024 at 03:06:31PM +0930, Andrew Jeffery wrote: > Address warnings such as: > > arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-galaxy100.dtb: interrupt-controller@1e6c0080: 'valid-sources' does not match any of the regexes: 'pinctrl-[0-9]+' > > and > > arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-galaxy100.dtb: /ahb/copro-interrupt-controller@1e6c2000: failed to match any schema with compatible: ['aspeed,ast2400-cvic', 'aspeed-cvic'] > > Note that the conversion to DT schema causes some further warnings to > be emitted, because the Aspeed devicetrees are not in great shape. These > new warnings are resolved in a separate series: > > https://lore.kernel.org/lkml/20240802-dt-warnings-bmc-dts-cleanups-v1-0-1cb1378e5fcd@codeconstruct.com.au/ > > Signed-off-by: Andrew Jeffery > --- > .../bindings/misc/aspeed,ast2400-cvic.yaml | 60 ++++++++++++++++++++++ > .../devicetree/bindings/misc/aspeed,cvic.txt | 35 ------------- > 2 files changed, 60 insertions(+), 35 deletions(-) > > diff --git a/Documentation/devicetree/bindings/misc/aspeed,ast2400-cvic.yaml b/Documentation/devicetree/bindings/misc/aspeed,ast2400-cvic.yaml > new file mode 100644 > index 000000000000..3c85b4924c05 > --- /dev/null > +++ b/Documentation/devicetree/bindings/misc/aspeed,ast2400-cvic.yaml > @@ -0,0 +1,60 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/misc/aspeed,ast2400-cvic.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Aspeed Coprocessor Vectored Interrupt Controller > + > +maintainers: > + - Andrew Jeffery > + > +description: > + The Aspeed AST2400 and AST2500 SoCs have a controller that provides interrupts > + to the ColdFire coprocessor. It's not a normal interrupt controller and it > + would be rather inconvenient to create an interrupt tree for it, as it > + somewhat shares some of the same sources as the main ARM interrupt controller > + but with different numbers. > + > + The AST2500 also supports a software generated interrupt. > + > +properties: > + compatible: > + items: > + - enum: > + - aspeed,ast2400-cvic > + - aspeed,ast2500-cvic > + - const: aspeed,cvic > + > + reg: > + maxItems: 1 > + > + valid-sources: > + $ref: /schemas/types.yaml#/definitions/uint32-array > + description: > + One cell, bitmap of support sources for the implementation. > + > + copro-sw-interrupts: > + $ref: /schemas/types.yaml#/definitions/uint32-array > + description: > + A list of interrupt numbers that can be used as software interrupts from > + the ARM to the coprocessor. > + > +required: > + - compatible > + - reg > + - valid-sources > + > +allOf: > + - $ref: /schemas/interrupt-controller.yaml# Doesn't really look like this schema applies to this binding. Drop the ref. > + > +additionalProperties: false > + > +examples: > + - | > + interrupt-controller@1e6c2000 { > + compatible = "aspeed,ast2500-cvic", "aspeed,cvic"; > + reg = <0x1e6c2000 0x80>; > + valid-sources = <0xffffffff>; > + copro-sw-interrupts = <1>; > + };