From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 63A30C52D6F for ; Wed, 7 Aug 2024 02:39:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mtp3NbD/YqRvTh1X6hVLatX9/l1nLSm5GP8YfNboPug=; b=J3M04+JeEbCPREm4bv3bGcmNpM hr9XCZ0Vr1df57cWXVmlv9oYoIqF5AYc9ITULtuUM46TdgD3Ix0oYUuWkgskOASzSRWbOAeZ4IhQc OwU9NPztQkfGgRZAOlj3i3G8LSv6i77Ngobmgyye5o0yYL97HTMHjtrRdNO7lrtujbuP5riBiTqrS vMzAazL64fYB7tzukrwGaNbiao6rWyDjW+yeAx/Pulw/wl/72bc5TL9LMSXTjRT4ZgjtFMSY+FeMo oDQDFWyy6RSjzKZrTXpCyPQnWXP4N5bOV+5Z6S2gGCSTN/1sVQDKHZmJU9cys1VQ02rqVM21Puxw0 tgHGa5nA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbWZx-00000003dsA-0EJl; Wed, 07 Aug 2024 02:39:09 +0000 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbWZO-00000003djr-1xrJ for linux-arm-kernel@lists.infradead.org; Wed, 07 Aug 2024 02:38:36 +0000 Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-1fc66fc35f2so3440915ad.0 for ; Tue, 06 Aug 2024 19:38:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1722998313; x=1723603113; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=mtp3NbD/YqRvTh1X6hVLatX9/l1nLSm5GP8YfNboPug=; b=l9H8+TVZAByix6zLYt4KgLjedB4LwNU7ygWSFObDxoZcRP6Im/Z7rmpA08JXZp6NZV oYK/VjghPuiyV3U7PO5Ck6LwczEBiVeIJcTA6LLIobESgHQfYui98NcVXjq/o2EaRPgn c805GpWNxXNtRVbnXr6l6OCR1zWUPAAMdiYqHS6J8vsHP6QOSxGR/zCuZ0Cs4KF1ldGw QUP8o8HdLmjtZoS5HCyOdgm6hSM6JILdDzxU5KVjA5IW2vX7zm+VX7VJzB+W4A/+zQ1K XexRiGV8jSyqzMs+8aZ7K8VkPVzOe/l4sXJyeitR357hlUFgFcInv3bFV4PRR2IbH3ek PwTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722998313; x=1723603113; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mtp3NbD/YqRvTh1X6hVLatX9/l1nLSm5GP8YfNboPug=; b=LsSIbd05f9ou5kv4DSuGb5Vao45kUNXbe39PZ8BoUXWPWrgWFwgcmlmtGLInQOTkck KY34p0ZP0tuxvR8s4ldc3jDiEL8yTKtmk24V7Q3VlqYQknC2yIrB+9KN0el9sCjZg3US 9PmSUu7a12SZcjpG8eFRKhLtYgrMJury72BL1D1zq+IS1VGYZRtZ0Mysxjg6dfuQV5uv l6DLOpv47kL8YTlAgyNZkdQCIyH14KcrTKKOVI+X5jjMpGHrQ6/Q5ZEzFR7Mix3szuox wZr2UiFICQhUSV8oR/pcTieByNJ48mMYZLbII5xL+cXrvM7LGsRzEjcty9iGVkj+sk7k tmkw== X-Forwarded-Encrypted: i=1; AJvYcCXy+g+JwJCMBglWSFtX/Tq/+m37x/7RB036vqQaMWUR8sXKLbkjSvUSt8Dkt3dIWN17Htru+cpg38x8xiaGCuzzianSkWDUgee43qn7T1LAW47hU88= X-Gm-Message-State: AOJu0Yyg0Fiba6D5AWkgQtmqig2OXcdhBQkLXDN6mckzaQb8nJHpZKNu hq2i15AMfXTWe3OEKf1E2Ld4Pcp5/Phv6OnTgXqzGfuqBmBy+Nzx7NhLDGnI4A== X-Google-Smtp-Source: AGHT+IEd1qQTRt9UOIknRR+fvi02G2idHTW2IbPzXHNTiCav0Sk5mM6ZKvmCfShwLcwTUuICmygZSg== X-Received: by 2002:a17:902:da8d:b0:1fc:5b81:729f with SMTP id d9443c01a7336-200855706cemr10944935ad.32.1722998313089; Tue, 06 Aug 2024 19:38:33 -0700 (PDT) Received: from thinkpad ([120.60.72.69]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ff58f29d37sm94937275ad.48.2024.08.06.19.38.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Aug 2024 19:38:32 -0700 (PDT) Date: Wed, 7 Aug 2024 08:08:14 +0530 From: Manivannan Sadhasivam To: Frank Li Cc: Richard Zhu , Lucas Stach , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Philipp Zabel , Liam Girdwood , Mark Brown , Krzysztof Kozlowski , Conor Dooley , linux-pci@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, devicetree@vger.kernel.org, Jason Liu , Conor Dooley Subject: Re: [PATCH v8 00/11] PCI: imx6: Fix\rename\clean up and add lut information for imx95 Message-ID: <20240807023814.GD3412@thinkpad> References: <20240729-pci2_upstream-v8-0-b68ee5ef2b4d@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240806_193834_540873_745486A2 X-CRM114-Status: GOOD ( 32.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 06, 2024 at 04:33:38PM -0400, Frank Li wrote: > On Mon, Jul 29, 2024 at 04:18:07PM -0400, Frank Li wrote: > > Fixed 8mp EP mode problem. > > > > imx6 actaully for all imx chips (imx6*, imx7*, imx8*, imx9*). To avoid > > confuse, rename all imx6_* to imx_*, IMX6_* to IMX_*. pci-imx6.c to > > pci-imx.c to avoid confuse. > > > > Using callback to reduce switch case for core reset and refclk. > > > > Base on linux 6.11-rc1 > > > > To: Richard Zhu > > To: Lucas Stach > > To: Lorenzo Pieralisi > > To: Krzysztof Wilczyński > > To: Rob Herring > > To: Bjorn Helgaas > > To: Shawn Guo > > To: Sascha Hauer > > To: Pengutronix Kernel Team > > To: Fabio Estevam > > To: NXP Linux Team > > To: Philipp Zabel > > To: Liam Girdwood > > To: Mark Brown > > To: Manivannan Sadhasivam > > To: Krzysztof Kozlowski > > To: Conor Dooley > > Cc: linux-pci@vger.kernel.org > > Cc: imx@lists.linux.dev > > Cc: linux-arm-kernel@lists.infradead.org > > Cc: linux-kernel@vger.kernel.org > > Cc: bpf@vger.kernel.org > > Cc: devicetree@vger.kernel.org > > Signed-off-by: Frank Li > > > > Changes in v8: > > - Rebase to 6.11-rc1 > > - Add Mani's review tags for 2, 6, 8, 9, 10 > > - Add fix patch PCI: imx6: Fix missing call to phy_power_off() in error handling > > - keep enable_ref_clk(), I will add more code to make disabe/enable symtric > > - Link to v7: https://lore.kernel.org/r/20240708-pci2_upstream-v7-0-ac00b8174f89@nxp.com > > > Manivannan: > > Do you have chance to review these again? Only few patch without > your review tag. > Done, series LGTM. - Mani > Frank > > > > > Changes in v7: > > - rework commit message for PCI: imx6: Fix i.MX8MP PCIe EP's occasional failure to trigger MSI > > - Add Mani's review tags for patch 1, 5 > > - Fix errata number in commit message for patch 6 > > - replace set_ref_clk with enable_ref_clk in patch 4 > > - using regmap_set(clear)_bits in patch 4 > > - Use exactly the same logic with original code at patch 4 > > - Add errata doc link for patch 6 > > - Fix miss "." at comment form patch 6. > > - order include header for patch 9 > > - use cap register to set_speed for patch 9 > > - use PCIe in error msg for patch 9 > > - Remove reduntant ':' at patch 9' subject. > > - Change range to ranges for patch 10. > > - Change error code to -ENODEV for patch 10. > > - Link to v6: https://lore.kernel.org/r/20240617-pci2_upstream-v6-0-e0821238f997@nxp.com > > > > Changes in v6: > > - Base on Linux 6.10-rc1 by Bjorn's required. > > - Remove imx95 LUT patch because it need more time to work out the > > solution. This patch add 8qxp and 8qm and support and some bug fixes. > > - Link to v5: https://lore.kernel.org/r/20240528-pci2_upstream-v5-0-750aa7edb8e2@nxp.com > > > > Changes in v5: > > - Rebase to linux-pci next. fix conflict with gpiod change > > - Add rob and cornor's review tag > > - Link to v4: https://lore.kernel.org/r/20240507-pci2_upstream-v4-0-e8c80d874057@nxp.com > > > > Changes in v4: > > - Improve comment message for patch 1 and 2. > > - Rework commit message for patch 3 and add mani's review tag > > - Remove file rename patch and update maintainer patch > > - [PATCH v3 06/11] PCI: imx: Simplify switch-case logic by involve set_ref_clk callback > > remove extra space. > > keep original comments format (wrap at 80 column width) > > update error message "'Failed to enable PCIe REFCLK'" > > - PATCH v3 07/11] PCI: imx: Simplify switch-case logic by involve core_reset callback > > keep exact the logic as original code > > - Add patch to update comment about workaround ERR010728 > > - Add patch about help function imx_pcie_match_device() > > - Using bus device notify to update LUT information for imx95 to avoid > > parse iommu-map and msi-map in driver code. Bus notify will better and > > only update lut when device added. > > - split patch call PHY interface function. > > - Improve commit message for imx8q. remove local-address dts proptery. and > > use standard "range" to convert cpu address to bus address. > > - Check entry in cpu_fix function is too late. Check it at probe > > - Link to v3: https://lore.kernel.org/r/20240402-pci2_upstream-v3-0-803414bdb430@nxp.com > > > > Changes in v3: > > - Add an EP fixed patch > > PCI: imx6: Fix PCIe link down when i.MX8MM and i.MX8MP PCIe is EP mode > > PCI: imx6: Fix i.MX8MP PCIe EP can not trigger MSI > > - Add 8qxp rc support > > dt-bing yaml pass binding check > > make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8 dt_binding_check DT_SCHEMA_FILES=fsl,imx6q-pcie.yaml > > LINT Documentation/devicetree/bindings > > DTEX Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.example.dts > > CHKDT Documentation/devicetree/bindings/processed-schema.json > > SCHEMA Documentation/devicetree/bindings/processed-schema.json > > DTC_CHK Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.example.dtb > > > > - Link to v2: https://lore.kernel.org/r/20240304-pci2_upstream-v2-0-ad07c5eb6d67@nxp.com > > > > Changes in v2: > > - remove file to 'pcie-imx.c' > > - keep CONFIG unchange. > > - Link to v1: https://lore.kernel.org/r/20240227-pci2_upstream-v1-0-b952f8333606@nxp.com > > > > --- > > Frank Li (7): > > PCI: imx6: Fix missing call to phy_power_off() in error handling > > PCI: imx6: Rename imx6_* with imx_* > > PCI: imx6: Introduce SoC specific callbacks for controlling REFCLK > > PCI: imx6: Simplify switch-case logic by involve core_reset callback > > PCI: imx6: Improve comment for workaround ERR010728 > > PCI: imx6: Consolidate redundant if-checks > > PCI: imx6: Call common PHY API to set mode, speed, and submode > > > > Richard Zhu (4): > > PCI: imx6: Fix establish link failure in EP mode for iMX8MM and iMX8MP > > PCI: imx6: Fix i.MX8MP PCIe EP's occasional failure to trigger MSI > > dt-bindings: imx6q-pcie: Add i.MX8Q pcie compatible string > > PCI: imx6: Add i.MX8Q PCIe root complex (RC) support > > > > .../devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 16 + > > drivers/pci/controller/dwc/pci-imx6.c | 989 +++++++++++---------- > > 2 files changed, 542 insertions(+), 463 deletions(-) > > --- > > base-commit: c428091cdcf7f368ad9884f8caa68b79cd6c333a > > change-id: 20240227-pci2_upstream-0cdd19a15163 > > > > Best regards, > > --- > > Frank Li > > -- மணிவண்ணன் சதாசிவம்