From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3BA09C49EA1 for ; Wed, 7 Aug 2024 03:04:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zuSFHpUoL2YYlkuYSjJEF2bIpqbWqy7BnB6SEFzqJNw=; b=EvERxhSZRd9KHujNWknVBM47XD dq2vifupgXbLOwwsZT1KnwTCYyn7bRxCxSyKCtR3c6wTWS12a6QBGD4R6ifuxIM84PWbT8j6k9O3w sc7dKtqjJ5wfeEX6LFED9q9pTTVFWItHjEVS2vPVrAD7QGnFyWUnmPrzE57sxGE6tkKVHc1a/Ns2M yPza81xGIoxn6zgsiyEKnJrMTtzWNgFnVjqeml1Pz/tkN9y7uKEkjSNAEjlzMU7RmBw0Oe9cv/fdy 6mBp3RR4o5EW2mcA9y8/XbYzkFBEW7sMBv367uhTXmtgGWCnnugI5ks8RNmpV2zuBjH9Q8UCF99Dw B3+NdU7A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbWyQ-00000003g2t-3C6o; Wed, 07 Aug 2024 03:04:26 +0000 Received: from mail-pg1-x52e.google.com ([2607:f8b0:4864:20::52e]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbWxt-00000003fyX-0FXD for linux-arm-kernel@lists.infradead.org; Wed, 07 Aug 2024 03:03:54 +0000 Received: by mail-pg1-x52e.google.com with SMTP id 41be03b00d2f7-7a92098ec97so1098989a12.2 for ; Tue, 06 Aug 2024 20:03:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1722999832; x=1723604632; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=zuSFHpUoL2YYlkuYSjJEF2bIpqbWqy7BnB6SEFzqJNw=; b=AqXEtzLKuWWgteGDv2lzost0la5Id9s6eADyBDhYMCGj1rG4O4j5ysVv+rGAcAGJvT ErBqfPoNyc5ZANBYFWCH3YaWs7gKsLaG8faQMkhE9CQIOfQgToLLxe4fV6RKhN2WsF0J 7gCWDelzb1OSIVa2/uRBaGwwn9AQ8NCUKrVLfiD/dmXkgMd5nyCLsQSVga76gpJF0Yq1 6TDqa4cuhw4VLY3RkA2R4UnbhX7HPJXjBgwfl4/IuJ89G5hSrpIuvP6O4xQ45X/Ls/I+ O+U+n/LbEUxOTgS8HTnTQH5I9BHHKexDwZD1rewlWikmtlFgsUGmeVpq65LyZYTOaknN HkFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722999832; x=1723604632; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zuSFHpUoL2YYlkuYSjJEF2bIpqbWqy7BnB6SEFzqJNw=; b=YeFxRiyivaWHKGAEcgvthhsl8UNF8oSAEAGG7c92It5W7aakxeFTDNs7IkCSL7/vt0 m0XtC8NQtNK64mbmubjr2xy69rJGbVNemVsriSqXrUavXtnJsEdVQCEW5hbv8ZPYGFcZ IQfnuX+IcrmQrnKPCH7lxdvkBPSOQ1DBz4XexjLESBJbQL4yyfPNo6VoAY0g0Bc14Tt0 8sfIgNdpT1d+4QoRk8We8z7TCmEDpK4UB8m+ERLBnQTRmEtoFjU8BGYEHBMosN8AcqQV cM4jYRJSyuJdijo7oOdfc9SFpBYqYvDhEM+9287d3lKX8NVfVjaH4ul0Jaucj2IQZ7SI eVrg== X-Forwarded-Encrypted: i=1; AJvYcCX4iymf0nTZJmSzw8tIofzx9XwRcqFO2Nw/e5GVMZmpVFzKLbbjo+sQsTNw+ySNy1sz1CSaSoO+XVAJyc5oHZEQD9A9GJl0IvL5aOXuI9rSy7mUav4= X-Gm-Message-State: AOJu0Yw+ngLUoClqq6dYVmYXlsVmTlZImTSMspdBNdom7SrJD3VQVRpY Mgp7A7LjrECNg8CA6XllLnsBvlpBD0k7LZMGJp3slRRkSuQb/tvryqGOKF2BBNULgG3ZhNIBbUc = X-Google-Smtp-Source: AGHT+IEz28V+pQaJpXndCtgDVpWOs2o4+wkjG3HQ2R3vI8fbqY0Bv2xxm5JeBQo3gbEpFnyg4+fZWw== X-Received: by 2002:a05:6a21:a4c1:b0:1c4:dae8:c72f with SMTP id adf61e73a8af0-1c699559d86mr17649446637.19.1722999831794; Tue, 06 Aug 2024 20:03:51 -0700 (PDT) Received: from thinkpad ([120.60.72.69]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7106ece4967sm7533616b3a.138.2024.08.06.20.03.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Aug 2024 20:03:51 -0700 (PDT) Date: Wed, 7 Aug 2024 08:33:42 +0530 From: Manivannan Sadhasivam To: Jim Quinlan Cc: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Stanimir Varbanov , Krzysztof Kozlowski , bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com, Florian Fainelli , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Philipp Zabel , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list Subject: Re: [PATCH v5 05/12] PCI: brcmstb: Use swinit reset if available Message-ID: <20240807030342.GH3412@thinkpad> References: <20240731222831.14895-1-james.quinlan@broadcom.com> <20240731222831.14895-6-james.quinlan@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240731222831.14895-6-james.quinlan@broadcom.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240806_200353_127820_0E48D643 X-CRM114-Status: GOOD ( 23.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 31, 2024 at 06:28:19PM -0400, Jim Quinlan wrote: > The 7712 SOC adds a software init reset device for the PCIe HW. > If found in the DT node, use it. > > Signed-off-by: Jim Quinlan > --- > drivers/pci/controller/pcie-brcmstb.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c > index 4d68fe318178..948fd4d176bc 100644 > --- a/drivers/pci/controller/pcie-brcmstb.c > +++ b/drivers/pci/controller/pcie-brcmstb.c > @@ -266,6 +266,7 @@ struct brcm_pcie { > struct reset_control *rescal; > struct reset_control *perst_reset; > struct reset_control *bridge_reset; > + struct reset_control *swinit_reset; > int num_memc; > u64 memc_size[PCIE_BRCM_MAX_MEMC]; > u32 hw_rev; > @@ -1633,12 +1634,30 @@ static int brcm_pcie_probe(struct platform_device *pdev) > if (IS_ERR(pcie->bridge_reset)) > return PTR_ERR(pcie->bridge_reset); > > + pcie->swinit_reset = devm_reset_control_get_optional_exclusive(&pdev->dev, "swinit"); > + if (IS_ERR(pcie->swinit_reset)) > + return PTR_ERR(pcie->swinit_reset); > + > ret = clk_prepare_enable(pcie->clk); > if (ret) > return dev_err_probe(&pdev->dev, ret, "could not enable clock\n"); > > pcie->bridge_sw_init_set(pcie, 0); > > + if (pcie->swinit_reset) { You already have a callback called 'bridge_sw_init_set', so this 'swinit_reset' is different from 'bridge_sw_init'? If so, does it make sense to move this into the callback itself to have all reset sequence in one place? - Mani > + ret = reset_control_assert(pcie->swinit_reset); > + if (dev_err_probe(&pdev->dev, ret, "could not assert reset 'swinit'\n")) > + goto clk_disable_unprepare; > + > + /* HW team recommends 1us for proper sync and propagation of reset */ > + udelay(1); > + > + ret = reset_control_deassert(pcie->swinit_reset); > + if (dev_err_probe(&pdev->dev, ret, > + "could not de-assert reset 'swinit' after asserting\n")) > + goto clk_disable_unprepare; > + } > + > ret = reset_control_reset(pcie->rescal); > if (dev_err_probe(&pdev->dev, ret, "failed to deassert 'rescal'\n")) > goto clk_disable_unprepare; > -- > 2.17.1 > -- மணிவண்ணன் சதாசிவம்