From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C76F8C52D6F for ; Wed, 7 Aug 2024 11:48:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:CC:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KDuDkR3cT3auCGtVG7eO62xWbKsmQBAUL0KcQ/6RCEg=; b=bO79MUp6RcxMJzmGl51sl6UDSv 3A8bffoKUK3ZWr26CDjNQCQnf/v5E8l00PDxQ8CRhs6l9+St6/yGN2cvG35izxEoH1B3/V/hvFmR2 IQ1GmEOsa2uWYnHplL3IHhnBTya49A8QEb36QiS+eFL8jD/MAk95EPejbtEhWl3G3xlRIT/zgWrop HdI6uGcNs3UYY3dEY/hlswGGKiZpk7+dBTtKFDY+YIwJ2BXGSIQoakruBa2hMA3fPR+xEShqWlZze 1j8eDzcR/6aSM6druwdMj7m4l4mmDPjd9HerERjU7TcQX2hnX1LZotqFBrAwqLiPILHkHXHEiGwBj HTKFhN/A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbf9T-00000004u7y-0ny3; Wed, 07 Aug 2024 11:48:23 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbf8u-00000004u3j-3XVR for linux-arm-kernel@lists.infradead.org; Wed, 07 Aug 2024 11:47:50 +0000 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 477BldaN070553; Wed, 7 Aug 2024 06:47:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1723031259; bh=KDuDkR3cT3auCGtVG7eO62xWbKsmQBAUL0KcQ/6RCEg=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=GVI+K5jT4o+lzoMfz3SHmajJ4iRTzJXiDOM0ZMeKZ5iIwMe8a7inSLEptwWCq59OJ rJtuozJLYMMvATQo4d5nc/vNKfmh7XR5k37kxSJmrnjIbnMqEaMgbNbX1Q4afiKW8B 0VBdVJd0z3S8GJM3JpJzp9jO5J0IrROGCXwuEeOc= Received: from DLEE105.ent.ti.com (dlee105.ent.ti.com [157.170.170.35]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 477Bldv8058163 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 7 Aug 2024 06:47:39 -0500 Received: from DLEE107.ent.ti.com (157.170.170.37) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Wed, 7 Aug 2024 06:47:38 -0500 Received: from lelvsmtp5.itg.ti.com (10.180.75.250) by DLEE107.ent.ti.com (157.170.170.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Wed, 7 Aug 2024 06:47:38 -0500 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232]) by lelvsmtp5.itg.ti.com (8.15.2/8.15.2) with ESMTP id 477Blccd095790; Wed, 7 Aug 2024 06:47:38 -0500 Date: Wed, 7 Aug 2024 06:47:38 -0500 From: Nishanth Menon To: Manorit Chawdhry CC: Andrew Davis , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , , , , Neha Malcom Francis , Aniket Limaye , Udit Kumar , Beleswar Padhi , Siddharth Vadapalli Subject: Re: [PATCH v3 1/5] arm64: dts: ti: k3-j721s2*: Add bootph-* properties Message-ID: <20240807114738.tu3cmiu3mmk65g4v@phoney> References: <20240730-b4-upstream-bootph-all-v3-0-9bc2eccb6952@ti.com> <20240730-b4-upstream-bootph-all-v3-1-9bc2eccb6952@ti.com> <20240806150700.uw4xdanjr4ypdvm3@rasping> <20240807052628.jclbmw4zs72jm6km@uda0497581> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240807052628.jclbmw4zs72jm6km@uda0497581> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240807_044748_995922_669105B3 X-CRM114-Status: GOOD ( 17.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10:56-20240807, Manorit Chawdhry wrote: > Hi Nishanth, > > On 10:07-20240806, Nishanth Menon wrote: > > On 09:43-20240806, Andrew Davis wrote: > > > On 7/30/24 4:53 AM, Manorit Chawdhry wrote: > > > > Adds bootph-* properties to the leaf nodes to enable U-boot to > > > > utilise them. > > > > > > U-Boot? Let's try to pretend like this is a generic property and > > > just say "bootloader" :) > > > > @@ -445,6 +446,7 @@ flash@0 { > > > > cdns,tchsh-ns = <60>; > > > > cdns,tslch-ns = <60>; > > > > cdns,read-delay = <4>; > > > > + bootph-all; > > > > Here and elsewhere, follow: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/dts-coding-style.rst#n117 > > Could you tell me what are you seeing wrong? The dts-coding-style that > you shared doesn't tell a specific location for bootph-* properties so > using the generic reasoning. it falls under standard properties > > "1. Most important properties start the node: compatible then bus addressing to > match unit address." > > This is the least important property considering Linux and hence the > reasoning was that it should come in the last. Also, j722s and am62p > follow the same convention so it was taken from there only. follow the order - bootph-all is before the vendor properties -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D