From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37E89C3DA7F for ; Wed, 7 Aug 2024 13:07:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:CC:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sse7kT6azNByYduNdrThku4TmwDTwyJbiElkKLi6dtw=; b=akL+gPxnluhHIyC74I+B2gDClo y9ScJGsOmD0rUSQDT2Ulget6K+M1FXs+QrQlIKwVeQCqTrZmyM+wn/98EqYYITzpQxfJjDEWbXizm NMsKCW2kfeA9W0+6J31Li9FdSjQBRZiDoYGghxBAxkRbXbrLQGoFAfkXToc8C0fIQxiHxcxcdjVpT ZqlJ0jqDwMejZhuimQxk74zIj1ezRKbZxwMUi0Y2r94ppXljNpGAu3/ICF4YSBdVqYywdumDxBlbd JJKIat20U5SmITLMigX1f1C+yGXkEAOUp7H0Gn8RXxzurQzDQbbzoc3N+vJihfv1dIBL84I0QWSfq 5vWboT3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbgO5-000000055SD-1RFA; Wed, 07 Aug 2024 13:07:33 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbgNR-000000055El-1aYc for linux-arm-kernel@lists.infradead.org; Wed, 07 Aug 2024 13:06:55 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 477D6mwW096127; Wed, 7 Aug 2024 08:06:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1723036008; bh=sse7kT6azNByYduNdrThku4TmwDTwyJbiElkKLi6dtw=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=BXmmDjVozkVOHhPZ9ZXz7JYQ39/qYGBwnwuGzDButm06c5NQwQ2WB3x1FHsSYTU8b 7NDlefGltcgbmhSCFPOV+Qh0qz5IgzRkui0lvvyxdsXNwLc35DkUbzgZT5POfgzG98 dI9iiWOACoIWHTwLMyFvBljNzdYvGLjNBft2tV1E= Received: from DFLE100.ent.ti.com (dfle100.ent.ti.com [10.64.6.21]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 477D6mIw122246 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 7 Aug 2024 08:06:48 -0500 Received: from DFLE114.ent.ti.com (10.64.6.35) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Wed, 7 Aug 2024 08:06:48 -0500 Received: from lelvsmtp5.itg.ti.com (10.180.75.250) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Wed, 7 Aug 2024 08:06:48 -0500 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232]) by lelvsmtp5.itg.ti.com (8.15.2/8.15.2) with ESMTP id 477D6mZE096327; Wed, 7 Aug 2024 08:06:48 -0500 Date: Wed, 7 Aug 2024 08:06:48 -0500 From: Nishanth Menon To: Manorit Chawdhry CC: Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , , , , Udit Kumar , Neha Malcom Francis , Aniket Limaye Subject: Re: [PATCH v3 6/9] arm64: dts: ti: Split k3-j784s4-j742s2-evm-common.dtsi Message-ID: <20240807130648.elyf66euunm6iowy@illusion> References: <20240731-b4-upstream-j742s2-v3-0-da7fe3aa9e90@ti.com> <20240731-b4-upstream-j742s2-v3-6-da7fe3aa9e90@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240731-b4-upstream-j742s2-v3-6-da7fe3aa9e90@ti.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240807_060653_582870_E64F7837 X-CRM114-Status: GOOD ( 17.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 22:40-20240731, Manorit Chawdhry wrote: > k3-j784s4-j742s2-evm-common.dtsi will be included in k3-j742s2-evm.dts > at a later point so move j784s4 related stuff to k3-j784s4-evm.dts How about this: Refactor J784s2-evm to a common file which uses the superset device to allow reuse in j742s2-evm which uses the subset part. Use a similar style commit message in other refactoring patches as well. > > Signed-off-by: Manorit Chawdhry > --- > arch/arm64/boot/dts/ti/k3-j784s4-evm.dts | 49 ++++++++++++++++++++++ > .../boot/dts/ti/k3-j784s4-j742s2-evm-common.dtsi | 42 ------------------- > 2 files changed, 49 insertions(+), 42 deletions(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts > index e3730b2bca92..2543983b7fe7 100644 > --- a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts > +++ b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts > @@ -5,4 +5,53 @@ > * EVM Board Schematics: https://www.ti.com/lit/zip/sprr458 > */ > > +/dts-v1/; > + > +#include > +#include > +#include "k3-j784s4.dtsi" > #include "k3-j784s4-j742s2-evm-common.dtsi" > + > +/ { > + compatible = "ti,j784s4-evm", "ti,j784s4"; > + model = "Texas Instruments J784S4 EVM"; > + > + memory@80000000 { > + device_type = "memory"; > + bootph-all; > + /* 32G RAM */ > + reg = <0x00000000 0x80000000 0x00000000 0x80000000>, > + <0x00000008 0x80000000 0x00000007 0x80000000>; I understand you are moving the nodes in and it is just copy paste, but we have an opportunity to clean the nodes up a bit here. Same as https://lore.kernel.org/all/20240807120629.3bo2cu3wlpkixwrp@flattered/ > + }; > + > + reserved_memory: reserved-memory { > + #address-cells = <2>; > + #size-cells = <2>; > + > + c71_3_dma_memory_region: c71-dma-memory@ab000000 { > + compatible = "shared-dma-pool"; > + reg = <0x00 0xab000000 0x00 0x100000>; > + no-map; > + }; > + > + c71_3_memory_region: c71-memory@ab100000 { > + compatible = "shared-dma-pool"; > + reg = <0x00 0xab100000 0x00 0xf00000>; > + no-map; > + }; > + }; > +}; > + > +&mailbox0_cluster5 { > + mbox_c71_3: mbox-c71-3 { > + ti,mbox-rx = <2 0 0>; > + ti,mbox-tx = <3 0 0>; > + }; > +}; > + > +&c71_3 { > + status = "okay"; Status comes last. I know that these coding standards are new, and it takes a little getting used to and one wishes there was a linting tool of some sort to make this easier.. but for now, eyes are the only way out :(. > + mboxes = <&mailbox0_cluster5 &mbox_c71_3>; > + memory-region = <&c71_3_dma_memory_region>, > + <&c71_3_memory_region>; > +}; -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D