From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A0D4CC52D71 for ; Wed, 7 Aug 2024 14:12:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rimw5Jn9uH+cdYJjb+50EhdPc5GlcLFDSEPep8LTiow=; b=eGyfV9B7RnyHZNxdrr90WvwzMs CqMkIlxVK/qVL2oNTkmYACbOc569BDrN/q8XX7RWzHm2ernuvzwdkrZ4JEFavqGyHauBc3rftLdo0 +U5L1pLXEav78ID5XtKx4TPRNZ3e9UwED92ULictJJbgDqET/N7Ak+1ETnOzhoVmYa7ZYWccIziPl RDCNWYNRfNaGLUR76Mx5+gkYCUMW3whXutHRrStNkWqZQ/2zYaaybzJsl55IaQ8YhpstrQGb9tONW M5WWc2Mv32y+Gj+tExwmkwjCG44TQ9S4tptEKZouN6/9IGRgSmluAlcMpF+PNf87tLZE3Fu+wTI0E EpUOxrug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbhOf-00000005HHe-41sn; Wed, 07 Aug 2024 14:12:13 +0000 Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbhO4-00000005HA0-0XLB for linux-arm-kernel@lists.infradead.org; Wed, 07 Aug 2024 14:11:37 +0000 Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-70d23caf8ddso1652230b3a.0 for ; Wed, 07 Aug 2024 07:11:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1723039895; x=1723644695; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=rimw5Jn9uH+cdYJjb+50EhdPc5GlcLFDSEPep8LTiow=; b=jBklclBfBM2GQJOM4a1o5vE+QmlPh3VdukHHt40ZKnzQmR/4WQUP5xdbGiU46uzaQA wPhe8Qpry/I1iczIjEykSdh5ZJVNnFAy3dHvxIcH4U/i3vLsH8/1cLsHSKIG3qRmCGV7 cwk1+Q/l3mELePc02WBp1xAzmwpOTX0+rhcPn0Qf1U8vJBASUcQvIPbCpC6FxjJI3MYz BKyS38VF8rjZXoY94OCN7NTWDDoszGdmrhry0BfWqBJzbwrKHnYAL2fZCGrN78jkoRNY By04lPUSuoxPB7nf+62ax37jfSpFwakpnaxXyJUpAUDNd3cHbWpPrE59CGdVpLES90fw ZO5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723039895; x=1723644695; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rimw5Jn9uH+cdYJjb+50EhdPc5GlcLFDSEPep8LTiow=; b=d8+pjDYLyf31Fe9ukr/OzwKDscjktp/OYssgKGE5hPAZ/mGY4Jf9wRkY1uAt8Y5+QS 9de+p0b5CiZqPU4tafOUWJjgDZOD8pETxq6qBwOC/aVmy4OURU6Zsn+2/h+CWlY4zPjA 3wSzzUXcMn3RBCok5dez7WEnCgQVikdtYyVy0xekovmgTysrukETPH/QkMMPEAZnkm6e imJxR8FTAthLPpU/JpZYu9HCFB5XIOrQSGi5AiGyB6vcY7CShki/vCszOiTSzBJHy5zo NgCXtVAgqpepEX5tv2g2RVPY6VHbTa5o3SIHVh01DiCgQlfBdpFPYG9qI9yiMEG3s969 qEaw== X-Forwarded-Encrypted: i=1; AJvYcCVZMkjavfU1ot4UuRSj0F5XYlb0YcEs9M3W9pNUMHrD8xmkEfp+jbiCRFzm1AqxIXXYeaqHF35Q1SdaGIJFvkxyuDuc4JTAB8fAwXvk0aIvPu4hINw= X-Gm-Message-State: AOJu0YzGRYOTIJur787FJELKWU05+TmG2hsE/JC3u/xYXJQMw1NST+NB SD/waOE9kdrQEzHeS4lML1l7IEb/3a55JOU9sezhlxm1Bzb6t5bdn0BfSgX0iw== X-Google-Smtp-Source: AGHT+IGodAwSN1lMhVJFTLhKee9VbLa7+wzCnQRfzZCvZUvMjJkNY3ENmfDIA5EFtx44ruALqfnj2g== X-Received: by 2002:a05:6a20:12cd:b0:1c4:919f:368d with SMTP id adf61e73a8af0-1c69966bacamr27493687637.49.1723039894907; Wed, 07 Aug 2024 07:11:34 -0700 (PDT) Received: from thinkpad ([120.60.60.211]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7109d5e0318sm4277892b3a.121.2024.08.07.07.11.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Aug 2024 07:11:34 -0700 (PDT) Date: Wed, 7 Aug 2024 19:41:17 +0530 From: Manivannan Sadhasivam To: Jim Quinlan Cc: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Stanimir Varbanov , Krzysztof Kozlowski , bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com, Florian Fainelli , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Philipp Zabel , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list Subject: Re: [PATCH v5 10/12] PCI: brcmstb: Check return value of all reset_control_xxx calls Message-ID: <20240807141117.GK3412@thinkpad> References: <20240731222831.14895-1-james.quinlan@broadcom.com> <20240731222831.14895-11-james.quinlan@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240731222831.14895-11-james.quinlan@broadcom.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240807_071136_218700_4BC485CF X-CRM114-Status: GOOD ( 22.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 31, 2024 at 06:28:24PM -0400, Jim Quinlan wrote: > Always check the return value for invocations of reset_control_xxx() and > propagate the error to the next level. Although the current functions > in reset-brcmstb.c cannot fail, this may someday change. > > Signed-off-by: Jim Quinlan One comment below. With that addressed, Reviewed-by: Manivannan Sadhasivam > Reviewed-by: Stanimir Varbanov > Reviewed-by: Florian Fainelli > --- > drivers/pci/controller/pcie-brcmstb.c | 102 ++++++++++++++++++-------- > 1 file changed, 73 insertions(+), 29 deletions(-) > > diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c > index 0ecca3d9576f..c4ceb1823a79 100644 > --- a/drivers/pci/controller/pcie-brcmstb.c > +++ b/drivers/pci/controller/pcie-brcmstb.c [...] > static int pci_dev_may_wakeup(struct pci_dev *dev, void *data) > @@ -1478,9 +1514,12 @@ static int brcm_pcie_suspend_noirq(struct device *dev) > { > struct brcm_pcie *pcie = dev_get_drvdata(dev); > struct pci_host_bridge *bridge = pci_host_bridge_from_priv(pcie); > - int ret; > + int ret, rret; > + > + ret = brcm_pcie_turn_off(pcie); > + if (ret) > + return ret; > > - brcm_pcie_turn_off(pcie); > /* > * If brcm_phy_stop() returns an error, just dev_err(). If we > * return the error it will cause the suspend to fail and this is a > @@ -1509,7 +1548,10 @@ static int brcm_pcie_suspend_noirq(struct device *dev) > pcie->sr->supplies); > if (ret) { > dev_err(dev, "Could not turn off regulators\n"); > - reset_control_reset(pcie->rescal); > + rret = reset_control_reset(pcie->rescal); > + if (rret) > + dev_err(dev, "failed to reset 'rascal' controller ret=%d\n", > + rret); I don't think it is really necessary to capture the return value in err path. Unable to turn off the regulator itself is fatal, so we could just assert reset and hope for the best. - Mani -- மணிவண்ணன் சதாசிவம்