From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 15503C52D73 for ; Wed, 7 Aug 2024 16:31:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=35pM2e2T6H6XIz2tHUt0f/Gy2rfER3m8hz2PYttmH7g=; b=c7hWilYEG+3BSg 8ZYwdId4+dh75hmqU7v2PNwiQOpeRAj4Q1j2JDGkCKdUDiwHroxb7mqL3fRyOyfPL3h9RH/zCPxrc 3132PclE8AyHJxO2XP/cY+VKw8vTt25bXGVKcpgcYgQxC7j4UxhiEQYI5S2PT7bZfCRe1mwqLu4uv 4DzjRoyaxPXw3Z0pB4itrdJYfb0J5OFnwN9Aomrdf0SbILi8vBdDct4lyhnwo/g49KxGDNkjkkB9F f9KajB7KWu+1rpKjX4N8BMFLUTWHCIeB3ExL9NXIVKliXBwjXAFiW0gxQBK+lG5BhXhri5f8PRmI5 fYPo/vkctUtt2zziFT/A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbjZf-00000005hEu-2zcj; Wed, 07 Aug 2024 16:31:43 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbjZ7-00000005h6s-3Wi0; Wed, 07 Aug 2024 16:31:11 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 48265611F9; Wed, 7 Aug 2024 16:31:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AEEEBC32781; Wed, 7 Aug 2024 16:31:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723048269; bh=2e+tvdvnlJd7UATAhp/GJlLecWbDRVPYL2/x3pyVJ0I=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=keIhy56NccKd3cSYOWoIYBMx0wp5cSwr+5tt3fGWDAvug1H2LN7tiOrQIN0E/3V2w OS/DOKg0R03XxmD7+96PKgCTJdOxCK+k2zSYEpMwb12kSRItPmKS/UQuwT+3W2TUTJ yMi798279uizDzmJPqMJRQgiYOf4Hzk5l62Uo6fR7CD6d+eOspzUZtuW8evLoON/07 L9i6IVbJp4jwod2jXyJ7ONwuJYqJrDNDPllpUym44mVN9rGMBmCp0zRadv2v6gO1Hs NNaXB2lQN7LlD2VGkREoAtORj4kF40HPXZ63BqLM7w/3hcVlVy32gTUd5EpXR/imLl 2gSWO113S2OnA== Date: Wed, 7 Aug 2024 11:31:06 -0500 From: Bjorn Helgaas To: Anand Moon Cc: Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Heiko Stuebner , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH linu-next v1] PCI: dw-rockchip: Enable async probe by default Message-ID: <20240807163106.GA101420@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240625155759.132878-1-linux.amoon@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240807_093109_955449_999EDCBA X-CRM114-Status: GOOD ( 20.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 25, 2024 at 09:27:57PM +0530, Anand Moon wrote: > Rockchip PCIe driver lets waits for the combo PHY link like PCIe 3.0, > PCIe 2.0 and SATA 3.0 controller to be up during the probe this > consumes several milliseconds during boot. This needs some wordsmithing. "driver lets waits" ... I guess "lets" is not supposed to be there? I'm not sure what the relevance of "PCIe 3.0, PCIe 2.0, SATA 3.0" is. I assume the host controller driver doesn't know what downstream devices might be present, and the async probing is desirable no matter what they might be? > Establishing a PCIe link can take a while; allow asynchronous probing so > that link establishment can happen in the background while other devices > are being probed. > > Signed-off-by: Anand Moon > --- > drivers/pci/controller/dwc/pcie-dw-rockchip.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/controller/dwc/pcie-dw-rockchip.c b/drivers/pci/controller/dwc/pcie-dw-rockchip.c > index 61b1acba7182..74a3e9d172a0 100644 > --- a/drivers/pci/controller/dwc/pcie-dw-rockchip.c > +++ b/drivers/pci/controller/dwc/pcie-dw-rockchip.c > @@ -367,6 +367,7 @@ static struct platform_driver rockchip_pcie_driver = { > .name = "rockchip-dw-pcie", > .of_match_table = rockchip_pcie_of_match, > .suppress_bind_attrs = true, > + .probe_type = PROBE_PREFER_ASYNCHRONOUS, > }, > .probe = rockchip_pcie_probe, > }; > -- > 2.44.0 >