From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 59721C3DA4A for ; Thu, 8 Aug 2024 15:14:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RlwKey+PJeZN0A9rh/S0vL1F8rX1MwKvwXZ2q25uwGA=; b=tSmGGAJI0g6FxvYQufF0S8jN1j JlzUUrP0+2mLf3Zcf9aqaX4ZxinaLtNk1WT9Ha30OQpZPJ2P+yNzcMfXL8STFhfYMYyowVCN4hyXB MB+H2+dMjbNnVFXkebMTRPWro6p2wn3OV1/wYmPBNsZDJ+AENDr5Fp5reH2/V126c8PaUc9B6iZdN FVSLEKiU0oCEIGGmABWCmhUMFI6Ba+W+pB6u8Mx2JiixQnIAjuYn3joP/MX1nkQuBN6iHLQf/hDEg zlRFIgFJbsFFrggJ+HfyO1FstLBnWDB9CskHhIUetUfPAV5XlIsoAVve5l41TBRGO49TiKU10Zntd VFm7fIag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sc4qX-00000008gNS-1hxI; Thu, 08 Aug 2024 15:14:33 +0000 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sc4ow-00000008frs-0Be1 for linux-arm-kernel@lists.infradead.org; Thu, 08 Aug 2024 15:12:55 +0000 Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-3684bea9728so662473f8f.3 for ; Thu, 08 Aug 2024 08:12:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723129972; x=1723734772; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=RlwKey+PJeZN0A9rh/S0vL1F8rX1MwKvwXZ2q25uwGA=; b=hgQ+L0TLEaUrh3ecsj4Lev12yVp+x1cru00JB3Q5A4jUiqdM6rgl/Nbx5Bfu+GUxNt CJDBKETQ76TK+uoLswQRx6T/9UNemmXF7GAfgxzzphtuInkVp1WEUQnTgyUCsqNj+M+0 8Iyj48NHvqYAChl5NP5JXJLp+RV1liLGDSVCQpE9Du5sUEsnw88ueOfllkz4ECyFXvH+ +O+hKBdfVSShSkMpeXeH4Qo3Aj3aFQ+LmC9gjs2tQ/4hFw1li6Tp+bE0CbjN/ZmDWlYz fSCufibYdTOOTXi5uGtNB7O5BpCbxbNGFgr0h+xmBa3I8nsYOIYe9Joosx1NNEwyHZcL CJwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723129972; x=1723734772; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RlwKey+PJeZN0A9rh/S0vL1F8rX1MwKvwXZ2q25uwGA=; b=n4RUSlx9zOuEvcqpGjFhsC+9sZLQei3m+MMcFTwPpbh7FYQldK242uxxtWY2n9YOfT 7kQ6Tj1A7SuIMKfUD2kQb00g1Ywm48zVlD5EeHogYYpsRBcoImmZmNLhvwoo9s91qTmu cvr5jxMLNeHqH6KzSLXzgk0pdk6fKcWuusbJziR2H2qIp5ObPxCZoDF0vZeymXgFPmZx ohxhp2GlbMzQB15OQo/EQ1U3toO7xQ0bmz2cWh86wFE1BbMjWXES0s1GHObeDjIvy4gW IO2EXGUPTss5i/FnCNOnU/ZxTbA4AdUgyJBbicF55ltyVzHmhlQs5A4iVnivFie3yDjE ERbA== X-Forwarded-Encrypted: i=1; AJvYcCXko15jaYFVkbtLCsNNKtXyCJUWL+gHxiUiYmPFnXgXQZ215+1ORvasDx+3vBQmrvU8BUXaO5IvO7hwiDx6thNC3iWq7S7IMKUhP6xpEOigTwJCfLE= X-Gm-Message-State: AOJu0Yxlr3dr6D6ZqD9nMI4Rl0ouu+p2CSOUcTqIBjRPGUOLc3ANJJ/B 1W7pU+Nm4gb/So0mnJqBoLZmipD260bdqAqFiquLkS5Bqblfa0H5 X-Google-Smtp-Source: AGHT+IFzix7VIeZTIQg0zBbjhj5GUek1tgQE9LwRj9V7JHckkhnN4U9cHGMO4vhsBtlpWQ50/ywkIg== X-Received: by 2002:a5d:5743:0:b0:368:6d75:1bde with SMTP id ffacd0b85a97d-36d274df3eamr1785039f8f.15.1723129971713; Thu, 08 Aug 2024 08:12:51 -0700 (PDT) Received: from [127.0.1.1] ([213.208.157.67]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36d27157145sm2179881f8f.12.2024.08.08.08.12.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Aug 2024 08:12:51 -0700 (PDT) From: Javier Carrasco Date: Thu, 08 Aug 2024 17:12:38 +0200 Subject: [PATCH v2 2/3] iio: adc: xilinx-ams: use device_* to iterate over device child nodes MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20240808-device_child_node_access-v2-2-fc757cc76650@gmail.com> References: <20240808-device_child_node_access-v2-0-fc757cc76650@gmail.com> In-Reply-To: <20240808-device_child_node_access-v2-0-fc757cc76650@gmail.com> To: Suzuki K Poulose , Mike Leach , James Clark , Alexander Shishkin , Michael Hennerich , Lars-Peter Clausen , Jonathan Cameron , Anand Ashok Dumbre , Michal Simek , Sakari Ailus , Pavel Machek , Lee Jones Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-leds@vger.kernel.org, Javier Carrasco X-Mailer: b4 0.14-dev X-Developer-Signature: v=1; a=ed25519-sha256; t=1723129965; l=1584; i=javier.carrasco.cruz@gmail.com; s=20240312; h=from:subject:message-id; bh=cl0OgwWFGj09y5TwwEPvN3u/Sy1PyJsfo8HSpKT7rW0=; b=Nr9fmxg24DocQ91AeftJ57YIQtrR9pYh1YfzOyKJzkowwMkDRORul2NZFUngK6AIViNcppMLe 0oceNoCGid6Bb3ghyIr/zXz1d+2ydI/2tahKQ4WzdvYLIC0HsYJEnZz X-Developer-Key: i=javier.carrasco.cruz@gmail.com; a=ed25519; pk=lzSIvIzMz0JhJrzLXI0HAdPwsNPSSmEn6RbS+PTS9aQ= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240808_081254_122692_4B624645 X-CRM114-Status: GOOD ( 14.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Use `device_for_each_child_node_scoped()` in `ams_parse_firmware()` to explicitly state device child node access, and simplify the child node handling as it is not required outside the loop. Signed-off-by: Javier Carrasco --- drivers/iio/adc/xilinx-ams.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/iio/adc/xilinx-ams.c b/drivers/iio/adc/xilinx-ams.c index f051358d6b50..ebc583b07e0c 100644 --- a/drivers/iio/adc/xilinx-ams.c +++ b/drivers/iio/adc/xilinx-ams.c @@ -1275,7 +1275,6 @@ static int ams_parse_firmware(struct iio_dev *indio_dev) struct ams *ams = iio_priv(indio_dev); struct iio_chan_spec *ams_channels, *dev_channels; struct device *dev = indio_dev->dev.parent; - struct fwnode_handle *child = NULL; struct fwnode_handle *fwnode = dev_fwnode(dev); size_t ams_size; int ret, ch_cnt = 0, i, rising_off, falling_off; @@ -1297,16 +1296,12 @@ static int ams_parse_firmware(struct iio_dev *indio_dev) num_channels += ret; } - fwnode_for_each_child_node(fwnode, child) { - if (fwnode_device_is_available(child)) { - ret = ams_init_module(indio_dev, child, ams_channels + num_channels); - if (ret < 0) { - fwnode_handle_put(child); - return ret; - } + device_for_each_child_node_scoped(dev, child) { + ret = ams_init_module(indio_dev, child, ams_channels + num_channels); + if (ret < 0) + return ret; - num_channels += ret; - } + num_channels += ret; } for (i = 0; i < num_channels; i++) { -- 2.43.0