From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 103A1C52D7B for ; Thu, 8 Aug 2024 15:15:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PZh6tA0jiESoXoOtY5qAvIE49vo04MTxnTUHVFSqNH4=; b=dadTJl65N2ita0sQvNDfEiwRem BG8PCU456km7iqvOXO1N1+aB8ur4pAdTH3brnWyFOoo7YT+GE1N/OiCAzQNu/EtA7Cwaf1umx1h99 tRktGjGr3yiSO7aqIcqK+9tL+vHgu8QVcOD18jZkxAufs803aa5/o4Z7dkJZD6gK21yIFDEjKCgWj UV8z3EPwyg4MtrkkOML7vG8kztFwoYMPnMhtUspx1NLoDe+dL8x/H4cZ633I1QIq3w+fqcHJC9Upc NBhKJamEZw1fFX0sDQKhT2KHzRFHDvYVDJgbg8wstGOd9kJeyhjxB3n0XNea7ensQEyl4KzObxqnV HVTUC1CA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sc4r9-00000008gbF-0U05; Thu, 08 Aug 2024 15:15:11 +0000 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sc4oy-00000008fsK-0KXJ for linux-arm-kernel@lists.infradead.org; Thu, 08 Aug 2024 15:12:57 +0000 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-368380828d6so590244f8f.1 for ; Thu, 08 Aug 2024 08:12:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723129974; x=1723734774; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=PZh6tA0jiESoXoOtY5qAvIE49vo04MTxnTUHVFSqNH4=; b=YHJkqDQo2LcuiTXbndmRftD+ROKMsMrcgfBzaZ3xNkCgWU6lU3tYEMXs3e1qDgnOLQ LLVNLEFSCEYzhq9tb5Z5rXZbmFesI7WzCSE90kLs3oh5iFk1Yt0KNlSRWMEgV5ULJopy Rb/ePZnlLBaRuERL3KphDIaqRGSx5ws5XDM83m2r5vmVTqkRJ25024R05/2M3DuY/dfu L+limhKZLNfdctjn4bdsE0wVLtTpOjMHzvWUIsMXVr93gVYWckuS3wIkQ9xi1yP+LxRl Lz2acVHd0uAEzo7MX0h1MlBcWaBxQcFvvC210Hsy2RZ4Hd/ikVjXiHbl2fupXLvcHltf Ig6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723129974; x=1723734774; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PZh6tA0jiESoXoOtY5qAvIE49vo04MTxnTUHVFSqNH4=; b=X9G8XMthSMabon5aH8l35PwTg6Fp/VZ8Pfw4M/TKKh2WzrParaWhKNGB6YB8jjQWet YLAzrvso7zB1zfQtj2NhUtPcxbBx5EM3X0AVjc8B0zd80LrJ7XMf8QO0jBbgJGkmPUVZ K4CNC1EDkcp5B50CF2Mpr3xnZ17yI78p8dgk6q8qb5SjSXjP2d6wseNyT27TNiehEVI9 WhlMHtd+pQ+A/eDay5nyNAeGDsC6YDXOEq5W1ZAMVMq3gCJDKl2s3+4HQSF7tPv3lBT9 gO0my+tE7O47RmNAnprALMgLKxBFGMV7oQUePclouOiI9KCgfA78354ImskrVaurgKZe 1s+Q== X-Forwarded-Encrypted: i=1; AJvYcCUx7e/4qZK2fsK7QPEKun6aPMYAOqgtNn7NercWjoHuoqnWRZUtyOlEMMY9hOLmwfYeWEUgZOsrS9s2UGfTx8hAVvVEkI0ReUU8PGWUbO7500zHZKs= X-Gm-Message-State: AOJu0YyjxwHdykjdESFK3aoUJX/x7Kuhg43f6EOtGOqKuq835hVi0/hg igq2rW+TkYsJ1yWmuC5Tryq3r91ZFep5FrRAFcTr+RNIi+95hRPz X-Google-Smtp-Source: AGHT+IENRUZXk9+CpUdQ4r+iBA879/lG619Wzdm/977nxAbjK/6QNybTGmdaKvHJD6uVBnsY8QbpSQ== X-Received: by 2002:a5d:58f2:0:b0:368:714e:5a5e with SMTP id ffacd0b85a97d-36d273d0673mr1662793f8f.2.1723129973764; Thu, 08 Aug 2024 08:12:53 -0700 (PDT) Received: from [127.0.1.1] ([213.208.157.67]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36d27157145sm2179881f8f.12.2024.08.08.08.12.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Aug 2024 08:12:53 -0700 (PDT) From: Javier Carrasco Date: Thu, 08 Aug 2024 17:12:39 +0200 Subject: [PATCH v2 3/3] leds: as3645a: use device_* to iterate over device child nodes MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20240808-device_child_node_access-v2-3-fc757cc76650@gmail.com> References: <20240808-device_child_node_access-v2-0-fc757cc76650@gmail.com> In-Reply-To: <20240808-device_child_node_access-v2-0-fc757cc76650@gmail.com> To: Suzuki K Poulose , Mike Leach , James Clark , Alexander Shishkin , Michael Hennerich , Lars-Peter Clausen , Jonathan Cameron , Anand Ashok Dumbre , Michal Simek , Sakari Ailus , Pavel Machek , Lee Jones Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-leds@vger.kernel.org, Javier Carrasco X-Mailer: b4 0.14-dev X-Developer-Signature: v=1; a=ed25519-sha256; t=1723129965; l=1681; i=javier.carrasco.cruz@gmail.com; s=20240312; h=from:subject:message-id; bh=nEcNIE1U7DZAocIwTQqOGm97es75K5AAksPENUTjEFw=; b=yK5A5zMeB7sJ1oAnNbYGRuh0S9Y0nLJS/9nl8xfh6aDTDvvJRaVGSdFyccjPSKkv0RBXsa9yn kTVocwI/IrBBGlgGPYpMb9nlcqZKE9bVZrGFgVSRkFl3eRsPBOtEwcU X-Developer-Key: i=javier.carrasco.cruz@gmail.com; a=ed25519; pk=lzSIvIzMz0JhJrzLXI0HAdPwsNPSSmEn6RbS+PTS9aQ= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240808_081256_151693_057ED121 X-CRM114-Status: GOOD ( 13.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Drop the manual access to the fwnode of the device to iterate over its child nodes. `device_for_each_child_node` macro provides direct access to the child nodes, and given that the `child` variable is only required within the loop, the scoped variant of the macro can be used. Use the `device_for_each_child_node_scoped` macro to iterate over the direct child nodes of the device. Acked-by: Sakari Ailus Signed-off-by: Javier Carrasco --- drivers/leds/flash/leds-as3645a.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/leds/flash/leds-as3645a.c b/drivers/leds/flash/leds-as3645a.c index 2c6ef321b7c8..8e6abedf6e00 100644 --- a/drivers/leds/flash/leds-as3645a.c +++ b/drivers/leds/flash/leds-as3645a.c @@ -478,14 +478,12 @@ static int as3645a_detect(struct as3645a *flash) return as3645a_write(flash, AS_BOOST_REG, AS_BOOST_CURRENT_DISABLE); } -static int as3645a_parse_node(struct as3645a *flash, - struct fwnode_handle *fwnode) +static int as3645a_parse_node(struct as3645a *flash, struct device *dev) { struct as3645a_config *cfg = &flash->cfg; - struct fwnode_handle *child; int rval; - fwnode_for_each_child_node(fwnode, child) { + device_for_each_child_node_scoped(dev, child) { u32 id = 0; fwnode_property_read_u32(child, "reg", &id); @@ -686,7 +684,7 @@ static int as3645a_probe(struct i2c_client *client) flash->client = client; - rval = as3645a_parse_node(flash, dev_fwnode(&client->dev)); + rval = as3645a_parse_node(flash, &client->dev); if (rval < 0) return rval; -- 2.43.0