From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 62F5DC3DA4A for ; Thu, 8 Aug 2024 15:56:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vEzY4C6mfTs2TFhQiIQT2GbsCRXnBiJuK+ehBtym/eM=; b=s6RJb7ZEd2iEtcg3it1uNcR9VP PFSbSfcuz9WQDfPjksOFR9DZQuB+T3IhJm52e8Qd6W0djRvI+ir4WXZOARvx8muqIAv1Yr9FMtI/8 4Ondm/MmhzCI5MrF5DxLxhxwj+T/Pb21WSMxIO65CsrLUZ+CezFVON+6Vcsm4nNBVqkU8klGa7fQL KCNGaHhlkp1egBTv4fVwRgjjZXozQEhIr403WTsSEoVqRHRezx+T7WNQqotf/4FXOiAuJhbphVCzd QCKT3VZwLHSXbSFNNp4W5sukrOc+NlZ27g1yHiii7iLTlsA2Pn9a7WeRWP2uijc594xquTTFIXqE2 RcKJhnlw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sc5Ud-00000008rGS-0QIE; Thu, 08 Aug 2024 15:55:59 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sc5Ty-00000008r91-3wB1 for linux-arm-kernel@lists.infradead.org; Thu, 08 Aug 2024 15:55:25 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 69211619C5; Thu, 8 Aug 2024 15:55:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 36F1DC32782; Thu, 8 Aug 2024 15:55:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723132518; bh=vEzY4C6mfTs2TFhQiIQT2GbsCRXnBiJuK+ehBtym/eM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=quvZyxoqosQ7vYc9F+w9yQtxhcLXk1oLpov53MqiZT+ELJixY4qSmgwrMGKhKg8nR f2io3sgdUP9B98BCaO/Td8zOFsp4vk7JcyqTj85IWFYq0lGWlPsb2yK4VrF99DE9K+ koQPIpfA5iPU7mHzZEVyauLZ+F/+dn9a5vbvrP5GCK+91FFDeeW/cxBw65iv356xti 17ZSas5gjbF0CSIHqsytDlG5VDFT6gZ1ZwR6EpnehaBwndjZ/5eT234EQZ0nBeBbOB 5Oe+UdLfHSLRnIrXom0KYiE9FEriusJjrbRPmLTqK9yuVUR5iCJXCx1iI2Q2rf+7I0 3vg6CamLy1YiA== Date: Thu, 8 Aug 2024 16:55:14 +0100 From: Conor Dooley To: Frank Li Cc: Shawn Guo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "moderated list:ARM/FREESCALE LAYERSCAPE ARM ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list , imx@lists.linux.dev Subject: Re: [PATCH 1/1] arm64: dts: lx2160a: Change PCIe compatible string to fsl,ls2088a-pcie Message-ID: <20240808-linoleum-evasion-ad7111a2afc4@spud> References: <20240808153120.3305203-1-Frank.Li@nxp.com> <20240808-frosted-voicing-883f4f728527@spud> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="iF4455zFqFQ3CKov" Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240808_085519_046871_5C5A8F3B X-CRM114-Status: GOOD ( 20.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --iF4455zFqFQ3CKov Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 08, 2024 at 11:51:34AM -0400, Frank Li wrote: > On Thu, Aug 08, 2024 at 04:34:32PM +0100, Conor Dooley wrote: > > On Thu, Aug 08, 2024 at 11:31:20AM -0400, Frank Li wrote: > > > The mass production lx2160 rev2 use designware PCIe Controller. Old R= ev1 > > > which use mobivel PCIe controller was not supported. Although uboot > > > fixup can change compatible string fsl,lx2160a-pcie to fsl,ls2088a-pc= ie > > > since 2019, it is quite confused and should correctly reflect hardware > > > status in fsl-lx2160a.dtsi. > > > > This does not begin to explain why removing the soc-specific compatible, > > and instead putting the compatible for another soc is the right fix. > > Come up with a new compatible for this device, that perhaps falls back > > to the ls2088a, but this change doesn't seem right to me. >=20 > It can't fallback to fsl,ls2088a-pcie if fsl,lx2160a-pcie exist, which are > totally imcompatible between fsl,ls2088a-pcie and fsl,lx2160a-pcie. >=20 > Previous dtb can work just because uboot dynamtic change fsl,lx2160a-pcie > to fsl,ls2088a-pcie when boot kernel. >=20 > fsl,lx2160a-pcie should be removed because Rev1 have not mass productione= d. Please re-read what I wrote. I said to come up with a new compatible for this device, not fall back from the existing fsl,lx2160a-pcie to fsl,ls2088a-pcie. Thanks, Conor. --iF4455zFqFQ3CKov Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZrTqYgAKCRB4tDGHoIJi 0oKoAPwOlkVSMPKo4T7m7wer8pIHsbwifYEUcKJ8UxsVCdBU2gEAhNy5yupcBVO7 VUD6MOFw7a357c6cRPw6F/FAz+JfWg4= =Xu7U -----END PGP SIGNATURE----- --iF4455zFqFQ3CKov--