Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Manorit Chawdhry <m-chawdhry@ti.com>
To: "Limaye, Aniket" <a-limaye@ti.com>
Cc: Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
	Tero Kristo <kristo@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Neha Malcom Francis <n-francis@ti.com>,
	Udit Kumar <u-kumar1@ti.com>, Beleswar Padhi <b-padhi@ti.com>,
	Siddharth Vadapalli <s-vadapalli@ti.com>
Subject: Re: [PATCH v3 5/5] arm64: dts: ti: k3-j7200*: Add bootph-* properties
Date: Thu, 8 Aug 2024 14:50:54 +0530	[thread overview]
Message-ID: <20240808092054.7x62hy5twrwmadv6@uda0497581> (raw)
In-Reply-To: <1cee1ebf-8281-440a-bf45-baa9b0e3b68f@ti.com>

Hi Aniket,

On 20:07-20240807, Limaye, Aniket wrote:
> Hi Manorit,
> 
> On 7/30/2024 3:23 PM, Manorit Chawdhry wrote:
> > Adds bootph-* properties to the leaf nodes to enable U-boot to
> > utilise them.
> > 
> > Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com>
> > ---
> >   .../arm64/boot/dts/ti/k3-j7200-common-proc-board.dts | 20 ++++++++++++++++++++
> >   arch/arm64/boot/dts/ti/k3-j7200-main.dtsi            |  2 ++
> >   arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi      | 10 ++++++++++
> >   arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi          |  7 +++++++
> >   4 files changed, 39 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
> > index 5097d192c2b2..f8a5ad4737da 100644
> > --- a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
> > @@ -21,16 +21,19 @@ dmsc: system-controller@44083000 {
> 
> Referring to the thread from v2 [0], I see that you have removed the
> bootph-all from the parent dmsc node. With current patch j7200-evm fails to
> boot (Stuck somewhere in tispl or right after that) as discussed in the same
> thread [0].
> 
> I have boot tested this patch (SD boot) and the device boots with an
> additional bootph-all at dmsc node.
> 
> I assume the removal was done intentionally, meaning we intend to fix the
> bug in u-boot or carry the one extra bootph-all there. If NOT, please add
> the same in the parent dmsc node here as well.

Yes, the removal was intentional and there is a fix that can be done in
U-boot for this so we'll take that up there.

Thanks for reviewing!

Regards,
Manorit

> 
> So taking care of the above,
> 
> Reviewed-by: Aniket Limaye <a-limaye@ti.com>
> 
> [0]: https://lore.kernel.org/all/20240709084857.nf7c57mi6miajeau@uda0497581/


      reply	other threads:[~2024-08-08  9:21 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-30  9:53 [PATCH v3 0/5] Add bootph-all property for J7 boards Manorit Chawdhry
2024-07-30  9:53 ` [PATCH v3 1/5] arm64: dts: ti: k3-j721s2*: Add bootph-* properties Manorit Chawdhry
2024-08-06 14:43   ` Andrew Davis
2024-08-06 15:05     ` Nishanth Menon
2024-08-06 15:07     ` Nishanth Menon
2024-08-07  5:26       ` Manorit Chawdhry
2024-08-07  5:33         ` Neha Malcom Francis
2024-08-07  5:42           ` Manorit Chawdhry
2024-08-07  5:48             ` Neha Malcom Francis
2024-08-07  6:36               ` Manorit Chawdhry
2024-08-07 11:49                 ` Nishanth Menon
2024-08-07  5:49             ` Manorit Chawdhry
2024-08-07 11:47         ` Nishanth Menon
2024-08-07  5:31     ` Manorit Chawdhry
2024-07-30  9:53 ` [PATCH v3 2/5] arm64: dts: ti: k3-j784s4*: Remove bootph properties from parent nodes Manorit Chawdhry
2024-08-07  7:51   ` Kumar, Udit
2024-07-30  9:53 ` [PATCH v3 3/5] arm64: dts: ti: k3-am68*: Add bootph-* properties Manorit Chawdhry
2024-07-30  9:53 ` [PATCH v3 4/5] arm64: dts: ti: k3-j721e*: " Manorit Chawdhry
2024-08-07  7:37   ` Kumar, Udit
2024-08-07  8:35     ` Manorit Chawdhry
2024-08-07  9:16       ` Kumar, Udit
2024-08-07  9:24   ` Neha Malcom Francis
2024-08-07  9:47     ` Manorit Chawdhry
2024-07-30  9:53 ` [PATCH v3 5/5] arm64: dts: ti: k3-j7200*: " Manorit Chawdhry
2024-08-07  7:28   ` Kumar, Udit
2024-08-07  7:50     ` Manorit Chawdhry
2024-08-07  9:15       ` Kumar, Udit
2024-08-07 14:37   ` Limaye, Aniket
2024-08-08  9:20     ` Manorit Chawdhry [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240808092054.7x62hy5twrwmadv6@uda0497581 \
    --to=m-chawdhry@ti.com \
    --cc=a-limaye@ti.com \
    --cc=b-padhi@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=n-francis@ti.com \
    --cc=nm@ti.com \
    --cc=robh@kernel.org \
    --cc=s-vadapalli@ti.com \
    --cc=u-kumar1@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox