Re: [PATCH] usb: chipidea: Use of_property_present()

[Peter Chen <peter.chen@kernel.org>]

On 24-07-31 13:12:56, Rob Herring (Arm) wrote:
> Use of_property_present() to test for property presence rather than
> of_get_property(). This is part of a larger effort to remove callers
> of of_get_property() and similar functions. of_get_property() leaks
> the DT property data pointer which is a problem for dynamically
> allocated nodes which may be freed.
> 
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>

Acked-by: Peter Chen <peter.chen@kernel.org>

> ---
>  drivers/usb/chipidea/ci_hdrc_imx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c
> index bdc04ce919f7..c64ab0e07ea0 100644
> --- a/drivers/usb/chipidea/ci_hdrc_imx.c
> +++ b/drivers/usb/chipidea/ci_hdrc_imx.c
> @@ -128,7 +128,7 @@ static struct imx_usbmisc_data *usbmisc_get_init_data(struct device *dev)
>  	 * In case the fsl,usbmisc property is not present this device doesn't
>  	 * need usbmisc. Return NULL (which is no error here)
>  	 */
> -	if (!of_get_property(np, "fsl,usbmisc", NULL))
> +	if (!of_property_present(np, "fsl,usbmisc"))
>  		return NULL;
>  
>  	data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
> -- 
> 2.43.0
>