From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 46CA4C3DA4A for ; Fri, 9 Aug 2024 19:07:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=BphN8B6kX8MQX4vER4c6kmasplr9q0G647QW9Fj/QSE=; b=doFYM7q/ZEQlZf FDu56fGp0vTD6XxSBvYUU/P/4IwHVpPlFSkeIAo9d6YVZ0Oz6e2LYTq3k83l68fVPhSSREaR7IN7B IsUs+GAA3/zW/MJrknd2SumZx/unLa49Wx/GCYm1Op8bxAHd18TlKI/+2cGrBJ8f3/d2OyYHxn5qT bjTxeiSv6i/8qDtVOjYK892U7isD1XRZvLUcEJKE+hSmTmd0ZXezzQVxLHExrUMQ3eurAQnOsB8Vu 1Hv45HDmgjz9SrHDrJNayIAghgxIRZZl3f9JQfMWynKVR/vWaWyUNE3xJVfgTgcZ7FLM4h4GYPELl pJRZRwg+0C2LlBkIJ0iA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1scUx3-0000000CILZ-2cyX; Fri, 09 Aug 2024 19:07:01 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1scUwT-0000000CIB2-0cvx for linux-arm-kernel@lists.infradead.org; Fri, 09 Aug 2024 19:06:26 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id B2EC9CE182A; Fri, 9 Aug 2024 19:06:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D9A92C32782; Fri, 9 Aug 2024 19:06:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723230381; bh=u34Xd5rz4JWanX5zVdA6gtjHYqcgdi9xC5E30BaCsAY=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=IT/3DQFGDQ8SVxZaUY9e6nFJ2+iyjayjEKDu0s+jObgn5SICq7pFm6MLMrPQjhf/D UZAautMAmpXEcEvWn95POQrgsQjROAmHBaGhP0PDVTkXsZTa0arr98g7nzHHh12ZaR E8naemEdZqiYSdrndo1jeMEAJvoeMHfZLhatP9THP1awIZDvJBZua018u9d1WGOYA3 Om8m54pRk8d4Nd0RImnWrNKtrAz9I0nNCnF4WX9xJ9GsTZMfEn3vaHAw1hXfq0wNMK JPPn2fXLlXjbLBDjqRSUXinnAGF+FXRr3j0e68S4ICJdFY9+NvRywjIxp4ImGffGiu 7+ebQXNRKQOAg== Date: Fri, 9 Aug 2024 14:06:19 -0500 From: Bjorn Helgaas To: Frank Li Cc: Will Deacon , Bjorn Helgaas , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "open list:PCI DRIVER FOR GENERIC OF HOSTS" , "moderated list:PCI DRIVER FOR GENERIC OF HOSTS" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list , imx@lists.linux.dev Subject: Re: [PATCH v2 1/1] dt-bindings: PCI: host-generic-pci: Drop minItems and maxItems of ranges Message-ID: <20240809190619.GA206533@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240704164019.611454-1-Frank.Li@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240809_120625_400400_F8665BF5 X-CRM114-Status: GOOD ( 18.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 04, 2024 at 12:40:19PM -0400, Frank Li wrote: > The ranges description states that "at least one non-prefetchable memory > and one or both of prefetchable memory and IO space may also be provided." > > However, it should not limit the maximum number of ranges to 3. > > Freescale LS1028 and iMX95 use more than 3 ranges because the space splits > some discontinuous prefetchable and non-prefetchable segments. > > Drop minItems and maxItems. The number of entries will be limited to 32 > in pci-bus-common.yaml in dtschema, which should be sufficient. > > Fix the below CHECK_DTBS warning. > arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dtb: pcie@1f0000000: ranges: [[2181038080, 1, 4160749568, 1, 4160749568, 0, 1441792], [3254779904, 1, 4162191360, 1, 4162191360, 0, 458752], [2181038080, 1, 4162650112, 1, 4162650112, 0, 131072], [3254779904, 1, 4162781184, 1, 4162781184, 0, 131072], [2181038080, 1, 4162912256, 1, 4162912256, 0, 131072], [3254779904, 1, 4163043328, 1, 4163043328, 0, 131072], [2181038080, 1, 4227858432, 1, 4227858432, 0, 4194304]] is too long > > Signed-off-by: Frank Li Applied with Rob's Reviewed-by to pci/dt-bindings for v6.12, thanks! > --- > Change from v1 to v2 > - Rework commit message > - drop minItems and maxItems according to Rob's comments. > --- > Documentation/devicetree/bindings/pci/host-generic-pci.yaml | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pci/host-generic-pci.yaml b/Documentation/devicetree/bindings/pci/host-generic-pci.yaml > index 3484e0b4b412e..3be1fff411f8d 100644 > --- a/Documentation/devicetree/bindings/pci/host-generic-pci.yaml > +++ b/Documentation/devicetree/bindings/pci/host-generic-pci.yaml > @@ -102,8 +102,6 @@ properties: > As described in IEEE Std 1275-1994, but must provide at least a > definition of non-prefetchable memory. One or both of prefetchable Memory > and IO Space may also be provided. > - minItems: 1 > - maxItems: 3 > > dma-coherent: true > iommu-map: true > -- > 2.34.1 >