From: Sean Anderson <sean.anderson@linux.dev>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
David Airlie <airlied@gmail.com>,
Michal Simek <michal.simek@amd.com>,
Daniel Vetter <daniel@ffwll.ch>,
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
Sean Anderson <sean.anderson@linux.dev>
Subject: [PATCH v6 1/8] drm: zynqmp_kms: Unplug DRM device before removal
Date: Fri, 9 Aug 2024 15:35:53 -0400 [thread overview]
Message-ID: <20240809193600.3360015-2-sean.anderson@linux.dev> (raw)
In-Reply-To: <20240809193600.3360015-1-sean.anderson@linux.dev>
Prevent userspace accesses to the DRM device from causing
use-after-frees by unplugging the device before we remove it. This
causes any further userspace accesses to result in an error without
further calls into this driver's internals.
Fixes: d76271d22694 ("drm: xlnx: DRM/KMS driver for Xilinx ZynqMP DisplayPort Subsystem")
Closes: https://lore.kernel.org/dri-devel/4d8f4c9b-2efb-4774-9a37-2f257f79b2c9@linux.dev/
Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
---
Thanks to Maxime for pointing out the correct function to use here.
Changes in v6:
- New
drivers/gpu/drm/xlnx/zynqmp_kms.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xlnx/zynqmp_kms.c b/drivers/gpu/drm/xlnx/zynqmp_kms.c
index bd1368df7870..4556af2faa0f 100644
--- a/drivers/gpu/drm/xlnx/zynqmp_kms.c
+++ b/drivers/gpu/drm/xlnx/zynqmp_kms.c
@@ -536,7 +536,7 @@ void zynqmp_dpsub_drm_cleanup(struct zynqmp_dpsub *dpsub)
{
struct drm_device *drm = &dpsub->drm->dev;
- drm_dev_unregister(drm);
+ drm_dev_unplug(drm);
drm_atomic_helper_shutdown(drm);
drm_encoder_cleanup(&dpsub->drm->encoder);
drm_kms_helper_poll_fini(drm);
--
2.35.1.1320.gc452695387.dirty
next prev parent reply other threads:[~2024-08-09 19:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-09 19:35 [PATCH v6 0/8] drm: zynqmp_dp: IRQ cleanups and debugfs support Sean Anderson
2024-08-09 19:35 ` Sean Anderson [this message]
2024-08-09 19:35 ` [PATCH v6 2/8] drm: zynqmp_dp: Add locking Sean Anderson
2024-08-09 19:35 ` [PATCH v6 3/8] drm: zynqmp_dp: Don't retrain the link in our IRQ Sean Anderson
2024-08-09 19:35 ` [PATCH v6 4/8] drm: zynqmp_dp: Convert to a hard IRQ Sean Anderson
2024-10-02 13:52 ` Tomi Valkeinen
2024-08-09 19:35 ` [PATCH v6 5/8] drm: zynqmp_dp: Use AUX IRQs instead of polling Sean Anderson
2024-08-09 19:35 ` [PATCH v6 6/8] drm: zynqmp_dp: Split off several helper functions Sean Anderson
2024-08-09 19:35 ` [PATCH v6 7/8] drm: zynqmp_dp: Take dp->lock in zynqmp_dp_hpd_work_func Sean Anderson
2024-08-09 19:36 ` [PATCH v6 8/8] drm: zynqmp_dp: Add debugfs interface for compliance testing Sean Anderson
2024-10-01 18:31 ` [PATCH v6 0/8] drm: zynqmp_dp: IRQ cleanups and debugfs support Sean Anderson
2024-10-02 14:50 ` Tomi Valkeinen
2024-10-03 14:53 ` Sean Anderson
2024-10-25 14:58 ` Sean Anderson
2024-10-28 15:04 ` Tomi Valkeinen
2024-10-30 12:30 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240809193600.3360015-2-sean.anderson@linux.dev \
--to=sean.anderson@linux.dev \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=michal.simek@amd.com \
--cc=mripard@kernel.org \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).