From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F1A2C3DA4A for ; Wed, 14 Aug 2024 16:43:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TZMcBl3qxGEA1Iw1lXHBYKflDNVj/ncbdYLPX+FZIog=; b=Xk/5aTm8XjbQtr FTa9MGeI1d574i0yMhiKUhr7cc2WOJYek2hKbTKIib8VPYUyTedhWO8lCajWjiDd/z3brd0sAFlPH wQ+Ep3bLaTcnpGA7Qp9bO96gRu46dHzFqRV9+kwCRJ9H6TJB05TJ4V/Pe1ZIEjpGBjt12WL67IGK8 CH+CMNqCZBM/DpqyshZ+yj3CIIa/SSQM63zLLoupbuFLmzUZNsRoTaOhB1TH6PW1sr37njgCX0beX B4SEVCVLPr8GWzLXG5AF0ot2mOXbP2UPigP3jIuw8l1eOweKBsq0TYrmU+MmwrZMgsklpf4ogcj6z xt7pinyABdOAgyddKdYQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1seH5z-00000007iAk-3xj7; Wed, 14 Aug 2024 16:43:35 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1seH5L-00000007i5z-2wNW for linux-arm-kernel@lists.infradead.org; Wed, 14 Aug 2024 16:42:57 +0000 Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4WkYrp1H7Wz6K9Gf; Thu, 15 Aug 2024 00:40:10 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id BE5E3140A90; Thu, 15 Aug 2024 00:42:48 +0800 (CST) Received: from localhost (10.203.177.66) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 14 Aug 2024 17:42:48 +0100 Date: Wed, 14 Aug 2024 17:42:46 +0100 From: Jonathan Cameron To: Krzysztof Kozlowski Subject: Re: [PATCH 3/9] memory: samsung: exynos5422-dmc: use scoped device node handling to simplify error paths Message-ID: <20240814174246.00007e4e@Huawei.com> In-Reply-To: <20240812-cleanup-h-of-node-put-memory-v1-3-5065a8f361d2@linaro.org> References: <20240812-cleanup-h-of-node-put-memory-v1-0-5065a8f361d2@linaro.org> <20240812-cleanup-h-of-node-put-memory-v1-3-5065a8f361d2@linaro.org> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml100003.china.huawei.com (7.191.160.210) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240814_094256_064582_BD5630DD X-CRM114-Status: GOOD ( 19.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , linux-samsung-soc@vger.kernel.org, Maxime Coquelin , linux-pm@vger.kernel.org, Alexandre Torgue , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Claudiu Beznea , Thierry Reding , linux-arm-kernel@lists.infradead.org, Alim Akhtar , Santosh Shilimkar , linux-tegra@vger.kernel.org, Jonathan Hunter , linux-stm32@st-md-mailman.stormreply.com, Lukasz Luba Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 12 Aug 2024 15:33:57 +0200 Krzysztof Kozlowski wrote: > Obtain the device node reference with scoped/cleanup.h to reduce error > handling and make the code a bit simpler. > > Signed-off-by: Krzysztof Kozlowski Trivial comments inline Reviewed-by: Jonathan Cameron > --- > drivers/memory/samsung/exynos5422-dmc.c | 31 +++++++++++-------------------- > 1 file changed, 11 insertions(+), 20 deletions(-) > > diff --git a/drivers/memory/samsung/exynos5422-dmc.c b/drivers/memory/samsung/exynos5422-dmc.c > index da7ecd921c72..d3ae4d95a3ba 100644 > --- a/drivers/memory/samsung/exynos5422-dmc.c > +++ b/drivers/memory/samsung/exynos5422-dmc.c > @@ -4,6 +4,7 @@ > * Author: Lukasz Luba > */ > > +#include > #include > #include > #include > @@ -1176,10 +1177,10 @@ static int of_get_dram_timings(struct exynos5_dmc *dmc) > { > int ret = 0; > int idx; > - struct device_node *np_ddr; This would definitely benefit from a struct device *dev = dmc->dev; > u32 freq_mhz, clk_period_ps; > > - np_ddr = of_parse_phandle(dmc->dev->of_node, "device-handle", 0); > + struct device_node *np_ddr __free(device_node) = of_parse_phandle(dmc->dev->of_node, > + "device-handle", 0); Trivial. Maybe consider the wrap suggested in patch 1. > + struct device_node *np_ddr __free(device_node) = of_parse_phandle(dmc->dev->of_node, "device-handle", 0); > if (!np_ddr) { > dev_warn(dmc->dev, "could not find 'device-handle' in DT\n"); > return -EINVAL; > @@ -1187,39 +1188,31 @@ static int of_get_dram_timings(struct exynos5_dmc *dmc) > > dmc->timing_row = devm_kmalloc_array(dmc->dev, TIMING_COUNT, > sizeof(u32), GFP_KERNEL); > - if (!dmc->timing_row) { > - ret = -ENOMEM; > - goto put_node; > - } > + if (!dmc->timing_row) > + return -ENOMEM; > > dmc->timing_data = devm_kmalloc_array(dmc->dev, TIMING_COUNT, > sizeof(u32), GFP_KERNEL); > - if (!dmc->timing_data) { > - ret = -ENOMEM; > - goto put_node; > - } > + if (!dmc->timing_data) > + return -ENOMEM; > > dmc->timing_power = devm_kmalloc_array(dmc->dev, TIMING_COUNT, > sizeof(u32), GFP_KERNEL); > - if (!dmc->timing_power) { > - ret = -ENOMEM; > - goto put_node; > - } > + if (!dmc->timing_power) > + return -ENOMEM; > > dmc->timings = of_lpddr3_get_ddr_timings(np_ddr, dmc->dev, > DDR_TYPE_LPDDR3, > &dmc->timings_arr_size); > if (!dmc->timings) { > dev_warn(dmc->dev, "could not get timings from DT\n"); > - ret = -EINVAL; > - goto put_node; > + return -EINVAL; > } > > dmc->min_tck = of_lpddr3_get_min_tck(np_ddr, dmc->dev); > if (!dmc->min_tck) { > dev_warn(dmc->dev, "could not get tck from DT\n"); > - ret = -EINVAL; > - goto put_node; > + return -EINVAL; > } > > /* Sorted array of OPPs with frequency ascending */ > @@ -1239,8 +1232,6 @@ static int of_get_dram_timings(struct exynos5_dmc *dmc) > dmc->bypass_timing_data = dmc->timing_data[idx - 1]; > dmc->bypass_timing_power = dmc->timing_power[idx - 1]; > > -put_node: > - of_node_put(np_ddr); > return ret; > } > >