From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D87A5C3DA4A for ; Wed, 14 Aug 2024 16:52:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8Uv+vfkIJqnBPiZG0SOZP07+rjICrOkFqiAtycDRHA0=; b=iNyBSLfTrYnTHO ufCI4UlADtavE+lL73czUe/nrt4zp3EQU6/0Vq2XIxdjKg1yQif/zp2JhY3re6IFBbOvp5/DYZ02K 3Kt4HZntXIVKsfA0HyqV8VkO9Yi0iy0o6UGL2pTKf8p/DIUOrBOwGA/CUhXvN52OEH38F0KIjlr3w pfsDlabYoKFlvlkQP/sZmXWtcLZQHsHYVMg0ljrlNccQ5YV27PC7skNUAbKSS/7jICxN0XehtH6Q7 IJQE45rgy5AOHLKaCO5eNTqr+2+fTvwuSLjWe8KhjovODBcqE6ID56yRcRHNS+MBDytJtWIhdYJJw u+dCN7RJv4fZ67ZUMxkA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1seHEO-00000007jpx-1gji; Wed, 14 Aug 2024 16:52:16 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1seHD9-00000007jXQ-1T0r for linux-arm-kernel@lists.infradead.org; Wed, 14 Aug 2024 16:51:01 +0000 Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4WkZ1M1wM9z6K63G; Thu, 15 Aug 2024 00:47:35 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id D7167140A36; Thu, 15 Aug 2024 00:50:51 +0800 (CST) Received: from localhost (10.203.177.66) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 14 Aug 2024 17:50:51 +0100 Date: Wed, 14 Aug 2024 17:50:49 +0100 From: Jonathan Cameron To: Krzysztof Kozlowski Subject: Re: [PATCH 5/9] memory: tegra-mc: simplify with scoped for each OF child loop Message-ID: <20240814175049.00001821@Huawei.com> In-Reply-To: <20240812-cleanup-h-of-node-put-memory-v1-5-5065a8f361d2@linaro.org> References: <20240812-cleanup-h-of-node-put-memory-v1-0-5065a8f361d2@linaro.org> <20240812-cleanup-h-of-node-put-memory-v1-5-5065a8f361d2@linaro.org> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml100003.china.huawei.com (7.191.160.210) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240814_095059_707155_CF431DAE X-CRM114-Status: GOOD ( 15.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , linux-samsung-soc@vger.kernel.org, Maxime Coquelin , linux-pm@vger.kernel.org, Alexandre Torgue , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Claudiu Beznea , Thierry Reding , linux-arm-kernel@lists.infradead.org, Alim Akhtar , Santosh Shilimkar , linux-tegra@vger.kernel.org, Jonathan Hunter , linux-stm32@st-md-mailman.stormreply.com, Lukasz Luba Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 12 Aug 2024 15:33:59 +0200 Krzysztof Kozlowski wrote: > Use scoped for_each_child_of_node_scoped() when iterating over device > nodes to make code a bit simpler. > > Signed-off-by: Krzysztof Kozlowski The final block is already a weird code structure, but your changes look fine to me. Reviewed-by: Jonathan Cameron > --- > drivers/memory/tegra/mc.c | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/drivers/memory/tegra/mc.c b/drivers/memory/tegra/mc.c > index 224b488794e5..bd5b58f1fd42 100644 > --- a/drivers/memory/tegra/mc.c > +++ b/drivers/memory/tegra/mc.c > @@ -450,7 +450,6 @@ static int load_one_timing(struct tegra_mc *mc, > > static int load_timings(struct tegra_mc *mc, struct device_node *node) > { > - struct device_node *child; > struct tegra_mc_timing *timing; > int child_count = of_get_child_count(node); > int i = 0, err; > @@ -462,14 +461,12 @@ static int load_timings(struct tegra_mc *mc, struct device_node *node) > > mc->num_timings = child_count; > > - for_each_child_of_node(node, child) { > + for_each_child_of_node_scoped(node, child) { > timing = &mc->timings[i++]; > > err = load_one_timing(mc, timing, child); > - if (err) { > - of_node_put(child); > + if (err) > return err; > - } > } > > return 0; > @@ -477,7 +474,6 @@ static int load_timings(struct tegra_mc *mc, struct device_node *node) > > static int tegra_mc_setup_timings(struct tegra_mc *mc) > { > - struct device_node *node; > u32 ram_code, node_ram_code; > int err; > > @@ -485,14 +481,13 @@ static int tegra_mc_setup_timings(struct tegra_mc *mc) > > mc->num_timings = 0; > > - for_each_child_of_node(mc->dev->of_node, node) { > + for_each_child_of_node_scoped(mc->dev->of_node, node) { > err = of_property_read_u32(node, "nvidia,ram-code", > &node_ram_code); > if (err || (node_ram_code != ram_code)) > continue; > > err = load_timings(mc, node); > - of_node_put(node); > if (err) > return err; > break; >