From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19FCDC3DA4A for ; Wed, 14 Aug 2024 16:56:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MYINwosBDOpryR85aTcH8IIzjm+e26Jtz/rPAhQZMe4=; b=Mskb+D4vqA1QS3 eNudQPmG4xQwS0aHxAzZ7g8fIzl//BPdCQxfm0KCJd/GPCfXre7THyYx7UoCPm2Oc4GJLadeiQqbJ ua4jxZtJmkLlhq5lDvA6v/fs57EqByaZtxg7JIrtPJfPqJvRk4ukwE29OsKYWe0Z9JqEZQa7/wdOe hHGmC+hlEjaWY+r7yNeLzvNOpe1w+ACkcwCmA9fIh98AkeUQq6RiwPJBAph60kr/heePNb1/YQwlo hQTUMYafrg5dcMXYNITma1EQyDNLnBqJ+IQFPzmxJvhTFBRPaGNRImpBYf0R2C80kz44PvGebIUFN wqGFx7tP+5rQSqJN3i5g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1seHIU-00000007kVl-3mdq; Wed, 14 Aug 2024 16:56:30 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1seHHq-00000007kQu-3Y0z for linux-arm-kernel@lists.infradead.org; Wed, 14 Aug 2024 16:55:52 +0000 Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4WkZ7h5yf1z6K9Jv; Thu, 15 Aug 2024 00:53:04 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 7930B1400CD; Thu, 15 Aug 2024 00:55:43 +0800 (CST) Received: from localhost (10.203.177.66) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 14 Aug 2024 17:55:42 +0100 Date: Wed, 14 Aug 2024 17:55:41 +0100 From: Jonathan Cameron To: Krzysztof Kozlowski Subject: Re: [PATCH 9/9] memory: ti-aemif: simplify with scoped for each OF child loop Message-ID: <20240814175541.00002023@Huawei.com> In-Reply-To: <20240812-cleanup-h-of-node-put-memory-v1-9-5065a8f361d2@linaro.org> References: <20240812-cleanup-h-of-node-put-memory-v1-0-5065a8f361d2@linaro.org> <20240812-cleanup-h-of-node-put-memory-v1-9-5065a8f361d2@linaro.org> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml100003.china.huawei.com (7.191.160.210) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240814_095551_211405_1D1224CF X-CRM114-Status: GOOD ( 21.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , linux-samsung-soc@vger.kernel.org, Maxime Coquelin , linux-pm@vger.kernel.org, Alexandre Torgue , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Claudiu Beznea , Thierry Reding , linux-arm-kernel@lists.infradead.org, Alim Akhtar , Santosh Shilimkar , linux-tegra@vger.kernel.org, Jonathan Hunter , linux-stm32@st-md-mailman.stormreply.com, Lukasz Luba Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 12 Aug 2024 15:34:03 +0200 Krzysztof Kozlowski wrote: > Use scoped for_each_available_child_of_node_scoped() when iterating over > device nodes to make code a bit simpler. > > Signed-off-by: Krzysztof Kozlowski Nothing wrong with this patch, but I think you can add a precusor that will make this neater. Jonathan > --- > drivers/memory/ti-aemif.c | 13 ++++--------- > 1 file changed, 4 insertions(+), 9 deletions(-) > > diff --git a/drivers/memory/ti-aemif.c b/drivers/memory/ti-aemif.c > index e192db9e0e4b..cd2945d4ec18 100644 > --- a/drivers/memory/ti-aemif.c > +++ b/drivers/memory/ti-aemif.c > @@ -330,7 +330,6 @@ static int aemif_probe(struct platform_device *pdev) > int ret = -ENODEV; > struct device *dev = &pdev->dev; > struct device_node *np = dev->of_node; > - struct device_node *child_np; > struct aemif_device *aemif; > struct aemif_platform_data *pdata; > struct of_dev_auxdata *dev_lookup; > @@ -374,12 +373,10 @@ static int aemif_probe(struct platform_device *pdev) > * functions iterate over these nodes and update the cs data > * array. > */ > - for_each_available_child_of_node(np, child_np) { > + for_each_available_child_of_node_scoped(np, child_np) { > ret = of_aemif_parse_abus_config(pdev, child_np); > - if (ret < 0) { > - of_node_put(child_np); > + if (ret < 0) > goto error; I'd precede this patch with use of devm_clk_get_enabled() That would avoid what looks like potential mixed devm and not issues and let you return here. > - } > } > } else if (pdata && pdata->num_abus_data > 0) { > for (i = 0; i < pdata->num_abus_data; i++, aemif->num_cs++) { > @@ -402,13 +399,11 @@ static int aemif_probe(struct platform_device *pdev) > * child will be probed after the AEMIF timing parameters are set. > */ > if (np) { > - for_each_available_child_of_node(np, child_np) { > + for_each_available_child_of_node_scoped(np, child_np) { > ret = of_platform_populate(child_np, NULL, > dev_lookup, dev); > - if (ret < 0) { > - of_node_put(child_np); > + if (ret < 0) > goto error; > - } > } > } else if (pdata) { > for (i = 0; i < pdata->num_sub_devices; i++) { >