From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 43A88C52D7F for ; Wed, 14 Aug 2024 22:03:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To: Content-Type:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MGddz5WzOh9QEH86TpYJTPHODLpBXajraZr4nTi3DBI=; b=Tjt+4qkof9HqzwSWxoIeThNQf1 U0CjYiwZNDoI0VjJxeSBPNLmnIhoGBb2GTB23VNnKenQPAdpYvXq+KwTtcO/V6ber7V1UdSaWSTpu nTLX/Lux54CtWa3VrbuHHBx/Xl5jy11RTxrLjbeToveZjyjlE2/hZfr+lj4gS3DKapN/l1mPb6//2 7PXrv7aFmvd5GRDdMokzmQNHWHTyfQe0XrgXrYk8/dYEdCMNveuC+AQH0DHMzTnQXG+mLF3ww6KnV D0+mEAH8UsbpRCqOD98VPcAG3yYHzKGAPSVpIaU7wixrYiWg6j92BVC78+wHAnJQRgXHZDn/hcy9l ZcdGqTKA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1seM5K-00000008OWE-3KjJ; Wed, 14 Aug 2024 22:03:14 +0000 Received: from mail-mw2nam12on20625.outbound.protection.outlook.com ([2a01:111:f403:200a::625] helo=NAM12-MW2-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1seM4e-00000008OOp-2IoY for linux-arm-kernel@lists.infradead.org; Wed, 14 Aug 2024 22:02:36 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FMIjnR5GX1v1nBMPSK1y6CcwprV4b9e2BqF7dXYl5rhH3YJnSOiy/Q8T+Jvgsk5jiVr0d/oCxR0hAX55TxlGoulecNo7qaewb1FB3dN/L0BS/8ufRiIpxTFgDG6vIlt8tEnYr/67ioGfpMrhKcXL/oXKXJX7ngRxvBnXhrXaQIOAM5yLMFd3Gzy3v8rqv/OVo+/0s0eywYZ2GiUB6lRDyrYMZR+zeZp2eITMEIJ4aU/iRQwJVrJlmqzz4bEC/REtL7QD8eyCxZIPleE33Dd4/bXrDB8iETYvPFiZMBgH+aq2w/uM5uDGYjHoDGZFhr2EnLYVrOHSOS4s6J3z5cKOlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MGddz5WzOh9QEH86TpYJTPHODLpBXajraZr4nTi3DBI=; b=aDPRhdE+gW1XVebqViEDPJe5fb/mpVijvZyJ8onpxVGSHm/7JK1bV8XziZX1iebsINqjVTj6DAet7ASYHD+B1gqAEVb5ivUkvc9HnnhzPPe4B0KogdPuh0rchcgjZcGxlMe6z6G6O/t0HojcnZHtepYPGdadp5jYKUq9rOGtYsLGP1kRDH6b+t6BJxOTY+T+FmzV2fSzJ/NNQtSm978S/1TzBfwEAORGnGfN68wHlFFB3/DSMHig7xaRrA9lSr4j2Khnnhz1f9U2oczKlSayT0J94AUBp++w5yPtrp2b0PuEUYt9aIar3BK8Fe/WgL/ZBp5O40Fefi2Fxj+sxwcy3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MGddz5WzOh9QEH86TpYJTPHODLpBXajraZr4nTi3DBI=; b=ZqMkm04BtBVs8WK8MXZkhdmAYkPZqbY/g4SNzYAUuupyEs9lNfLJ+SECcksaWr2yIER0LwEr0NOtcDIoXyOxv3Zu/OpldMKqMiVpTrX7BKOJSHy6/ti9n/QGsUtxi/QXAZKaH1U8DkKfW5FZzyOvBgOGCyo4ehiht+KbK7xGEODeblpjrM/2IPvCJC8DLQjs5q52d0bdcu6d3VmCqZVOG7VlwU4LShCK+JtJxzp01WBlkyHwHQtKZeQdbifh/G79QxX6iQSU2Q+gdK3HAlN0m8ujXlWmIm59xvDqEmckJQLGiOJ9KpJO+lvEC64hWiWnpSSAcgHsnCwO3tGje4fLIQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DM4PR12MB7767.namprd12.prod.outlook.com (2603:10b6:8:100::16) by CH3PR12MB7594.namprd12.prod.outlook.com (2603:10b6:610:140::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.22; Wed, 14 Aug 2024 22:02:23 +0000 Received: from DM4PR12MB7767.namprd12.prod.outlook.com ([fe80::55c8:54a0:23b5:3e52]) by DM4PR12MB7767.namprd12.prod.outlook.com ([fe80::55c8:54a0:23b5:3e52%3]) with mapi id 15.20.7849.021; Wed, 14 Aug 2024 22:02:23 +0000 Date: Wed, 14 Aug 2024 19:02:21 -0300 From: Jason Gunthorpe To: Nicolin Chen Cc: kevin.tian@intel.com, will@kernel.org, joro@8bytes.org, suravee.suthikulpanit@amd.com, robin.murphy@arm.com, dwmw2@infradead.org, baolu.lu@linux.intel.com, shuah@kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v1 05/16] iommufd/viommu: Add IOMMU_VIOMMU_SET/UNSET_VDEV_ID ioctl Message-ID: <20240814220221.GZ2032816@nvidia.com> References: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: MN0P222CA0019.NAMP222.PROD.OUTLOOK.COM (2603:10b6:208:531::25) To DM4PR12MB7767.namprd12.prod.outlook.com (2603:10b6:8:100::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR12MB7767:EE_|CH3PR12MB7594:EE_ X-MS-Office365-Filtering-Correlation-Id: 58b4c981-cf75-4677-6a08-08dcbcacc69b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|376014|1800799024; X-Microsoft-Antispam-Message-Info: PSuWzYCqWMv4Sz/+cJeChU1aPhuBACE5dsMXDuzJ3xUaGklpQir9EjEUFG1JRneU8jOJzR9HLNOXNkbbwmu/FxLh+1V2QW81dur7k/RfjzebFWTfApW5QJOUrCpTrhh9oIlXljFUeMUmbVvIg78vPboWVaUjTj0GxGoEMxSSsx1qJVMND8fD50t/okRZHA45mtrc4ontfEJBCSdwx5EbmfopaYk9IuQfwOwnLKMubPD6nKCPZ9KdWbDCgRKbB9WLQntFUeGAj706M5AnmD6ktUhTBPDh+egtpx8HkmplfW2ML6VoHP5bPWXwW3+X781zdyfmjaWOe4FWW7oPnNM8vNvUTWa7nGkdBbEzgbxExmsazqmcER8tDDFsLao8cl16p/RXiSFb/VlgQpGE/0WbBDC29RSqN+vo5egzrLONB+80emyU4ZJsqRr49Kfjep5BtuDABAyUAXZke5Fef43DqokvZKG3qrXKjexOnAHfKC5VLe+u2ZodnV+U8jbnX5ep9b00xbeH4fy4qHn5YdWBPPyJYTVGKjtpa/GbqQ64p41TPi2IwJb/Zk63y5P2Yo3Tdku3RwSxuzUQPKvTuO/jSDS9BiLgIbthy8nhdCwIiDbhCiEGMc3ECyJIQqlPk4IKeD9H2/32kORzGzma7nu1yGL0RexCvV+V5EPbqmPBx+Q= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB7767.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(376014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?SEiWds3PYSXyYCKOK016wNBqDdbWGV+H7tBXIwKqyyhOZl65CIJ6FUV7UUXD?= =?us-ascii?Q?fJMkdwuAp5OWpRvkP11phQgpPSOYLwUBQqWKznvDTb+O9WQ+Dnn4YtpvkLZa?= =?us-ascii?Q?iF9uq+UJDJyYkm5fDTkB4vHcmPPkp7pFI7OLr1z0QoScMTLBpNQpchKI8RjN?= =?us-ascii?Q?MyHpA79cFjANaizqrwfG7G/ml/4+cXRmpLs1N5MFHnkB/NiLMPk6LeSyQu9B?= =?us-ascii?Q?+xYVbhtefzayFLcF5ApkHNR2Z61EH4Y92jmH0/Pluo0hlnOZPjgu9p2krSZZ?= =?us-ascii?Q?4Xtb/qElOwxP6gm337OjdSpcAeCA5f9N5pGnKaKPXJxOE+vQf2VGVj7NG8n1?= =?us-ascii?Q?dxDEUvtNREnYXMsQuKuYPgpTyO4yI0j/fJsY94pz62Ps7f6qySX0FEYJ0kYT?= =?us-ascii?Q?NDe/IN59HXclqdPw/hyRxboeFGBp3gOGyNZXpuLbO3D4NoF5QiOggg9uBPmH?= =?us-ascii?Q?0uf35RUESiVzsAUwuRyR/vy3IDI+7K2PBQVrfZcjRKJRCfENMa9MoRPa/tXo?= =?us-ascii?Q?x1HF9WdYYXeqrkNQ7TleQWAAKNEqX0VLZCOKsC7iJTlSphxeFltg4H5fh35o?= =?us-ascii?Q?WRfsRnSglrdQHpvmgBH3rQLSVPIGmtm+Uu4wfXVj9DYsa8VbuT7OdGujKxlA?= =?us-ascii?Q?KdUZhj29isdU6pHeRmd7X+M1+cIFaO4Gmn5h19hee0IiqwtmgVXmELCTTrLe?= =?us-ascii?Q?4a7bFQF3MH4JsZRJQ412ILsoW+fg9bZY2LG3WmLj7JaSpt0gzZhkAPtocb3j?= =?us-ascii?Q?GdsYFLEa4NIj+hzcBgoL4z2+S9E6Co7KD9g8QlY0Lbcyfk7V8ir9tEgWzC58?= =?us-ascii?Q?M8W2eLU4AmoKDvgGl87nvaeyb8dMNXGVT6IejPxo/JbZ+FFYirNqmLt5SQg9?= =?us-ascii?Q?GnO026bqN+ED1+P5IBuD0PBw/ir6AspEDybjAM3arHLSmzdjCSdjvgd15uPM?= =?us-ascii?Q?IcRei9crRTGJjiF9hf/xeEp2YRIV5zoKz8E1UfTmQMLikrWc0DawkMHmM8q3?= =?us-ascii?Q?5YPBVsNZB95UDzwyPdhntnVtTSzqI0L+Mn+ja0D1OlCj6UXbYT3SsTEPuAFK?= =?us-ascii?Q?YuFdrr8PE36aZuQluMkultaNon5nPX1NdM6dSocoHnfJiCSH9FE3CO7RiV5Y?= =?us-ascii?Q?+BYza9CHoO3g0pgPPRH/+MfTsO+o7v+LCjow8On8+vTWD6pv/3QvDQrBxIHr?= =?us-ascii?Q?JCfGslsx0QfKBeGVAVgEkSHls/7iLS7Rw4kc8hu7nGW6ZCRq3v6/49H7crj9?= =?us-ascii?Q?JQx2C3LSIN/Ep9lkvDwP81LaEqs0n6r7+BI283ZEDlqvSHZlG0hyj8KUU3PH?= =?us-ascii?Q?rXYd1FbwO7O9+gaHV+BcJARt3vfj9mhg+RDRT1RWvST7MnUuvwWyDEp+vC/e?= =?us-ascii?Q?gWBgO3hRlCSg2/qasCJabaTaeXeNnEy/n4ZfBtaomnJLH8EWZth/XjhqJJ0K?= =?us-ascii?Q?tWxJ8oQmEhsYbwEv7vO3kTD0BqRsux0bsBcoK/fR3sormOQ7E5TG9LG1dWNS?= =?us-ascii?Q?f/rBB7OOMxNgmTW1aeWRsQckl9UXjViB7zDrkzBP7gtuRrhp6sUlhwtvqO3h?= =?us-ascii?Q?8HEx+kow/mRg5/fkLrY=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 58b4c981-cf75-4677-6a08-08dcbcacc69b X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB7767.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2024 22:02:23.3892 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: s/Ci0KRnX4zWPhpovg5MJzCOw+V/9PVnGDhmMBGFKnjpq0ev3jhxJGO2coz+qhXB X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7594 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240814_150232_612302_75790A86 X-CRM114-Status: UNSURE ( 7.76 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 14, 2024 at 10:09:22AM -0700, Nicolin Chen wrote: > This helps us to build a device-based virq report function: > +void iommufd_device_report_virq(struct device *dev, unsigned int data_type, > + void *data_ptr, size_t data_len); > > I built a link from device to viommu reusing Baolu's work: > struct device -> struct iommu_group -> struct iommu_attach_handle > -> struct iommufd_attach_handle -> struct iommufd_device (idev) > -> struct iommufd_vdev_id (idev->vdev_id) That makes sense, the vdev id would be 1:1 with the struct device, and the iommufd_device is also supposed to be 1:1 with the struct device. Jason