From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 10E75C3DA7F for ; Thu, 15 Aug 2024 07:34:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mSVgOh4W3trTwpBrRTkuN1lvc7J54SJDhoOOLbBw+iU=; b=VwjtMEU7eV1NSdR3sY6lb54oNO X/DWg5RgJAuZpXn2G5Ltfum1r7RC0HPx91bz8FiM7U110AXElCa/wbfbM/BCYadBe5v60Y9xHJGTe kz0p5Fz4zA8d8dkHuaRb2zQZuZp5WGQ1LVPpaMFbhMJW/ZF+uS4MpL7x3f/co+AFrL0crhE7Gqt/v SLMJfxVXT2oqpNU2jG66B2nNVojQ2NYdtKWO2q93lmhe/kdhmTxsyVXRqrQtXyk+Db43BB/Epne2x 6HRT/qdjDU30QObCUwK5KgppwRUybmT4wGWQf3/jH/WEqjcMmvhbnAcZaZi6dRSF8XWltN6Hh2Fm7 fXj6f0YQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1seV06-00000009ILx-1ULe; Thu, 15 Aug 2024 07:34:26 +0000 Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1seUz2-00000009I9j-0669 for linux-arm-kernel@lists.infradead.org; Thu, 15 Aug 2024 07:33:21 +0000 Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-712603f7ba5so497730b3a.3 for ; Thu, 15 Aug 2024 00:33:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1723707199; x=1724311999; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=mSVgOh4W3trTwpBrRTkuN1lvc7J54SJDhoOOLbBw+iU=; b=CSk51inl+TMzAUoOhBeB3GjTzdsfx/zgGznejy3TmcQoUkZds15Bhtf9n17FrDzq+e uS8QVFurmcft84EzFAeCOXdfR8gBS2YErUILjK/kLqWPxMX9xR5KQsyc1tD5UAiKh6tU k6QkxFhBLeIg0nFFkvW+KD6gOHtkvCHdVXqKU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723707199; x=1724311999; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mSVgOh4W3trTwpBrRTkuN1lvc7J54SJDhoOOLbBw+iU=; b=UStjWkKLaWeaskVzvWxAjwcCO/Od9N+Sf7RGCqkughJ8wMiNZt6VswB66tx7ITcaYe HlCFHGIUhqPCWvwXepwucsE62HXkIibGuvKMzBiH2fowGNO6GV2Cl4LhvYnkogELM0fX M8pWekHWSRVW7CYl4fbgMlcl93KzRmnCuq+kPNxX7GvFNXhnB37jTQF/MRVZNXVJB824 e+5u1nNeVEKieMYJdFeuPloWl+oOinfu2AU4qaAQ8sigwwdCX6jHG4OsNL/Bom1lrqSE 0BBjB9wRgJGaIUxFuqiYWcIU0brK1zEkbTab3mIe6pkLdE3GkZUt2ANmnt5dbcp9iR5l q7Qw== X-Forwarded-Encrypted: i=1; AJvYcCUKG+fRCRutaFWAZL2Lu+kGfBWmCz/xScdznVhlyeZQbZ8n8ZMiSjgEM1MQ2OSAwY3otBoO3mhVZU5eWTQGSiU+5bxh1y2NJU2JBBxaGMEcucOuaPE= X-Gm-Message-State: AOJu0Yy9PZ2IthClx7l7b+ud0v+ElrDfV2lQZkhlvKihXpN8psbO2Jza 9K02/QAfiBBVB3W1GjnL5jSC/p/IcCy7vZQ0XyTIjJ47M9IUexARFuWPS+QVhg== X-Google-Smtp-Source: AGHT+IE+v6e+Df7tQx88UbXmfy+wlQroZUtqBIcjWsCC3V2G6r5uCEDNzWqCeTXlE1H5mKvT4LnM9w== X-Received: by 2002:a05:6a00:1394:b0:705:a13b:e740 with SMTP id d2e1a72fcca58-712673abaf0mr5999238b3a.19.1723707199046; Thu, 15 Aug 2024 00:33:19 -0700 (PDT) Received: from google.com ([2401:fa00:1:10:745d:58f7:b3cd:901f]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7127aef544csm563951b3a.121.2024.08.15.00.33.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Aug 2024 00:33:18 -0700 (PDT) Date: Thu, 15 Aug 2024 15:33:14 +0800 From: Chen-Yu Tsai To: Krzysztof Kozlowski Cc: "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Amit Kucheria , Thara Gopinath , Thierry Reding , Jonathan Hunter , Vasily Khoruzhick , Yangtao Li , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH 7/7] thermal: sun8i: Use scoped device node handling to simplify error paths Message-ID: <20240815073314.GG350960@google.com> References: <20240814-b4-cleanup-h-of-node-put-thermal-v1-0-7a1381e1627e@linaro.org> <20240814-b4-cleanup-h-of-node-put-thermal-v1-7-7a1381e1627e@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240814-b4-cleanup-h-of-node-put-thermal-v1-7-7a1381e1627e@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240815_003320_087382_7B4BB33A X-CRM114-Status: GOOD ( 22.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 14, 2024 at 10:17:53PM +0200, Krzysztof Kozlowski wrote: > Obtain the device node reference with scoped/cleanup.h to reduce error > handling and make the code a bit simpler. > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Chen-Yu Tsai > --- > drivers/thermal/sun8i_thermal.c | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/drivers/thermal/sun8i_thermal.c b/drivers/thermal/sun8i_thermal.c > index 3203d8bd13a8..22674790629a 100644 > --- a/drivers/thermal/sun8i_thermal.c > +++ b/drivers/thermal/sun8i_thermal.c > @@ -9,6 +9,7 @@ > */ > > #include > +#include > #include > #include > #include > @@ -348,19 +349,18 @@ static void sun8i_ths_reset_control_assert(void *data) > > static struct regmap *sun8i_ths_get_sram_regmap(struct device_node *node) > { > - struct device_node *sram_node; > struct platform_device *sram_pdev; > struct regmap *regmap = NULL; > > - sram_node = of_parse_phandle(node, "allwinner,sram", 0); > + struct device_node *sram_node __free(device_node) = > + of_parse_phandle(node, "allwinner,sram", 0); > if (!sram_node) > return ERR_PTR(-ENODEV); > > sram_pdev = of_find_device_by_node(sram_node); > if (!sram_pdev) { > /* platform device might not be probed yet */ > - regmap = ERR_PTR(-EPROBE_DEFER); > - goto out_put_node; > + return ERR_PTR(-EPROBE_DEFER); > } > > /* If no regmap is found then the other device driver is at fault */ > @@ -369,8 +369,7 @@ static struct regmap *sun8i_ths_get_sram_regmap(struct device_node *node) > regmap = ERR_PTR(-EINVAL); > > platform_device_put(sram_pdev); > -out_put_node: > - of_node_put(sram_node); > + > return regmap; > } > > > -- > 2.43.0 >