From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA2C2C3DA7F for ; Thu, 15 Aug 2024 14:59:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AY0JVErQjbDOjRclIoTbgk1nSRnobtGYIBgnoIJxDb0=; b=Sq1djhi/keJfLdx5s/NN6VouJ8 HdJWRDd+FHMtiUjmam7BPVj/6w8Qq8KL1jVMYrTH4+cFLtnTNrsTAh5F8T5+PBwi2/JJ/iO5WTcwm V8qZX3NYYPJFPOuvYCvKcr6Q7n/nkV7bNvO8/akhhVqyXonlsAcPRKJaDzJRW7O5urcyh89U95tgM NUn0qLQT/wX3LvASxBDorYuV8hzV6mRsluPZ1B7s88q4fCbAU3pRMDfjNSduC25A9rHg4vvj+EomW V3TkAO6PlyAqX8wuD7U/lqW3kKIFEUX4K66jl+nFUR8JYPfnBgcF5dnqZ1nRS1c+onlRKem/DtTjV RrD3PveQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sebwi-0000000AI1p-1CG4; Thu, 15 Aug 2024 14:59:24 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sebw5-0000000AHre-2sKW for linux-arm-kernel@bombadil.infradead.org; Thu, 15 Aug 2024 14:58:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=AY0JVErQjbDOjRclIoTbgk1nSRnobtGYIBgnoIJxDb0=; b=mFW4ertd28wNaM1ib4c7GyX2K6 5JFITuGD5pQlWQqkcPJqKimSLfsE1sVm5UQOtylqw5EwQKe5QobQWSCTL137jn5SuKcpEs7au5Y6T HNTRBsg1H4fzd3y079hmFg1LzPJsmFIawWBKoF2xjnN13Qs6v93Z9ayk+C+hDuI1LqlFnFPoOQcv7 jMvQXgy36cJqTQR+gCvdahgee469huP+Kf2dESuv+nWgqtzSuo11rOJhIatUv5sPFDjKqvn4NOcZP mO2c/RyjqiIRtqrhP18Sjhvv8zFF+5Xdzln/o8EZ7MbUMuCU2x/FKbk6hlYiK4VNIKVr2LOaZqaep OS1f0MfA==; Received: from dfw.source.kernel.org ([139.178.84.217]) by desiato.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sebw0-00000008Obc-3JWB for linux-arm-kernel@lists.infradead.org; Thu, 15 Aug 2024 14:58:44 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id A62C561ED7; Thu, 15 Aug 2024 14:58:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E5FFFC32786; Thu, 15 Aug 2024 14:58:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723733917; bh=zct74IZ/bRfrRYww4OS483OWKGYhQysxlcXnalLdh08=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=P4hMKKtqUdU6IygTaoWO/OQiSF+VvvCgV+lYuCLORHOHp4XOfeYBiPuDTkFv8+7ui wxbdKFvvjtKHcznCIVpzEASsxjIUyH/PI/tWYyh6n1JrmXUSCNX+EHXE4c1M1B7Jyf yfUvP67oryx2XvkZsUHi70e73MtkVkyMeoGhJhQ1e4dGaWHkf5kNsfraTERC13QTVB spYOBoX/A5shE0ika8w0hgAb+77BVYscRps6utB/7B+9/q5ymQzi7JP+qtYCvsN5+Y YsXsLBZtlrY7nDvqhulajR3Dmg3uzxIYzK9owY8qjfFo0wGSl7TqEG5PRa3kMN4P3C KdYg37kryE8iw== Date: Thu, 15 Aug 2024 15:58:32 +0100 From: Simon Horman To: Sean Anderson Cc: Radhey Shyam Pandey , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Lunn , Michal Simek , Daniel Borkmann , Paolo Abeni , "David S . Miller" , Eric Dumazet , linux-arm-kernel@lists.infradead.org, Jakub Kicinski , Ariane Keller Subject: Re: [PATCH net-next 1/4] net: xilinx: axienet: Always disable promiscuous mode Message-ID: <20240815145832.GG632411@kernel.org> References: <20240812200437.3581990-1-sean.anderson@linux.dev> <20240812200437.3581990-2-sean.anderson@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240812200437.3581990-2-sean.anderson@linux.dev> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240815_155841_051970_92CA5E2C X-CRM114-Status: GOOD ( 19.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 12, 2024 at 04:04:34PM -0400, Sean Anderson wrote: > If prmiscuous mode is disabled when there are fewer than four multicast > addresses, then it will to be reflected in the hardware. Fix this by > always clearing the promiscuous mode flag even when we program multicast > addresses. > > Fixes: 8a3b7a252dca ("drivers/net/ethernet/xilinx: added Xilinx AXI Ethernet driver") > Signed-off-by: Sean Anderson > --- > > drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c > index ca04c298daa2..e664611c29cf 100644 > --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c > +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c > @@ -451,6 +451,10 @@ static void axienet_set_multicast_list(struct net_device *ndev) > } else if (!netdev_mc_empty(ndev)) { > struct netdev_hw_addr *ha; > > + reg = axienet_ior(lp, XAE_FMI_OFFSET); > + reg &= ~XAE_FMI_PM_MASK; > + axienet_iow(lp, XAE_FMI_OFFSET, reg); > + Hi Sean, I notice that this replicates code in another part of this function. And that is then factored out into common code as part of the last patch of this series. I guess that it is in the wash, but perhaps it would be nicer to factor out the common promisc mode setting code as part of this patch. Otherwise, this LGTM. > i = 0; > netdev_for_each_mc_addr(ha, ndev) { > if (i >= XAE_MULTICAST_CAM_TABLE_NUM) > -- > 2.35.1.1320.gc452695387.dirty > >