From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4FFC2C3DA7F for ; Thu, 15 Aug 2024 15:00:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=axzV84sTOBkMFNDA65/4Hd30T4z6HqkNfAMeRg+7hM4=; b=xCFwbrpOqN+7siFKA6GxhjHCID Xpt4Q/rBjPxBV5M21r051hJYvKy3oywbYOxJTxh5SquWUfZ0t9rhBMzbEJU9vGCABgk4EtKANl4Sz QRbAFVKMm7ruwYygKjrsZlnUelMMmXGYEJ9MXQJq1il9nxkznfevkUu48Lvp1RfNyjj/xqhlwJUMF 923pXzkAS19Av8xZex0Xjs8GM4tuJ18bukYihT9vdJgKJcfKMKLo8+SiNi+oG+y6pUkTFWey7dyzv s1YAExBXsysvKO3xmyyfVi7Dbrq13EqYvhE0Tyydnxp+3KpqOkoJI2VlIDoNrsn95oKYgFIUVzMSO QTgszmxw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sebxu-0000000AIOt-287Q; Thu, 15 Aug 2024 15:00:38 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sebxC-0000000AIBJ-2xea for linux-arm-kernel@lists.infradead.org; Thu, 15 Aug 2024 14:59:57 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 692EA61961; Thu, 15 Aug 2024 14:59:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7DCDBC4AF0C; Thu, 15 Aug 2024 14:59:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723733993; bh=axzV84sTOBkMFNDA65/4Hd30T4z6HqkNfAMeRg+7hM4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aXZnrDfzqgsn/8IHUcrZLsOI4rbooDnR4oDfk0CD8qVga++mO4CDNPx1At8FOGeIa 6eTCTZhY50nvyAcPpGLVbSSdtz8LveTL5q25XuvR9tDu98h7DErok/+Vw+rwx9cAS8 GVusfbioZ02oBUcMtGCjMUOycB97LRkypc9qcrPM0isykvtqt/R1KQ91zpq04ubR8z 7vbYh+eCrznxolX/NPqXONXYcz7MIq9r60w7jQIL9W4Lo2fYohJhsXkNv9CcK/QG0j 5zzU7Zh+hz2Q1ZIMQkC75M7tQHSfNwnl+4GtZFklgmYBjQA8AjqPAWq+OKaVQ20n5w yRn6Xgwvabs3A== Date: Thu, 15 Aug 2024 15:59:48 +0100 From: Simon Horman To: Sean Anderson Cc: Radhey Shyam Pandey , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Lunn , Michal Simek , Daniel Borkmann , Paolo Abeni , "David S. Miller" , Eric Dumazet , linux-arm-kernel@lists.infradead.org, Jakub Kicinski , Ariane Keller Subject: Re: [PATCH net-next 3/4] net: xilinx: axienet: Don't print if we go into promiscuous mode Message-ID: <20240815145948.GH632411@kernel.org> References: <20240812200437.3581990-1-sean.anderson@linux.dev> <20240812200437.3581990-4-sean.anderson@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240812200437.3581990-4-sean.anderson@linux.dev> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240815_075954_847271_F44DEDC6 X-CRM114-Status: GOOD ( 10.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 12, 2024 at 04:04:36PM -0400, Sean Anderson wrote: > A message about being in promiscuous mode is printed every time each > additional multicast address beyond four is added. Suppress this message > like is done in other drivers. And don't set IFF_PROMISC in ndev->flags; > contrary to the comment we don't have to inform the net subsystem. Hi Sean, FWIIW, this feels like two things that could be two patches. ...