From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86AFFC3DA7F for ; Thu, 15 Aug 2024 15:03:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3UZRK/nqTaiB52qi2QQ+YKcAbXWytn0Xrrio/MEr0JI=; b=yJ9DA8xV8SmEU5kDjPFnG2rAYj BmmMUSMd1qnZ1SivSIJNCTq+UVKmGNmTCrnnnwvkV9Jiymb7r1vJ+Mbf6KGcdCUZBrruIAW9Of5jD 9ii2yGR1f+a3GJt3UKn+qExKaGFfHTg/WI5wf9pDRcz1/HPmZJul8mH08dXT3Cnyn+uaQOmqFbdD/ LthMcAkjAloHNhADz7fFfNYbfsu10miiXTywQaRiWJdgmKl4SzcVJGM2ZBhexsb8Vs1yKNgL7PoEO TfsXbwbH7PE33HmZXPC7IiTnQvUeyw+y4EJqFdbFi3d/h3Ebh8izRmW3dgB8/0NH7XgK5yvJIOkHu IV/RMXXg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sec0L-0000000AIyE-03fu; Thu, 15 Aug 2024 15:03:09 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sebzb-0000000AIoU-3ny8 for linux-arm-kernel@lists.infradead.org; Thu, 15 Aug 2024 15:02:29 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 4F30761ED6; Thu, 15 Aug 2024 15:02:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7AFDFC32786; Thu, 15 Aug 2024 15:02:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723734143; bh=rRi+6EmOs7+pVG1EHAvt51XP2hQn0UWhMGz5gSVJY24=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BoHC+pD6oPocFglcJdtHSimP1f3hS2iNbMAN4Fp4aTg4UBQdiyg7VE99+0IzEtN5R 5jiiIKs+pVdzrvYL5LaAgwcJSi4+8jf8eC5zkk0Y9r4Qph8JpoNf6RyGV2YCyYcevV ZJsTQxKACkyHks19UcEOOU4TWfygXXYsQ0Lh3X//SKhx3KRfh1iq8b7l378Ekzv+YZ oWRzJ/trg3FzanoJz7NQL7Gd5V1PPFLrFfh0rbB+C7AjsuXQO7Czke1Y7Sw2Z6HOub 9UVEA3bEEfv5Tm5aGebkx/ChHD00ssmCdB46Lvt8u0bFA1EMJNQsRsNGfJz+Ng6iVr RnVj6CDw2OD5A== Date: Thu, 15 Aug 2024 16:02:18 +0100 From: Simon Horman To: Sean Anderson Cc: Radhey Shyam Pandey , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Lunn , Michal Simek , Daniel Borkmann , Paolo Abeni , "David S . Miller" , Eric Dumazet , linux-arm-kernel@lists.infradead.org, Jakub Kicinski , Ariane Keller Subject: Re: [PATCH net-next 4/4] net: xilinx: axienet: Support IFF_ALLMULTI Message-ID: <20240815150218.GJ632411@kernel.org> References: <20240812200437.3581990-1-sean.anderson@linux.dev> <20240812200437.3581990-5-sean.anderson@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240812200437.3581990-5-sean.anderson@linux.dev> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240815_080224_019245_6B0780EC X-CRM114-Status: GOOD ( 10.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 12, 2024 at 04:04:37PM -0400, Sean Anderson wrote: > Add support for IFF_ALLMULTI by configuring a single filter to match the > multicast address bit. This allows us to keep promiscuous mode disabled, > even when we have more than four multicast addresses. An even better > solution would be to "pack" addresses into the available CAM registers, > but that can wait for a future series. > > Signed-off-by: Sean Anderson My comment on patch 1/4 notwithstanding, this looks good to me. Reviewed-by: Simon Horman