From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4D6FEC3DA7F for ; Thu, 15 Aug 2024 16:02:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To :Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1Ryx5O6Rh4gRHfe4ZHY105RyKrx1yjDfxlu1j/HlgfQ=; b=FlglyzKFmQd7masMHszG0XV5rw z9CCkBSsiNis6hZcY9ofkyLjrVC9LlUhx28oHQ6ANcBSdIIOCD8Ti7YvEFVXYLXzqq2i3jZA5RosA ypbHwWzBLpPdekGEGzH5p8oN6eEyP9XyrEPVnWXtp9zd44KmVD1C07P6EJYxp9fbYXu1S9qK+QstA Z/b59MKmbNwb1znqy8ljqkq++GrYyB0I57fP1/2+6wq1X8TLKnMe2OBau5mIJ0lKJnYTv07fapAN4 ijqmB6LYBRl+p9/p0w/YRaYiPqWoXfBaCmVZi5ZCh4fBaLrWnBf+oZTPa8SdNeAyI4yroKkvogDyp sFA2bM4A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1secvS-0000000ASQU-0Neg; Thu, 15 Aug 2024 16:02:10 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1secud-0000000ASG1-47lZ for linux-arm-kernel@lists.infradead.org; Thu, 15 Aug 2024 16:01:25 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id C791FCE1C83; Thu, 15 Aug 2024 16:01:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1C23AC32786; Thu, 15 Aug 2024 16:01:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723737676; bh=bpLctNnXNGhiRFpnTqnNbNKjW5iZ+9VEc+lKuloqtSc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BA7XIfQqUp304q0UubGf+Dtll1j0k3G9oGyub1hlDn4xktjCwVzLDCOvouVAk9Wa+ r9cYbFcrmT4BaiTcYySS+Clu6UH1gcoln0SBm2WjkalmR+Od0BINGeq2xx17xjfsHa oerCASdcnS77HqSiHJgsq0XlAdFecbGtLIw5Lk5PUX12v9ut26h4MNiHBb8s4ft61M p+U4uqxvZVUE6nFuRpo916Q0rJ2i4qzAGo/lJaP/oRjc9Mbfkpe/nFXPif1Is2Dud1 cvYoMnP/tmB6AMmc6BezMmJSaowir88MPTz0lE7MUWbneEO8jHtnkFTp3bI6QkHhJU DasylzQzzV60Q== Date: Thu, 15 Aug 2024 17:01:09 +0100 From: Simon Horman To: MD Danish Anwar Subject: Re: [PATCH net-next v5 2/2] net: ti: icssg-prueth: Add support for PA Stats Message-ID: <20240815160109.GN632411@kernel.org> References: <20240814092033.2984734-1-danishanwar@ti.com> <20240814092033.2984734-3-danishanwar@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240814092033.2984734-3-danishanwar@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240815_090120_387029_1EE1E7F9 X-CRM114-Status: GOOD ( 16.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , Andrew Lunn , Vignesh Raghavendra , Jan Kiszka , Eric Dumazet , Dan Carpenter , Rob Herring , Sai Krishna , Diogo Ivo , Jakub Kicinski , Paolo Abeni , devicetree@vger.kernel.org, Conor Dooley , Roger Quadros , Santosh Shilimkar , linux-arm-kernel@lists.infradead.org, srk@ti.com, Kory Maincent , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , "David S. Miller" , Heiner Kallweit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 14, 2024 at 02:50:33PM +0530, MD Danish Anwar wrote: ... > diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth.h b/drivers/net/ethernet/ti/icssg/icssg_prueth.h > index f678d656a3ed..ac2291d22c42 100644 > --- a/drivers/net/ethernet/ti/icssg/icssg_prueth.h > +++ b/drivers/net/ethernet/ti/icssg/icssg_prueth.h > @@ -50,8 +50,10 @@ > > #define ICSSG_MAX_RFLOWS 8 /* per slice */ > > +#define ICSSG_NUM_PA_STATS 4 > +#define ICSSG_NUM_MII_G_RT_STATS 60 > /* Number of ICSSG related stats */ > -#define ICSSG_NUM_STATS 60 > +#define ICSSG_NUM_STATS (ICSSG_NUM_MII_G_RT_STATS + ICSSG_NUM_PA_STATS) > #define ICSSG_NUM_STANDARD_STATS 31 > #define ICSSG_NUM_ETHTOOL_STATS (ICSSG_NUM_STATS - ICSSG_NUM_STANDARD_STATS) > > @@ -263,6 +265,7 @@ struct prueth { > struct net_device *registered_netdevs[PRUETH_NUM_MACS]; > struct regmap *miig_rt; > struct regmap *mii_rt; > + struct regmap *pa_stats; Please add an entry for pa_stats to the Kernel doc for this structure. > > enum pruss_pru_id pru_id[PRUSS_NUM_PRUS]; > struct platform_device *pdev; ... > diff --git a/drivers/net/ethernet/ti/icssg/icssg_stats.h b/drivers/net/ethernet/ti/icssg/icssg_stats.h > index 999a4a91276c..e834316092c9 100644 > --- a/drivers/net/ethernet/ti/icssg/icssg_stats.h > +++ b/drivers/net/ethernet/ti/icssg/icssg_stats.h > @@ -77,6 +77,20 @@ struct miig_stats_regs { > u32 tx_bytes; > }; > > +/** > + * struct pa_stats_regs - ICSSG Firmware maintained PA Stats register > + * @u32 fw_rx_cnt: Number of valid packets sent by Rx PRU to Host on PSI > + * @u32 fw_tx_cnt: Number of valid packets copied by RTU0 to Tx queues > + * @u32 fw_tx_pre_overflow: Host Egress Q (Pre-emptible) Overflow Counter > + * @u32 fw_tx_exp_overflow: Host Egress Q (Express) Overflow Counter > + */ ./scripts/kernel-doc -none doesn't seem to like the syntax above. Perhaps s/u32 // ? > +struct pa_stats_regs { > + u32 fw_rx_cnt; > + u32 fw_tx_cnt; > + u32 fw_tx_pre_overflow; > + u32 fw_tx_exp_overflow; > +}; > + > #define ICSSG_STATS(field, stats_type) \ > { \ > #field, \ ...