From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CA86DC52D7C for ; Thu, 15 Aug 2024 16:26:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fkUGIQbwRXV6Lq2jowcyGfccaaCLPz7bWJxbdPn9n30=; b=UXdngvbuv8yLTsoJpvaez3tEzg HpfyWSon5E1PHl5xbQn06wl1FI7d80bMzAHocAnBLDC21E/JS7rVY6R0nyqDkxQJMIHPUuwQk1tau i9z22MSWm93ZZJ7eJa51HzpocaiUB3vmmCgTHRUIN42T3Gon567mMlP9QaViROh36daRsb6ZC5zlE yGSbibgwXe+Z0VhqF4lnBNuvAhOkUlh93clFfw2DMTFIojoj60UhNfQN+/aq39Yv5LAX4Zp2bdbVd ozkglr/zIrVrV/EgW16L9GXBEOZ4PK8O27U2L08XSEwUxv8BkS7dB5TJOLcyhb/bHOzkWapbz9q+N +q9kAMsw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sedIR-0000000AVUA-2TnM; Thu, 15 Aug 2024 16:25:55 +0000 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sedHf-0000000AVJF-3ME1 for linux-arm-kernel@lists.infradead.org; Thu, 15 Aug 2024 16:25:16 +0000 Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-201fbd0d7c2so4294665ad.0 for ; Thu, 15 Aug 2024 09:25:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1723739106; x=1724343906; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=fkUGIQbwRXV6Lq2jowcyGfccaaCLPz7bWJxbdPn9n30=; b=IAmiKObo+RKa7h5k4+k0q4MswkHyoP+0BGH4ZiJOhetAHOt7l7lmLUKWxi0T2QfdCD /YHm7I325F+hThObFc3lGG0XuXBdxfrlHchs44/5L10LfVEg3kCUKnI/zWCuHi25A0AW cx051NPxiAeVl1jIhW8YLV+snkRiCjwZg+80GFTb0BqAB0v0LT0CvZugjYFx+sX9l3es JO132MBxY+dNSrCDhg/PgrkzUP7yVCl/op2x45dp1shBaZUQZwVHe0czEtiFmfyu7sY0 XfrwbQvwNi5MVdCK/yTuTrjNOu/L1jUFGSTHM6aeEODPO5uOTzdU7ZNblJem+0va40cY avxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723739106; x=1724343906; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fkUGIQbwRXV6Lq2jowcyGfccaaCLPz7bWJxbdPn9n30=; b=NhbJhJ/GXm52gv0kGaupKcSLpdILY7w0gw4o1JSRYCQxKIjW1ZOl/rUllgSRZXK4I7 0XGNT5I+xVhXaKgB7xh4qsjfO1sr4c+CUNHFUUNrm0rfez0xrdc58vm+vo7MxlGs7f16 kOxVLIYPCea9eA23MpsQ+RURwru5KzCWPT8xX/f5c3PHnsJ68wIFOLPSTYiC6XzW263B mFXLl7L9X97OtWl9VYWvQLPo+kRCCA0eXQIF7qkxwHNHXiT8hI63qxggFu2X6yYsEUjy m/Npzz3cr7BLMAgiVEysNluGh+pZflWH/1w6iieV0t3PsnCQjOOpHwCvLBBRiubObACA b2eQ== X-Forwarded-Encrypted: i=1; AJvYcCW3VZ4xHpPD0SlQZsEQ8bbBTDiElguXUTpm9OIqLt2NYZxCi7qwV1KfeT3lyi/l1Jn1loUkhAg8heWAfuiRcEzL+Ce21sLZclOgX16j7BaPzVea/to= X-Gm-Message-State: AOJu0YyZeFM637SYIs10zgOcZ/us1caX4dVlb3WRCtNaOrmz6ajE05ue 6nYqh0GHaplfmuUiiEsORI3POxi7+Q8czMaEKpEIhVR0Q4c3mvlw/dJzg9C3Ww== X-Google-Smtp-Source: AGHT+IEf9BWPqw66jhhiHQthvPGpBzvSfL+a+8WG13ziSXvFf+QiYJM8a8qmItiT1VexAhIkaMs9OQ== X-Received: by 2002:a17:90b:ec1:b0:2bd:7e38:798e with SMTP id 98e67ed59e1d1-2d3dfff5d77mr163380a91.28.1723739105668; Thu, 15 Aug 2024 09:25:05 -0700 (PDT) Received: from thinkpad ([36.255.17.34]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2d3ac7ca30bsm3787522a91.7.2024.08.15.09.25.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Aug 2024 09:25:04 -0700 (PDT) Date: Thu, 15 Aug 2024 21:54:59 +0530 From: Manivannan Sadhasivam To: Anand Moon Cc: Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Heiko Stuebner , linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 3/3] PCI: rockchip: Refactor rockchip_pcie_disable_clocks function signature Message-ID: <20240815162459.GG2562@thinkpad> References: <20240625104039.48311-1-linux.amoon@gmail.com> <20240625104039.48311-3-linux.amoon@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240625104039.48311-3-linux.amoon@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240815_092507_847929_C76847DD X-CRM114-Status: GOOD ( 17.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 25, 2024 at 04:10:34PM +0530, Anand Moon wrote: > Updated rockchip_pcie_disable_clocks function to accept > a struct rockchip pointer instead of a void pointer. > Please use imperative tone in all patch descriptions. s/Updated/Update > Signed-off-by: Anand Moon With above, Reviewed-by: Manivannan Sadhasivam - Mani > --- > v4: None > v3: None > v2: None > --- > drivers/pci/controller/pcie-rockchip.c | 4 +--- > drivers/pci/controller/pcie-rockchip.h | 2 +- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/pci/controller/pcie-rockchip.c b/drivers/pci/controller/pcie-rockchip.c > index 024308bb6ac8..81deb7fc6882 100644 > --- a/drivers/pci/controller/pcie-rockchip.c > +++ b/drivers/pci/controller/pcie-rockchip.c > @@ -272,10 +272,8 @@ int rockchip_pcie_enable_clocks(struct rockchip_pcie *rockchip) > } > EXPORT_SYMBOL_GPL(rockchip_pcie_enable_clocks); > > -void rockchip_pcie_disable_clocks(void *data) > +void rockchip_pcie_disable_clocks(struct rockchip_pcie *rockchip) > { > - struct rockchip_pcie *rockchip = data; > - > clk_bulk_disable_unprepare(ROCKCHIP_NUM_CLKS, rockchip->clks); > } > EXPORT_SYMBOL_GPL(rockchip_pcie_disable_clocks); > diff --git a/drivers/pci/controller/pcie-rockchip.h b/drivers/pci/controller/pcie-rockchip.h > index 27e951b41b80..3330b1e55dcd 100644 > --- a/drivers/pci/controller/pcie-rockchip.h > +++ b/drivers/pci/controller/pcie-rockchip.h > @@ -354,7 +354,7 @@ int rockchip_pcie_init_port(struct rockchip_pcie *rockchip); > int rockchip_pcie_get_phys(struct rockchip_pcie *rockchip); > void rockchip_pcie_deinit_phys(struct rockchip_pcie *rockchip); > int rockchip_pcie_enable_clocks(struct rockchip_pcie *rockchip); > -void rockchip_pcie_disable_clocks(void *data); > +void rockchip_pcie_disable_clocks(struct rockchip_pcie *rockchip); > void rockchip_pcie_cfg_configuration_accesses( > struct rockchip_pcie *rockchip, u32 type); > > -- > 2.44.0 > > -- மணிவண்ணன் சதாசிவம்