From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DB78BC3DA4A for ; Fri, 16 Aug 2024 07:09:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ve53LZasd5GhenfxsqknMts/Bqu17WdDe0sjGg3VIPI=; b=OGkdweox7wUY4NSQnmxRa66ukl st+5ZgKjGSBISXW3dx0RTLfKdBpZwjaOOpl+vuzteEV9kF+9m08JQQaUnDUscbZON0KTdLWgebiGs CRE8z0ShTb6mb9plds4jgVDij5HuDYtMA28VXu6HnmQs1Gn4KByyZiKG5a1vlDHRO0MaLpiRAnhvR dHH7ADbvIJZZqNwlHyweSSz86zXYlpwB2W2AViMTYGYx1ZVdGsUCiIaBpcfjrQSqbsvgdFtC2qL+F os/WwZ1mGokx9+uO70gtKtJ43dITRCd2UzC+bA3XkGIKYolWq64sEOUm+o7SUBHPxbxrbxRNnzvL+ T8m5N+dA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ser5G-0000000C2Nl-2wCy; Fri, 16 Aug 2024 07:09:15 +0000 Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ser4V-0000000C284-2hmz for linux-arm-kernel@lists.infradead.org; Fri, 16 Aug 2024 07:08:33 +0000 Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-70d25b5b6b0so1436061b3a.2 for ; Fri, 16 Aug 2024 00:08:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1723792106; x=1724396906; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Ve53LZasd5GhenfxsqknMts/Bqu17WdDe0sjGg3VIPI=; b=yfH9Kt3UWbu9IocyN/OAtjlQz81OJ6D+X77lk71e0I+bOq2KFJom6QyxF89cykx82s VEu0BEkEJ3D+umDQhzQaRsJZ3HY5WuJEUHglgSA6RXS8unrHu2Zxxlboi9/C5NRqg4mw vNbYwm4n9AgI3bu+pvkuVxUHIVL0TbNYn3wqpvtxHsohoAhUIGsdwEIaE+QdKYgOq1BQ ++8fOUtNc3EoLruvVv36Y2Ws3eRdU1SzQiZqphufU3lYFF7G+3cc5mjaivbvfNLmyYY1 IOeH71JR/OdkM83Gv0wmGCD/iPWhpm0LVqn8CZ1aY6/E4sVrW3LONpVWUMLRkCaF3f7p CkBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723792106; x=1724396906; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ve53LZasd5GhenfxsqknMts/Bqu17WdDe0sjGg3VIPI=; b=uVFXyx7/INjeAW7l5mPVrfplLiZHKYKqc+3cWQuYPDeKBN6aWLEJBTb++iZfYmwCgl ED3qjSvma7UxBFkbkLrCb2fV4MOQMvBheOM9J7AD0z5ofwe9pn4RO439yd0iSq2+7DNx ouBVfnxnW6WvLOk7Xt9xeHAXHSgzOCgnCUCkav2iooscUE8fHWanY6jiY/v+KVNESe+c Q9gwWSe6sH7bUxkm+5gJmyew6eJz3oEm0JKB1ohsOxYZPL5qJ/Ny8Rnr82wACef6BUwz piWCFPdisabYBeBStBXthXj8bJEo7FmbbN9fwHY2loXyYdPGGdNIJMlazwX04toAME1n GLag== X-Forwarded-Encrypted: i=1; AJvYcCVP3KYrauRqNHrU1Wm5txDl32duIKAlaoSh2aFaDhSOYGvmy0/qy0t+lkI2jWWzOtspVWrhAxo8Z4j+hQ3vAHPGyzEJ2IpcBVPODW+QzTw1rGu+dus= X-Gm-Message-State: AOJu0YzX1DmBBRtgjt6CbQEUZydmvEEfbJc0W9m6oOLgIxq5RA/pp7pL 5GdXgo/7C691ib1jWOpnLxlipitWX1xlsmu1rm1HjE6gVjWVwU6QsHasE+LxUA== X-Google-Smtp-Source: AGHT+IFIhu3GdVi4RmTqJVC1P3RARmFgEfcXYer0ZF+yIp/ekUj9mGEbkpI/lQd4eLxaKU5b1ekuHA== X-Received: by 2002:a05:6a20:c896:b0:1c0:f26e:2296 with SMTP id adf61e73a8af0-1c905059c78mr2221508637.48.1723792106317; Fri, 16 Aug 2024 00:08:26 -0700 (PDT) Received: from thinkpad ([36.255.17.34]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2d3e3c74e33sm1058237a91.39.2024.08.16.00.08.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Aug 2024 00:08:25 -0700 (PDT) Date: Fri, 16 Aug 2024 12:38:19 +0530 From: Manivannan Sadhasivam To: Jim Quinlan Cc: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Stanimir Varbanov , Krzysztof Kozlowski , bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com, Florian Fainelli , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Philipp Zabel , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list Subject: Re: [PATCH v6 06/13] PCI: brcmstb: Use swinit reset if available Message-ID: <20240816070819.GK2331@thinkpad> References: <20240815225731.40276-1-james.quinlan@broadcom.com> <20240815225731.40276-7-james.quinlan@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240815225731.40276-7-james.quinlan@broadcom.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240816_000827_713482_3A209B5C X-CRM114-Status: GOOD ( 21.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 15, 2024 at 06:57:19PM -0400, Jim Quinlan wrote: > The 7712 SOC adds a software init reset device for the PCIe HW. > If found in the DT node, use it. > > Signed-off-by: Jim Quinlan Reviewed-by: Manivannan Sadhasivam - Mani > --- > drivers/pci/controller/pcie-brcmstb.c | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c > index af14debd81d0..aa21c4c7b7f7 100644 > --- a/drivers/pci/controller/pcie-brcmstb.c > +++ b/drivers/pci/controller/pcie-brcmstb.c > @@ -266,6 +266,7 @@ struct brcm_pcie { > struct reset_control *rescal; > struct reset_control *perst_reset; > struct reset_control *bridge_reset; > + struct reset_control *swinit_reset; > int num_memc; > u64 memc_size[PCIE_BRCM_MAX_MEMC]; > u32 hw_rev; > @@ -1633,12 +1634,35 @@ static int brcm_pcie_probe(struct platform_device *pdev) > if (IS_ERR(pcie->bridge_reset)) > return PTR_ERR(pcie->bridge_reset); > > + pcie->swinit_reset = devm_reset_control_get_optional_exclusive(&pdev->dev, "swinit"); > + if (IS_ERR(pcie->swinit_reset)) > + return PTR_ERR(pcie->swinit_reset); > + > ret = clk_prepare_enable(pcie->clk); > if (ret) > return dev_err_probe(&pdev->dev, ret, "could not enable clock\n"); > > pcie->bridge_sw_init_set(pcie, 0); > > + if (pcie->swinit_reset) { > + ret = reset_control_assert(pcie->swinit_reset); > + if (ret) { > + clk_disable_unprepare(pcie->clk); > + return dev_err_probe(&pdev->dev, ret, > + "could not assert reset 'swinit'\n"); > + } > + > + /* HW team recommends 1us for proper sync and propagation of reset */ > + udelay(1); > + > + ret = reset_control_deassert(pcie->swinit_reset); > + if (ret) { > + clk_disable_unprepare(pcie->clk); > + return dev_err_probe(&pdev->dev, ret, > + "could not de-assert reset 'swinit'\n"); > + } > + } > + > ret = reset_control_reset(pcie->rescal); > if (ret) { > clk_disable_unprepare(pcie->clk); > -- > 2.17.1 > -- மணிவண்ணன் சதாசிவம்