From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0896CC3DA4A for ; Fri, 16 Aug 2024 07:15:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1go7sx0ECg3Nrbun5bUntSM8dbrApaP82pTFnxOeNLY=; b=S0hMhFuC6+o+0MBqYarVodfaK/ 0IA9jZqn8m3ybCBrf1U9Ano1zHT1MVPolfJqYjAwOeToWED1N8vYwWZDflDcI6CL6ywBZJvgnUY5x tFjYcKhBc6cIn6lO/mk7lKPSPKOr44shqyzrgSnld8DNcH0XyQ8xRxcZUkw9EJgWwuVOgabgsxjD8 HctTehgqR8pPHXr305Yzjw4zsmRMzfSxGvjyktkIMws6SWcOt6PhyV6OqwlNWXRGLQyTUQSA7lisc 0AD8/hmewo58VNutGFGXWmPXLkiRlqeys1W6f55Ai66BN7i7nIIgswVsbbXXQVCx/7afBZWFfq+Xq 47bROINg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1serBB-0000000C3nA-0Jyy; Fri, 16 Aug 2024 07:15:21 +0000 Received: from mail-pf1-x42a.google.com ([2607:f8b0:4864:20::42a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1serAW-0000000C3cB-3iLd for linux-arm-kernel@lists.infradead.org; Fri, 16 Aug 2024 07:14:42 +0000 Received: by mail-pf1-x42a.google.com with SMTP id d2e1a72fcca58-710dc3015bfso1208441b3a.0 for ; Fri, 16 Aug 2024 00:14:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1723792479; x=1724397279; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=1go7sx0ECg3Nrbun5bUntSM8dbrApaP82pTFnxOeNLY=; b=E3TLi+f997Dz+NlY0pFzXZyycA0vMnDf8TiiQLTEDVBISFxG9OTABguVrR5wxa0Pct 1HVNbkC0WykO0xVUvd+RzNUvcye/eP7Rn6E1Ng+oDtBiGwcOxwyqPKpSrfvCg8+q8B6m p20aOQ67u9f99t71qkz1nRd/sDIVTWVxDukUVHz3yvwuFIKmpvICdi4s97ruadtSkfCg byXQlwnaVGez9nm19V8wPDkQscu310AYNs8/pZP1NV6CIM+Bk/bApaTTxr27OpbkpKSG 6uLaIu6RvpYmRZW6T8+4nzTsoSkayjBgXA/eC8bLejPflgw7VWGU/BWfVb+M2PwOlkWD f00Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723792479; x=1724397279; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1go7sx0ECg3Nrbun5bUntSM8dbrApaP82pTFnxOeNLY=; b=UgqiMImc+F6I8pQBb3GdXZi7SIFR8cFWGjkN5EQQOX9quaxUsGswVfZqXNVy3j6TBY aybj0Ksmmf1t82B5NcW6U6TvpTE8IWImRYKvAQKpCjg/TWP7qlP8M2+BidgmNuTb6pje q4qchzp6taRVgZ+JNPTUGOf6+2QtHQzVltSFQ/JQ49FieNp6KewUtg12gLDghSixrVtY YwMADFiQcfBQ4gT5j9NHdMDUBhoLJwpMP7VnDZG0ZZVjM8GbVcLLBcw+F/qJ555O0u2u QQK56OA7E7zqaTEd50iJWhOo0wkUXmDTJ1IddiRR2ffXv7PG8EGmWlycKEIN6Sa8QLw0 gAyA== X-Forwarded-Encrypted: i=1; AJvYcCVJcR8ONEua0/v5LDca3TKo4eIbUFh61+xh/pz1lh+BiZxAUyMN98dfzdFmjtQcLFO4p340VBpf/yAI0UyRoZeJ@lists.infradead.org X-Gm-Message-State: AOJu0YzdMGFcWMcJhj0RibU9wtekWLLjfwGMBEwuh1A98TGjEexwEO1v 8jVc0WWe8HkDzC83w0DPhAkTRv3IsbJw7lnbbEmrmGRQcLgYkCRBO/Nv10V0Nw== X-Google-Smtp-Source: AGHT+IEs7skbPukuQ+QD2T4e30incfTrK+bKIykg7J49EQF5T/hlK5KpRQ9P3b2QajFbL/ijk8kb7g== X-Received: by 2002:a05:6a00:6803:b0:706:938a:5d49 with SMTP id d2e1a72fcca58-71277094499mr6925763b3a.14.1723792479465; Fri, 16 Aug 2024 00:14:39 -0700 (PDT) Received: from thinkpad ([36.255.17.34]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7127ae07e41sm2054202b3a.65.2024.08.16.00.14.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Aug 2024 00:14:39 -0700 (PDT) Date: Fri, 16 Aug 2024 12:44:33 +0530 From: Manivannan Sadhasivam To: Jim Quinlan Cc: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Stanimir Varbanov , Krzysztof Kozlowski , bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com, Florian Fainelli , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Philipp Zabel , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list Subject: Re: [PATCH v6 11/13] PCI: brcmstb: Check return value of all reset_control_xxx calls Message-ID: <20240816071433.GM2331@thinkpad> References: <20240815225731.40276-1-james.quinlan@broadcom.com> <20240815225731.40276-12-james.quinlan@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240815225731.40276-12-james.quinlan@broadcom.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240816_001440_952820_3BDB5E0C X-CRM114-Status: GOOD ( 20.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 15, 2024 at 06:57:24PM -0400, Jim Quinlan wrote: > Always check the return value for invocations of reset_control_xxx() and > propagate the error to the next level. Although the current functions > in reset-brcmstb.c cannot fail, this may someday change. > > Signed-off-by: Jim Quinlan Reviewed-by: Manivannan Sadhasivam But one comment below. > Reviewed-by: Stanimir Varbanov > Reviewed-by: Florian Fainelli > --- > drivers/pci/controller/pcie-brcmstb.c | 102 ++++++++++++++++++-------- > 1 file changed, 73 insertions(+), 29 deletions(-) > > diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c > index c5d3a5e9e0fc..d19eeeed623b 100644 > --- a/drivers/pci/controller/pcie-brcmstb.c > +++ b/drivers/pci/controller/pcie-brcmstb.c [...] > static int pci_dev_may_wakeup(struct pci_dev *dev, void *data) > @@ -1479,9 +1515,12 @@ static int brcm_pcie_suspend_noirq(struct device *dev) > { > struct brcm_pcie *pcie = dev_get_drvdata(dev); > struct pci_host_bridge *bridge = pci_host_bridge_from_priv(pcie); > - int ret; > + int ret, rret; > + > + ret = brcm_pcie_turn_off(pcie); > + if (ret) > + return ret; > > - brcm_pcie_turn_off(pcie); > /* > * If brcm_phy_stop() returns an error, just dev_err(). If we > * return the error it will cause the suspend to fail and this is a > @@ -1510,7 +1549,10 @@ static int brcm_pcie_suspend_noirq(struct device *dev) > pcie->sr->supplies); > if (ret) { > dev_err(dev, "Could not turn off regulators\n"); > - reset_control_reset(pcie->rescal); > + rret = reset_control_reset(pcie->rescal); > + if (rret) > + dev_err(dev, "failed to reset 'rascal' controller ret=%d\n", Do you really mean to say 'rascal'? ;) - Mani -- மணிவண்ணன் சதாசிவம்