From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB4B1C3DA4A for ; Fri, 16 Aug 2024 07:19:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0Yp5hMnzY0MppJ+YTjzvAfDTWaoEJOMYLebj+UdYxJM=; b=sMO4XMtEkYSz3hDHwhymJ3ZXkF 35GJl+EW/T/fiqNS4DN4Hw0b8CTPKdXf6qy1r01h+uVOoCtxwx8IpMVww0AJs+zqamTWGnTxURFwu WkJajtoX/k94nj/Wfw0iluAh08z/COANBQ0R0jpVev0laBSPZg4xvyIOFa9wsJjAQbW+qpsl4PdNk p/l6AwdlbfXfWw8qFdwPTBlc7kKOfoJzT4/mDkeiQH2hSBatJPMtME5+8eU+O+J6tVku0RQmVx+h6 poLlcTuE0ZYvsdA4tPc+sp2OsYz6i0Bke2kRAi1ULizmp5ZfNBvihTI7hk+6YL7c67B8Pzz0QFFQB tT0XV4/A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1serEt-0000000C4nE-1UJ3; Fri, 16 Aug 2024 07:19:11 +0000 Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1serED-0000000C4bL-147z for linux-arm-kernel@lists.infradead.org; Fri, 16 Aug 2024 07:18:30 +0000 Received: by mail-pg1-x532.google.com with SMTP id 41be03b00d2f7-7a264a24ea7so1353578a12.3 for ; Fri, 16 Aug 2024 00:18:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1723792708; x=1724397508; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=0Yp5hMnzY0MppJ+YTjzvAfDTWaoEJOMYLebj+UdYxJM=; b=B0NzGjX6VOEf1XOULWAHnFjRqFtaZZRNu+OvZAuMRLOowdL7eTIghKF1Gd05Su4u5Z aP9X9/MqwYGMu6EGENOe//DfTmQ1X3x9SC29PM+UfeB6FqKWk+npEcmcThmuvbxdM0xW oR+p38eZMyhZmi1SSQ8lyUBNDAQoL4crWZ2YyS5Ozrjfjfyk+Mw00m/xOG6tPIgCgAgM SWCvg1rbyMHfmfgo1joImjSJPFO+pPu1oClXiX5Z+JCxd3PJYOs0KHYQnszhPxrSK01i 9GUS1JJoJ6h1vHDb2+cH8/jc8REYqN6Rhs5+KgMbo73mLKWB2eLbFqrXX8J4d6aD1V8k geGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723792708; x=1724397508; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0Yp5hMnzY0MppJ+YTjzvAfDTWaoEJOMYLebj+UdYxJM=; b=JDmq9tpAVv432hlw4oqN2NRmDCMcHBRlfvgw4QCsrb7C0G8GBUsdwdX1PFRU/GnmgD jkXGUe4BFytjHLHuXBEteqfvqeZ5tN85CMDdX6bIF2flc0Ga/tl1h9NB9jsyWLWpYtmS 6K8VIQn5mwcWGcm6R7j1m59ZGP3lc/jIdNgyKzQB3G17oHZmE9Nvg0qehg5eBzdSkFfS K0/rSTcF5VysfrbXuOXQmXETqPHVLE55tyAGsCkIKxe8vjwsFhEyxqRwBGSfXWLIGvoN VyZcQKuOnGz2QTtWwLLJTTiQmQpQxCcMJ/rmmG8/Pl0CkvKdHCM39KEHK20trl8OOLTZ rOhQ== X-Forwarded-Encrypted: i=1; AJvYcCWQdUtc7+leUdxTM78nL5AFQTs7mLpjqm2IQTFKbdZiMVFUrKCEquwuMJhny5IZGrfAsS/KHXOBS6//+pD3hjHeWw5wqUnmPxs+W43veN6QUVh1azc= X-Gm-Message-State: AOJu0YzQ9w6KOeUzeiPLWJAviRqc7/TRL/t8OHTQZtg48Rf2Z60OVJCU ejeJQkAOXJCiEUQFHk5s15ZCUucQXTz5sB+6iPDQ+95cOhh9cFjK9zfKbgiCbQ== X-Google-Smtp-Source: AGHT+IE/Ce9TzANMbRw4Oif4Tj5G9vXLEWWJGupTaGJORK1OjwraaIu/dqcDdcuoU4RkUacM7S0xiw== X-Received: by 2002:a05:6a21:3983:b0:1c1:e75a:5504 with SMTP id adf61e73a8af0-1c904faaeefmr2746336637.15.1723792707938; Fri, 16 Aug 2024 00:18:27 -0700 (PDT) Received: from thinkpad ([36.255.17.34]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7127aef5229sm2056273b3a.107.2024.08.16.00.18.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Aug 2024 00:18:27 -0700 (PDT) Date: Fri, 16 Aug 2024 12:48:22 +0530 From: Manivannan Sadhasivam To: Jim Quinlan Cc: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Stanimir Varbanov , Krzysztof Kozlowski , bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , Rob Herring Subject: Re: [PATCH v6 00/13] PCI: brcnstb: Enable STB 7712 SOC Message-ID: <20240816071822.GO2331@thinkpad> References: <20240815225731.40276-1-james.quinlan@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240815225731.40276-1-james.quinlan@broadcom.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240816_001829_329712_D3FDFC4A X-CRM114-Status: GOOD ( 31.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 15, 2024 at 06:57:13PM -0400, Jim Quinlan wrote: > V6 Changes > o Commit "Refactor for chips with many regular inbound windows" > -- Use u8 for anything storing/counting # inbound windows (Stan) > -- s/set_bar/add_inbound_win/g (Manivannan) > -- Drop use of "inline" (Manivannan) > -- Change cpu_beg to cpu_start, same with pcie_beg. (Manivannan) > -- Used writel_relaxed() (Manivannan) > o Use swinit reset if available > -- Proper use of dev_err_probe() (Stan) > o Commit "Use common error handling code in brcm_pcie_probe()" > -- Rewrite commit msg in paragraph form (Manivannan) > -- Refactor error path at end of probe func (Manivannan) > -- Proper use of dev_err_probe() (Stan) > o New commit "dt-bindings: PCI: Change brcmstb maintainer and cleanup" > -- Break out maintainer change and small cleanup into a > separate commit (Krzysztof) > Looks like you've missed adding the review tags... - Mani > V5 Changes: > o All commits: Use imperative voice in commit subjects/messages > (Manivannan) > o Commit "PCI: brcmstb: Enable 7712 SOCs" > -- Augment commit message to include PCIe details and revision. > (Manivannan) > o Commit "PCI: brcmstb: Change field name from 'type' to 'model'" > -- Instead of "model" use "soc_base" (Manivannan) > o Commit "PCI: brcmstb: Refactor for chips with many regular inbound BARs" > -- Get rid of the confusing "BAR" variable names and types and use > something like "inbound_win". (Manivannan) > o Commit "PCI: brcmstb: PCI: brcmstb: Make HARD_DEBUG, INTR2_CPU_BASE..." > -- Mention in the commit message that this change is in preparation > for the 7712 SoC. (Manivannan) > o Commit: "PCI: brcmstb: Use swinit reset if available" > -- Change reset name "swinit" to "swinit_reset" (Manivannan) > -- Add 1us delay for reset (Manivannan) > -- Use dev_err_probe() (Multiple reviewers) > o Commit "PCI: brcmstb: Use bridge reset if available" > -- Change reset name "bridge" to "bridge_reset" (Manivannan) > -- The Reset API can take NULL so need need to test variable > before calling (Manivannan) > -- Added a call to bridge_sw_init_set() method in probe() > as some registers cannot be accessed w/o this. (JQ) > o Commit "PCI: brcmstb: Use common error handling code in ..." > -- Use more descriptive goto label (Manivannan) > -- Refactor error paths to be less encumbered (Manivannan) > -- Use dev_err_probe() (Multiple reviewers) > o Commits "dt-bindings: PCI: brcmstb: ..." > -- Specify the "resets" and "reset-names" in the same manner > as does qcom,ufs.yaml specifies "clocks" and > "clock-names" (Krzysztof) > -- Drop reset desccriptions as they were pretty content-free > anyhow. (Krzysztof) > > V4 Changes: > o Commit "Check return value of all reset_control_xxx calls" > -- Blank line before "return" (Stan) > o Commit "Use common error handling code in brcmstb_probe()" > -- Drop the "Fixes" tag (Stan) > o Commit "dt-bindings: PCI ..." > -- Separate the main commit into two: cleanup and adding the > 7712 SoC (Krzysztof) > -- Fold maintainer change commit into cleanup change (Krzysztof) > -- Use minItems/maxItems where appropriate (Krzysztof) > -- Consistent order of resets/reset-names in decl and usage > (Krzysztof) > > V3 Changes: > o Commit "Enable 7712 SOCs" > -- Move "model" check from outside to inside func (Stan) > o Commit "Check return value of all reset_control_xxx calls" > -- Propagate errors up the chain instead of ignoring them (Stan) > o Commit "Refactor for chips with many regular inbound BARs" > -- Nine suggestions given, nine implemented (Stan) > o Commit "Make HARD_DEBUG, INTR2_CPU_BASE offsets SoC-specific" > -- Drop tab, add parens around macro params in expression (Stan) > o Commit "Use swinit reset if available" > -- Treat swinit the same as other reset controllers (Stan) > Stan suggested to use dev_err_probe() for getting resources > but I will defer that to future series (if that's okay). > o Commit "Get resource before we start asserting resets" > -- Squash this with previous commit (Stan) > o Commit "Use "clk_out" error path label" > -- Move clk_prepare_enable() after getting resouurces (Stan) > -- Change subject to "Use more common error handling code in > brcm_pcie_probe()" (Markus) > -- Use imperative commit description (Markus) > -- "Fixes:" tag added for missing error return. (Markus) > o Commit "dt-bindings: PCI ..." > -- Split off maintainer change in separate commit. > -- Tried to accomodate Krzysztof's requests, I'm not sure I > have succeeded. Krzysztof, please see [1] below. > > [1] Wrt the YAML of brcmstb PCIe resets, here is what I am trying > to describe: > > CHIP NUM_RESETS NAMES > ==== ========== ===== > 4908 1 perst > 7216 1 rescal > 7712 3 rescal, bridge, swinit > Others 0 - > > > V2 Changes (note: four new commits): > o Commit "dt-bindings: PCI ..." > -- s/Adds/Add/, fix spelling error (Bjorn) > -- Order compatible strings alphabetically (Krzysztof) > -- Give definitions first then rules (Krzysztof) > -- Add reason for change in maintainer (Krzysztof) > o Commit "Use swinit reset if available" > -- no need for "else" clause (Philipp) > -- fix improper use of dev_err_probe() (Philipp) > o Commit "Use "clk_out" error path label" > -- Improve commit message (Bjorn) > o Commit "PCI: brcmstb: Make HARD_DEBUG, INTR2_CPU_BASE offsets SoC-specific" > -- Improve commit subject line (Bjorn) > o Commit (NEW) -- Change field name from 'type' to 'model' > -- Added as requested (Stanimir) > o Commit (NEW) -- Check return value of all reset_control_xxx calls > -- Added as requested (Stanimir) > o Commit (NEW) "Get resource before we start asserting reset controllers" > -- Added as requested (Stanimir) > o Commit (NEW) -- "Remove two unused constants from driver" > > > V1: > This submission is for the Broadcom STB 7712, sibling SOC of the RPi5 chip. > Stanimir has already submitted a patch "Add PCIe support for bcm2712" for > the RPi version of the SOC. It is hoped that Stanimir will allow us to > submit this series first and subsequently rebase his patch(es). > > The largest commit, "Refactor for chips with many regular inbound BARs" > affects both the STB and RPi SOCs. It allows for multiple inbound ranges > where previously only one was effectively used. This feature will also > be present in future STB chips, as well as Broadcom's Cable Modem group. > > Jim Quinlan (13): > dt-bindings: PCI: Change brcmstb maintainer and cleanup > dt-bindings: PCI: Use maxItems for reset controllers > dt-bindings: PCI: brcmstb: Add 7712 SoC description > PCI: brcmstb: Use common error handling code in brcm_pcie_probe() > PCI: brcmstb: Use bridge reset if available > PCI: brcmstb: Use swinit reset if available > PCI: brcmstb: PCI: brcmstb: Make HARD_DEBUG, INTR2_CPU_BASE offsets > SoC-specific > PCI: brcmstb: Remove two unused constants from driver > PCI: brcmstb: Don't conflate the reset rescal with phy ctrl > PCI: brcmstb: Refactor for chips with many regular inbound windows > PCI: brcmstb: Check return value of all reset_control_xxx calls > PCI: brcmstb: Change field name from 'type' to 'soc_base' > PCI: brcmstb: Enable 7712 SOCs > > .../bindings/pci/brcm,stb-pcie.yaml | 40 +- > drivers/pci/controller/pcie-brcmstb.c | 513 +++++++++++++----- > 2 files changed, 412 insertions(+), 141 deletions(-) > > > base-commit: e724918b3786252b985b0c2764c16a57d1937707 > -- > 2.17.1 > -- மணிவண்ணன் சதாசிவம்