From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE593C3DA4A for ; Fri, 16 Aug 2024 18:28:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=epi8htp4WFfMeOAUrRV7RJ2B0KXJWoIqG+Lmec55gjM=; b=lZ+TZ/4xZHVJOa9GZzQp+ExKOD vE5f/Uvw3d9QNQ3ceJ/H8j5hVXRat0zAwAcsqIZq9IsB/vm0qQrO7iOtoklzHctHpMbZYFwCvbp9W mQToUjeqWOqBQLX4fSbQ8U0Dzfzx04i9P+tWuHhrkXUffLtx0xZvAn+7dBn1dz8d2IK9MClTCDFtV U4tQTDG1KVI486QKCxajzU1Sv18wcZkQwLfCH9OQ0YdbfMEQzi3zECOnxvlO67Daa9B7QR7WNqVRL TW1OQVQsagG7PfIPVFWTD56dxeB3nNxUuORRx+pyWUsFlu8RJRVt9RolrncMY1n3WY2z4PV1W95yz RZpjGpvA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sf1ga-0000000DqBl-43Uf; Fri, 16 Aug 2024 18:28:29 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sf1fv-0000000Dpyj-1lYS for linux-arm-kernel@lists.infradead.org; Fri, 16 Aug 2024 18:27:49 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 6CFA1CE1B45; Fri, 16 Aug 2024 18:27:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81552C32782; Fri, 16 Aug 2024 18:27:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723832863; bh=7hRyuPjRLop1xNh3m+HIzsw6TPl/Rhga53lhKhjmo6k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Lvh8mfqQWWNO95bHqCGvTn3e238eCjDwmdI8DYP/PqwdDkHXRlLjR6pQ+aWhsk/1I 5Qkrm7+uCAkcrncMfOAo4tBq19PnyGKXUgmm4Iv9bssmHH8mLgbSD7IsipxsXlXYW3 i38Fu+SO9BhmEIJn4IczcmXDmvoB3ZQ6dogHJDed7NTNdwfGoF4PIXUyNfuKfuCc7X MCVEViCK+fxuNfs9+6koKOtZDxRt9zwhSALsdATCd8OaR+ImsVXEevALsVHGlovBeU 8IEb1ReyVEbx7vLQzPON4SDxMtFKRthJww23EWR5POtu/Vvl374GSKvS4fauXwWymZ N9zRgneda67aQ== Date: Fri, 16 Aug 2024 11:27:41 -0700 From: Jakub Kicinski To: jitendra.vegiraju@broadcom.com Cc: netdev@vger.kernel.org, alexandre.torgue@foss.st.com, joabreu@synopsys.com, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, mcoquelin.stm32@gmail.com, bcm-kernel-feedback-list@broadcom.com, richardcochran@gmail.com, ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org, john.fastabend@gmail.com, fancer.lancer@gmail.com, rmk+kernel@armlinux.org.uk, ahalaney@redhat.com, xiaolei.wang@windriver.com, rohan.g.thomas@intel.com, Jianheng.Zhang@synopsys.com, leong.ching.swee@intel.com, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, bpf@vger.kernel.org, andrew@lunn.ch, linux@armlinux.org.uk, horms@kernel.org, florian.fainelli@broadcom.com Subject: Re: [net-next v4 4/5] net: stmmac: Add PCI driver support for BCM8958x Message-ID: <20240816112741.33a3405f@kernel.org> In-Reply-To: <20240814221818.2612484-5-jitendra.vegiraju@broadcom.com> References: <20240814221818.2612484-1-jitendra.vegiraju@broadcom.com> <20240814221818.2612484-5-jitendra.vegiraju@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240816_112747_668310_023A973B X-CRM114-Status: UNSURE ( 7.48 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 14 Aug 2024 15:18:17 -0700 jitendra.vegiraju@broadcom.com wrote: > + pci_restore_state(pdev); > + pci_set_power_state(pdev, PCI_D0); > + > + ret = pci_enable_device(pdev); > + if (ret) > + return ret; > + > + pci_set_master(pdev); pci_restore_state() doesn't restore master and enable?