From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A9B82C531DC for ; Fri, 16 Aug 2024 11:49:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IY44BvNIQ8HMdyx0QMRty049Oi1G15aZuupS+GebtAw=; b=h30Azd02J/DYUT4slZ4HtylGq7 ASR0M9s4cy+OQ4CG0xMWoTsb1bxeIVkalsH/w6v8aPApX/IZiKswY4kLdunlAAjPmVGEVihnBDenC YAiOab78ZkULJlZCymZxdtgYhIQDRDoG4pRZh1j9U/Jr+MWEvkwrfXQ3b0EB4T5cQ0q1I7/byk0AU GK38x3KqU5LEJfJwveHda0etopT1RNYLon170dyt0kRAeatdU1dMhBG7QveQ4qfStec0fzRcuWagC 5Lp6lmmdKkkOvXfpioLyMLmOO4dk2CZB943v0FKmsw6wpZ/OKcmEVcbO141LZAYKN+Xr3DimwcNVJ EARgOvYw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sevS6-0000000CnUl-0xEd; Fri, 16 Aug 2024 11:49:06 +0000 Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sevRR-0000000CnQN-1uKG for linux-arm-kernel@lists.infradead.org; Fri, 16 Aug 2024 11:48:26 +0000 Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-a7aada2358fso459761766b.0 for ; Fri, 16 Aug 2024 04:48:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723808902; x=1724413702; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=IY44BvNIQ8HMdyx0QMRty049Oi1G15aZuupS+GebtAw=; b=i0kaTjVOEjJnVrqXdY5qLwh8i1e3YEV6xPmJaRc85zu59iV8Db4BtD6L5Wq0qbKyLe nwGBNbzGo4tedlICQXA+o0dmLBEHi1QuOXLiJaOVejt8YLH+w9JDNyIF5xl3GQFqlxNl /er1rC+uw1oEn8kRFRtTJwy48TS1KCMK4y8hUNrnHQdh1Q/vXqw54bXnHKZ1eThzly7B u6jRoWgHdVZjbrew8SSzu32eZWoCjyjSnUP7NgG31QXgTE8IcYuTY2fwcOOSl9q7OAel lSkpf45QNe7809ucJXTt1yuXQ+xbX6BOGQ3nJ3s4K99GocxF2kY1VqC5M4xjBrIWj04O iOKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723808902; x=1724413702; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IY44BvNIQ8HMdyx0QMRty049Oi1G15aZuupS+GebtAw=; b=oKvZVV7OfE3E+q2Q+E+0qxbg8oLZsDoFJC2ftZFk5ZyQ3AhIueKl90Ma+C/fvpMiuy WdeuEQbL/FyqUpXrTRfnDbE0h7xk6sohS0G5jBHl9RBal2sRqGnQaMr7nzhPZ2m1UArr vFeKux+lMaPfTNhizGmfFBKFnTbBWKb4qQTukeAL4TsF0MdGI47ZokBJB9eZ5rE2jzZC KyD0WXRU2pCbX95Plc1FGnyGLOwV3M6UcAtiEZcOFjxrr2TB9IjNAQ9aQf+OMgDfs2z9 KuOyV4Augv0Q8ShH4Lz11oIRCpEZH5AOeYs60NDewUoYBffVaQ5a4qUtyljDBqk2YXNc F80Q== X-Forwarded-Encrypted: i=1; AJvYcCVEAgSAGuPsAH8+aB9R/IluFs1dJGw7wGNZ3nOCM7zM2hfOPEuYMr9heIcQ8mCZZCTlXuyI8CKq59ehQe8DhfWV1xfJCdj8ZcnWrboRBiKgDmTw6Nc= X-Gm-Message-State: AOJu0Yx/t8I6lKvIhR87uTU1y+qXVkbX5CX8k1YVZAPhF3wrIcmVrC3H FihDdWiSCmmPeHYQj/MxOumACfbYxQDC3xVkkmFYT2qpfo+nrzRo X-Google-Smtp-Source: AGHT+IEMqNZbH50JXVZEb5SoTpw0eEiq2X6PpNhKEqpktgqE6co9AWSShXZz8K636iWMPF7XES4lEA== X-Received: by 2002:a17:907:3fa4:b0:a72:64f0:552e with SMTP id a640c23a62f3a-a8394e34235mr243281566b.19.1723808901548; Fri, 16 Aug 2024 04:48:21 -0700 (PDT) Received: from skbuf ([188.25.134.29]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a83839344fdsm244834166b.100.2024.08.16.04.48.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Aug 2024 04:48:20 -0700 (PDT) Date: Fri, 16 Aug 2024 14:48:17 +0300 From: Vladimir Oltean To: Furong Xu <0x1207@gmail.com> Cc: Serge Semin , Andrew Lunn , "David S. Miller" , Alexandre Torgue , Jose Abreu , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Joao Pinto , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, xfr@outlook.com, rock.xu@nio.com Subject: Re: [PATCH net-next v2 0/7] net: stmmac: FPE via ethtool + tc Message-ID: <20240816114817.gp7m6k2rlz7s4e5a@skbuf> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240816_044825_517104_4F0C8EA4 X-CRM114-Status: GOOD ( 12.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 13, 2024 at 07:47:26PM +0800, Furong Xu wrote: > Move the Frame Preemption(FPE) over to the new standard API which uses > ethtool-mm/tc-mqprio/tc-taprio. > > Changes in v2: > 1. refactor FPE verification processe > 2. suspend/resume and kselftest-ethtool_mm, all test cases passed > 3. handle TC:TXQ remapping for DWMAC CORE4+ This is starting to look better and better. I wouldn't be sad if it was merged like this, but the locking still looks a little bit wacky to me, and it's not 100% clear what priv->mm_lock protects and what it doesn't. I can make a breakdown of how each member of fpe_cfg is used, and thus understand exactly what are the locking needs and how they are addressed in this version, but most likely not today.