From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Jakub Kicinski" <kuba@kernel.org>,
"Russell King" <linux@armlinux.org.uk>,
davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
linux-arm-kernel@lists.infradead.org,
"Herve Codina" <herve.codina@bootlin.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Vladimir Oltean" <vladimir.oltean@nxp.com>,
"Köry Maincent" <kory.maincent@bootlin.com>,
"Jesse Brandeburg" <jesse.brandeburg@intel.com>,
"Marek Behún" <kabel@kernel.org>,
"Piergiorgio Beruto" <piergiorgio.beruto@gmail.com>,
"Oleksij Rempel" <o.rempel@pengutronix.de>,
"Nicolò Veronese" <nicveronese@gmail.com>,
"Simon Horman" <horms@kernel.org>,
mwojtas@chromium.org, "Nathan Chancellor" <nathan@kernel.org>,
"Antoine Tenart" <atenart@kernel.org>,
"Marc Kleine-Budde" <mkl@pengutronix.de>,
"Dan Carpenter" <dan.carpenter@linaro.org>,
"Romain Gantois" <romain.gantois@bootlin.com>,
"Maxime Chevallier" <maxime.chevallier@bootlin.com>
Subject: Re: [PATCH net-next v17 00/14] Introduce PHY listing and link_topology tracking
Date: Sat, 17 Aug 2024 17:47:15 +0200 [thread overview]
Message-ID: <20240817174715.77522d52@windsurf> (raw)
In-Reply-To: <6b84cdf2-34c8-4e61-857e-79a1d5e782da@lunn.ch>
Hello Andrew,
On Sat, 17 Aug 2024 17:43:52 +0200
Andrew Lunn <andrew@lunn.ch> wrote:
> > Jakub, as you say it looks solid. I can add to that that I have been using
> > this series widely through the double Ethernet attachment on several boards
> > and it works well, it is stable and more performant than the dirty home-made
> > solution we had on v4.14.
>
> Have you posted a Tested-by:
>
> You can also post Reviewed-by: if you have taken a look at the
> code. It won't have the same value as one from Rusell, but it does add
> some degree of warm fuzzy feeling this code is O.K, and it starts
> building your reputation as a reviewer.
Hmm did you check the replies from Christophe to each patch of this
series? He has already posted a Tested-by and Reviewed-by to every
single patch in the series :-)
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
prev parent reply other threads:[~2024-08-17 15:48 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-09 6:30 [PATCH net-next v17 00/14] Introduce PHY listing and link_topology tracking Maxime Chevallier
2024-07-09 6:30 ` [PATCH net-next v17 01/14] net: phy: Introduce ethernet link topology representation Maxime Chevallier
2024-08-14 14:28 ` Christophe Leroy
2024-07-09 6:30 ` [PATCH net-next v17 02/14] net: sfp: pass the phy_device when disconnecting an sfp module's PHY Maxime Chevallier
2024-08-14 14:29 ` Christophe Leroy
2024-07-09 6:30 ` [PATCH net-next v17 03/14] net: phy: add helpers to handle sfp phy connect/disconnect Maxime Chevallier
2024-08-14 14:29 ` Christophe Leroy
2024-07-09 6:30 ` [PATCH net-next v17 04/14] net: sfp: Add helper to return the SFP bus name Maxime Chevallier
2024-08-14 14:29 ` LEROY Christophe
2024-08-14 14:33 ` Christophe Leroy
2024-07-09 6:30 ` [PATCH net-next v17 05/14] net: ethtool: Allow passing a phy index for some commands Maxime Chevallier
2024-08-14 14:30 ` Christophe Leroy
2024-07-09 6:30 ` [PATCH net-next v17 06/14] netlink: specs: add phy-index as a header parameter Maxime Chevallier
2024-08-14 14:30 ` Christophe Leroy
2024-07-09 6:30 ` [PATCH net-next v17 07/14] net: ethtool: Introduce a command to list PHYs on an interface Maxime Chevallier
2024-08-14 14:30 ` Christophe Leroy
2024-07-09 6:30 ` [PATCH net-next v17 08/14] netlink: specs: add ethnl PHY_GET command set Maxime Chevallier
2024-08-14 14:31 ` Christophe Leroy
2024-07-09 6:30 ` [PATCH net-next v17 09/14] net: ethtool: plca: Target the command to the requested PHY Maxime Chevallier
2024-08-14 14:31 ` Christophe Leroy
2024-07-09 6:30 ` [PATCH net-next v17 10/14] net: ethtool: pse-pd: " Maxime Chevallier
2024-08-14 14:31 ` Christophe Leroy
2024-07-09 6:30 ` [PATCH net-next v17 11/14] net: ethtool: cable-test: " Maxime Chevallier
2024-08-14 14:32 ` Christophe Leroy
2024-08-27 5:25 ` Pengfei Xu
2024-08-27 5:33 ` Maxime Chevallier
2024-08-27 6:19 ` Pengfei Xu
2024-08-27 8:27 ` Dan Carpenter
2024-08-27 8:37 ` Maxime Chevallier
2024-08-27 8:48 ` Maxime Chevallier
2024-08-27 9:17 ` Dan Carpenter
2024-07-09 6:30 ` [PATCH net-next v17 12/14] net: ethtool: strset: Remove unnecessary check on genl_info Maxime Chevallier
2024-08-14 14:32 ` Christophe Leroy
2024-07-09 6:30 ` [PATCH net-next v17 13/14] net: ethtool: strset: Allow querying phy stats by index Maxime Chevallier
2024-08-14 14:32 ` Christophe Leroy
2024-07-09 6:30 ` [PATCH net-next v17 14/14] Documentation: networking: document phy_link_topology Maxime Chevallier
2024-08-14 14:33 ` Christophe Leroy
2024-07-15 15:31 ` [PATCH net-next v17 00/14] Introduce PHY listing and link_topology tracking Jakub Kicinski
2024-07-16 8:16 ` Maxime Chevallier
2024-07-17 15:26 ` Jakub Kicinski
2024-08-16 17:02 ` Christophe Leroy
2024-08-16 17:11 ` Jakub Kicinski
2024-08-17 15:43 ` Andrew Lunn
2024-08-17 15:47 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240817174715.77522d52@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=atenart@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=herve.codina@bootlin.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=jesse.brandeburg@intel.com \
--cc=kabel@kernel.org \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=mkl@pengutronix.de \
--cc=mwojtas@chromium.org \
--cc=nathan@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicveronese@gmail.com \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=piergiorgio.beruto@gmail.com \
--cc=romain.gantois@bootlin.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).