From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C346DC3DA4A for ; Mon, 19 Aug 2024 07:36:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8NyA3r+0SEkxLBULpRBSrNH9reIkd05NfXfPtxwYdwY=; b=qzgETp9/boM/oD9zu3QLr5uwlP 2ucR4P5rMpxHBO5M17rGeMgmDla0XCBunsndpCHlsHhB2sZiAcrQRN4s1ku9Uussxkfq8X2MhgTa/ A6Dx4A5H4PZrvXO7m0I8Zb9AX6oN6+txSRhY2xPsQaF5BWQD0gjT+GoLHV804k9x7VXp1I5FBKT6H Oc9/idbppsCiJg435eaNSYBD1r6OO7xuHDRV0r1hREZY5PNYKv2D58k1czUhpD/oUDe+BnnWfnPzE C5eylWVpV+/8M84vs/uW22xqFU/ybk093P0lns4S0PyWlZD5t9g9bxY82HxoaRyys0l9k0hq0poc/ DyZB4NUg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sfwwI-00000000evY-0Cyv; Mon, 19 Aug 2024 07:36:30 +0000 Received: from mail-ej1-x631.google.com ([2a00:1450:4864:20::631]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sfwvb-00000000eo3-355t for linux-arm-kernel@lists.infradead.org; Mon, 19 Aug 2024 07:35:49 +0000 Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-a7aada2358fso779198366b.0 for ; Mon, 19 Aug 2024 00:35:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1724052945; x=1724657745; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=8NyA3r+0SEkxLBULpRBSrNH9reIkd05NfXfPtxwYdwY=; b=ov9lB1lJ0kq+ucP/feMgtCA8h94amdyh6jpeinTO3VJtbnKcDPqjrRqHS9PGvjOWoA Dc9TqW6P47LI7ewQkyyKfUJgysQF5Pi+anGujyvVbYWMoBfkQTub7GO9rhMLhu3+GilE 6QC7dULtqMcbCEktODg1lJuRV2Cq8UJmW9p4RBWnvGeveIx61++5Op/jjPrr2CD+aQp6 Y5GjEZTsr4KnHwDASgWuy6E5mRazBB7PuZKiSEPagrBrAVvJWqrtjZBauzcSfXPw2rrm 2FCAulElqPawKq8fNrSfIvReM4pZVGFI3kWfHebrWhI/dQQ7Z+Mrnu6CtRar8Ow1sjXR VVww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724052945; x=1724657745; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8NyA3r+0SEkxLBULpRBSrNH9reIkd05NfXfPtxwYdwY=; b=xK+TIZ2PuvJrEGV6bOJ3acdH9TPov8GgzEZHrfZ61p+fa/vFnNyCG4lH1W3qXYBC14 WTBBfIHckK9XS0wyGzfJ+EZt4V0bMy4vtc00elHSMABykM89fG4dNhnlcs+hNrgvI1Pn xPVEl+SAiIEtSqWKKcAlyHtJYjbMt6C0Il2JdWoOrCIHa9GciaDdUleFssfGGR0NpSli ncvWrekmz5cjNtcbM8U6W3CZMSnjm/NR5Dt1lN4pKhUpUF2SiGzdK5KGYePG7oNVb/4s U2S6lCt/XvPd5l317QtDfSQyyLp+kDot6uUUvondvxK0QMSgfFvuqXL57gVViIOeLZ5x Natw== X-Forwarded-Encrypted: i=1; AJvYcCWHnkQzLvKhweRDy+V9NtQwjfHwtbVl9cfjxPnnNtPTtbd6UpuH6+rZ0jVLwnCM2UKUtkm+N9h04k78/0DncfW8FGhFtu+gn+BXWfR6pvKhtH4lkSc= X-Gm-Message-State: AOJu0YxexQ/zo+jyskoL2dDxODkaoGL52GAUXuNuP0PCuvcA5yHj/kGA gQZpAP3I6o21SzDYh//9V9UvxYC8aqskr5AR472mXJfOQGL804fvW01Eh4Y5CHs= X-Google-Smtp-Source: AGHT+IFGNW4Rp1MF9pErnW5tAeVHGUBzNbSFgBGlimGRBnHwWDOlPps9HXt2/6wAXUpzwZnZvX8mQw== X-Received: by 2002:a17:907:6d2a:b0:a72:5967:b34 with SMTP id a640c23a62f3a-a8394f7e0b9mr963569066b.22.1724052944878; Mon, 19 Aug 2024 00:35:44 -0700 (PDT) Received: from localhost (2001-1ae9-1c2-4c00-20f-c6b4-1e57-7965.ip6.tmcz.cz. [2001:1ae9:1c2:4c00:20f:c6b4:1e57:7965]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a83838c6c07sm603195566b.43.2024.08.19.00.35.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Aug 2024 00:35:44 -0700 (PDT) Date: Mon, 19 Aug 2024 09:35:43 +0200 From: Andrew Jones To: Rob Herring Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, maz@kernel.org, mark.rutland@arm.com, saravanak@google.com, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, Anup Patel Subject: Re: [PATCH v3] of/irq: Support #msi-cells=<0> in of_msi_get_domain Message-ID: <20240819-3fd4ff3cfa1d216a1241f5a0@orel> References: <20240817074107.31153-2-ajones@ventanamicro.com> <20240818161816.GA173148-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240818161816.GA173148-robh@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240819_003547_795874_3B9FDEF2 X-CRM114-Status: GOOD ( 13.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Aug 18, 2024 at 10:18:16AM GMT, Rob Herring wrote: > On Sat, Aug 17, 2024 at 09:41:08AM +0200, Andrew Jones wrote: ... > > + of_for_each_phandle(&it, err, np, "msi-parent", "#msi-cells", 0) { > > + d = irq_find_matching_host(it.node, token); > > + if (d) > > + return d; > > + of_node_put(it.node); > > Pretty sure the iterator does this for you. I can fixup when applying. Doh, I managed to mess up my usage of OF APIs twice. Thanks for applying the fixup. > > I plan to tag for stable too. Good idea. Thanks, drew