From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C08C7C52D6F for ; Mon, 19 Aug 2024 16:49:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CQq7jiu5nhsTeq53Mdwt04g68KWgt9jRB0QW4ToAIj8=; b=gzIaKnH32Z0mKZNJcXx5pjmIUk DEWsQyLiV+2OyBkP0ScaQwy3vt0j28MA3xJPIGcu1CWL+286At5FpcXmqqtSJIIRjKp7kJAECeG6L LcIaZzPGOa+PlK72zDb+cFLVcXls/mmvhiFNzbrmVeOfYQBktLwnyDRRXxrl7Pkqdb/3+FGsqocvb i7B2li5YZZxQBlUPXqWaxmAFZoMrkGk/LTfKKH89FQBYTqEMkWViJyzof2oPDAB8O242cRY0oqPM6 WZ0ydkWNs5JZ3PTXiOZALsH+V4U7eJEMlVswHtRtlO78foDWm4WDQEZnWmX4leUxdOlVHo8Ui3A0X x9sHZDQA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sg5Yt-00000002Eju-0zpF; Mon, 19 Aug 2024 16:48:55 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sg5YC-00000002EXm-0f17 for linux-arm-kernel@lists.infradead.org; Mon, 19 Aug 2024 16:48:13 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 574B460C58; Mon, 19 Aug 2024 16:48:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E9173C32782; Mon, 19 Aug 2024 16:48:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724086091; bh=ZxHbad6RitBAjGXVtdlyclNzqb3Q+8yJ+JbTUUPlqxc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WzTrBhW1Tw3lH7/JwU6UYsvxcLhIq2pRiwjKbLb2xWwdyLyrtlrkJFSXO3XWMeBlm huM2ILpKsUF+v8Sp7hX/RConnhUo3uylrgworTA4x1hmCFct1pY6dcZmX+smfZd7WB okB4SvfGmvV94TY7OSlIpja1WhNH13halZPieYDrj3EuFBEsK3s5JIzCnua9d9/x3N NMkrXnblZVhbOn1yN9Ma7jKCk5fppm0lIyVJocfi1W1zO6aslQhUZFLb87hrzbA9/c +99ZyJnnrNjXn6UadOEwfV77fXE2jGKGd21LI1gHrr4c8Pv8Z98sphBnx0zIu7IFWc UlkoOtA3GDccw== Date: Mon, 19 Aug 2024 17:48:06 +0100 From: Conor Dooley To: Dmitry Torokhov Cc: Krzysztof Kozlowski , Arnd Bergmann , Mark Brown , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, patches@opensource.cirrus.com Subject: Re: [PATCH 09/14] dt-bindings: input: samsung,s3c6410-keypad: introduce compact binding Message-ID: <20240819-backstab-fanatic-54788c691f9c@spud> References: <20240819045813.2154642-1-dmitry.torokhov@gmail.com> <20240819045813.2154642-10-dmitry.torokhov@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="/IykXYf3e9Pofwc3" Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240819_094812_282022_C2F5A4FF X-CRM114-Status: GOOD ( 16.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --/IykXYf3e9Pofwc3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 19, 2024 at 08:49:10AM -0700, Dmitry Torokhov wrote: > On Mon, Aug 19, 2024 at 03:02:07PM +0200, Krzysztof Kozlowski wrote: > > On Sun, Aug 18, 2024 at 09:58:06PM -0700, Dmitry Torokhov wrote: > >=20 > > > + - keypad,num-columns > > > + - keypad,num-rows > > > + > > > required: > > > - compatible > > > - reg > > > - interrupts > > > - - samsung,keypad-num-columns > > > - - samsung,keypad-num-rows > > > + > > > +if: > >=20 > > put allOf: here and this within allOf, so you the "if" could grow in the > > future. >=20 > Hmm, there is already "allOf" at the beginning of the file, so adding > another one results in complaints about duplicate "allOf". I can move it > all to the top, like this: >=20 > allOf: > - $ref: input.yaml# > - $ref: matrix-keymap.yaml# > - if: > required: > - linux,keymap > then: > properties: > samsung,keypad-num-columns: false > samsung,keypad-num-rows: false > patternProperties: > '^key-[0-9a-z]+$': false > else: > properties: > keypad,num-columns: false > keypad,num-rows: false > required: > - samsung,keypad-num-columns > - samsung,keypad-num-rows >=20 > Is this OK? I don't quite like that "tweaks" are listed before main > body of properties. The normal thing to do is to put the allOf at the end, not the start, in cases like this, for the reason you mention. --/IykXYf3e9Pofwc3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZsN3RgAKCRB4tDGHoIJi 0kZYAP4raAnB9vYkB1nibRW+mvk8v9yS0OpBDt7tSNpTgrznKAD/WDUUMuO/AhZe vKzxIMJHkd3e3CZCvVaqQsd7xlAibQM= =dVMh -----END PGP SIGNATURE----- --/IykXYf3e9Pofwc3--