From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A533C3DA4A for ; Mon, 19 Aug 2024 05:01:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LOtLgRKGQX67ieoH/CsjydrcIz7BO5T8N0kmB5YnlVI=; b=ftYCnBmzvU+WMvv6KsaKz0Fq6+ VKos14jhZgQ1IseNq4liAC+Fab6l3ypMk+sRNgdtxpc3/C8qV2Km1IjxS93BlKJ5cabhJVl/Stevg j+CdWpX6AhS3SuDUtde1loKk4skacY/JTPkev+4NuqEDMIG4YL6ZvF6fUq79wNudmGG4tfEmcdqfp 3gC4kDfEuOxPLmhUTClsvIVNwdiuNYyJ4kibikEjvLOvoHvrumRlqPWLNLEJ4m4Jh8JScxuE7agNZ hWG0bDtrolRck+u00KUFcsUXo9IzaXL1HLR3ok4Ba9j+BNbvLeQa4YV1umj9hUP4ZBBlCG9N5zq7i YxUyestA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sfuVx-00000000MI5-2SQT; Mon, 19 Aug 2024 05:01:09 +0000 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sfuTO-00000000LWb-2doe for linux-arm-kernel@lists.infradead.org; Mon, 19 Aug 2024 04:58:31 +0000 Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-2020e83eca1so18381755ad.2 for ; Sun, 18 Aug 2024 21:58:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724043510; x=1724648310; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LOtLgRKGQX67ieoH/CsjydrcIz7BO5T8N0kmB5YnlVI=; b=ej8Ph3+HTfXePX/1BdAPgBT8c3Qtxx8jR2bPCgSmw0m+zccgzZVUuYagZ/hOBSFNz9 g+xks8Vhhw9A8pdmNAWDaJDfzN6h3iZdmhnJ0/bDR9Miqu4SlGv7FFRPp1ztuYj6X3ik Qosic/0DrJcDrljkEDn5eMOFQlH8T8VCd6laBmEG3JPM0vuymKwhLY4BCuj5Mn/P664M HoUxdHc+SFc7WsLt4NMWHYFk6ZS43HpRnObe+TFS05vyLAQMwMFMglLKetGDPW1g9EKp /cathb8VYX4omlVZlxPBGQWfG/nCGlKhhd5RHImYtulxdPr+rHZrrMMwWNH6W6GaCCGf 4MEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724043510; x=1724648310; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LOtLgRKGQX67ieoH/CsjydrcIz7BO5T8N0kmB5YnlVI=; b=neSimnir/3RXfStkL/tpSdmh8aj/P1j4nx4Nwvy+n1yjm2lGQXhqcB+J6bnsUYCBmt +CtD8UvAQcpAuOWrkinFGak7nCKx+y9fL+DvtGZlSDsiSlBUn8NVfzZwPEVrH8O43kMl IjndaH/Vq3LTDin/4e2Pmb+02aYSmnzS9Qb109PrAEYhEXt78Gr3cZDrGLdeoa9+r+9e QEmNzwVyydmwemV68pWJj0dmmf+wppucikEnGK1IcSor6DCV2pwIUJp8WOcVowsX7FKg rclkrDt7u/eLJC1yTt7tahdeInELiLXWIT9JTQ6A5Iibfr80LnjUSPAMF9qKFDCRABFR XNKA== X-Forwarded-Encrypted: i=1; AJvYcCWfa2KbJ6Y2PONsjMELRwlHAeVvAtEjgaLSssGdL6pq5IzhxwAgNZ3Lo3fUwo2cAxMRHe78FuAwqwvbtYtwnQx/KqopAHxD3IPJZ75IhhFwo73zpqc= X-Gm-Message-State: AOJu0Yz/8WAcC2blpCm/p9DqWoq+R6YWVdKvxmK73trzaManl78CUeHd TaV63tP7gn2uAxruFz19ySx+Hu88ho4vCHtmStjJ3wFTEZ22KmSV94FfeA== X-Google-Smtp-Source: AGHT+IG7z/IgqBi5/Yx/2Hbbxy5OTXuTpDW4aR1o4zjIypuyxKSQLBYOYO5MbFoTrw1EKbtLekzQNw== X-Received: by 2002:a17:902:c408:b0:1fa:fbe1:284e with SMTP id d9443c01a7336-20203c084f2mr85137675ad.0.1724043509348; Sun, 18 Aug 2024 21:58:29 -0700 (PDT) Received: from dtor-ws.sjc.corp.google.com ([2620:15c:9d:2:4eb5:4500:6efc:6c24]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-202068497b4sm43483445ad.269.2024.08.18.21.58.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Aug 2024 21:58:28 -0700 (PDT) From: Dmitry Torokhov To: Arnd Bergmann , Mark Brown , Krzysztof Kozlowski Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH 03/14] Input: samsung-keypad - do not combine memory allocation checks Date: Sun, 18 Aug 2024 21:58:00 -0700 Message-ID: <20240819045813.2154642-4-dmitry.torokhov@gmail.com> X-Mailer: git-send-email 2.46.0.184.g6999bdac58-goog In-Reply-To: <20240819045813.2154642-1-dmitry.torokhov@gmail.com> References: <20240819045813.2154642-1-dmitry.torokhov@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240818_215830_695380_525A07A4 X-CRM114-Status: GOOD ( 15.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The driver uses devm API to allocate resources so there's no reason to do allocations first and then check and release everything at once. Check results immediately after doing allocation of each resource. Signed-off-by: Dmitry Torokhov --- drivers/input/keyboard/samsung-keypad.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/input/keyboard/samsung-keypad.c b/drivers/input/keyboard/samsung-keypad.c index 46c0d0c900f6..2be3bfa87ce1 100644 --- a/drivers/input/keyboard/samsung-keypad.c +++ b/drivers/input/keyboard/samsung-keypad.c @@ -349,8 +349,11 @@ static int samsung_keypad_probe(struct platform_device *pdev) keypad = devm_kzalloc(&pdev->dev, sizeof(*keypad) + keymap_size, GFP_KERNEL); + if (!keypad) + return -ENOMEM; + input_dev = devm_input_allocate_device(&pdev->dev); - if (!keypad || !input_dev) + if (!input_dev) return -ENOMEM; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); -- 2.46.0.184.g6999bdac58-goog