From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D77AAC3DA4A for ; Mon, 19 Aug 2024 16:02:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GSiqHXqbz/dxhZh6dGqqKlI/fhZqPW1I8+SkT3StJno=; b=3mhrhO0DeqvgxS /7CCu0M0ft95RY3+FtzJ+kvtRc2LUp2JZBE2y59ge2Ou9Yvs0S3HUZE8byDzt04qcUSGX9R92ZJed v8a4aoqPg+MOvsOsGbl7llg5gOHyTKbaVwK32O4tz8r8czutD0202vpnx4VF9hsvFaFWY1wSjkmOw 0LxrjX4CeHTZ62lJ+DqFTHKL3ef17376RZw5JrqsrV4tdMqY70tCgHNsU6hENp66N1YpJ1ua+Eks6 nrNIuRToFnDZlWN8I59+ntaaRrFlxSPKEOlPsYhIYkiBI4UCrunZnG2eJoTHenDkdLpdXThy4SoEM /QvJ/Rq8t40cGx9BJyxg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sg4pM-0000000241X-3jlx; Mon, 19 Aug 2024 16:01:52 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sg4nu-000000023M2-3hAh for linux-arm-kernel@lists.infradead.org; Mon, 19 Aug 2024 16:00:24 +0000 Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Wncg16YwRz6K97L; Mon, 19 Aug 2024 23:57:17 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 182301400DB; Tue, 20 Aug 2024 00:00:21 +0800 (CST) Received: from localhost (10.203.177.66) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 19 Aug 2024 17:00:20 +0100 Date: Mon, 19 Aug 2024 17:00:19 +0100 From: Jonathan Cameron To: Krzysztof Kozlowski Subject: Re: [PATCH v2 11/13] memory: ti-aemif: simplify with dev_err_probe() Message-ID: <20240819170019.00002dd0@Huawei.com> In-Reply-To: <20240816-cleanup-h-of-node-put-memory-v2-11-9eed0ee16b78@linaro.org> References: <20240816-cleanup-h-of-node-put-memory-v2-0-9eed0ee16b78@linaro.org> <20240816-cleanup-h-of-node-put-memory-v2-11-9eed0ee16b78@linaro.org> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml500004.china.huawei.com (7.191.163.9) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240819_090023_291879_26299D73 X-CRM114-Status: GOOD ( 16.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , linux-samsung-soc@vger.kernel.org, Maxime Coquelin , linux-pm@vger.kernel.org, Alexandre Torgue , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Claudiu Beznea , Thierry Reding , linux-arm-kernel@lists.infradead.org, Alim Akhtar , Santosh Shilimkar , linux-tegra@vger.kernel.org, Jonathan Hunter , linux-stm32@st-md-mailman.stormreply.com, Lukasz Luba Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 16 Aug 2024 12:54:35 +0200 Krzysztof Kozlowski wrote: > Use dev_err_probe() to avoid dmesg flood on actual defer. This makes > the code also simpler. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Changes in v2: > 1. New patch > --- > drivers/memory/ti-aemif.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/memory/ti-aemif.c b/drivers/memory/ti-aemif.c > index e192db9e0e4b..360f2705b1ff 100644 > --- a/drivers/memory/ti-aemif.c > +++ b/drivers/memory/ti-aemif.c > @@ -345,10 +345,8 @@ static int aemif_probe(struct platform_device *pdev) > platform_set_drvdata(pdev, aemif); > > aemif->clk = devm_clk_get(dev, NULL); > - if (IS_ERR(aemif->clk)) { > - dev_err(dev, "cannot get clock 'aemif'\n"); > - return PTR_ERR(aemif->clk); > - } > + if (IS_ERR(aemif->clk)) > + return dev_err_probe(dev, PTR_ERR(aemif->clk), "cannot get clock 'aemif'\n"); Bit of a long line, so maybe wrap. Up to maintainers Reviewed-by: Jonathan Cameron > > ret = clk_prepare_enable(aemif->clk); > if (ret) >